[Rt-commit] rt branch, 4.2/defaults-in-signencrypt, repushed

[Brian Duggan]

The branch 4.2/defaults-in-signencrypt was deleted and repushed:
       was 9250a1c71d0b76563faa8fb86f8d939cca6dd354
       now 385b84c68de8e35b2b021e27f4c0d102bf9c8e08

1:  9250a1c ! 1:  385b84c Default to sign, encrypt when calling bare SignEncrypt method
    @@ -1,9 +1,17 @@
     Author: Alex Vandiver <alexmv at bestpractical.com>
     
    -    Actually provide defaults here, necessary for to/from defaulting
    +    Default to sign, encrypt when calling bare SignEncrypt method
         
    -    All callsites pass both params, and the default kicks in deeper already
    -    anyways, but this ensures that from/to values are defaulted correctly.
    +    All callsites within RT pass both Sign and Encrypt parameters when
    +    calling RT::Crypt->SignEncrypt. But there were no defaults for when
    +    this method is called from a script or extension. The
    +    RT::Crypt::GnuPG->SignEncrypt and RT::Crypt::SMIME->SignEncrypt
    +    methods both default to signing and encrypting on their own. But
    +    RT::Crypt->SignEncrypt would fail to set message senders and
    +    recipients before calling the GnuPG or SMIME versions if it was called
    +    without Sign and Encrypt parameters. These defaults ensure that the
    +    method maintains signers/senders and encryption targets/recipients,
    +    regardless of how it is called.
     
     diff --git a/lib/RT/Crypt.pm b/lib/RT/Crypt.pm
     --- a/lib/RT/Crypt.pm