[Rt-commit] rt branch, 4.4/no-password-on-external-auth, created. rt-4.4.2-38-g571423b

[Jim Brandt]

The branch, 4.4/no-password-on-external-auth has been created
        at  571423b2d0ebc686f5e00ced170307ce2afe024a (commit)

- Log -----------------------------------------------------------------
commit 571423b2d0ebc686f5e00ced170307ce2afe024a
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Sep 14 14:04:57 2017 -0400

    Add ExternalAuth to the exceptions for requiring a password
    
    External authentication can be enable in RT via WebRemoteUserAuth,
    which handles authentication in Apache and passes REMOTE_USER to
    RT, or via ExternalAuth, which calls an external system from RT.
    Add the second to the configuration checks to determine if
    external authentication is enabled and a password check cannot be
    done.

diff --git a/lib/RT/User.pm b/lib/RT/User.pm
index 7b89d21..f4024a3 100644
--- a/lib/RT/User.pm
+++ b/lib/RT/User.pm
@@ -1163,8 +1163,9 @@ sub CurrentUserRequireToSetPassword {
         RequireCurrent => 1,
     );
 
-    if ( RT->Config->Get('WebRemoteUserAuth')
-        && !RT->Config->Get('WebFallbackToRTLogin')
+    if ( (RT->Config->Get('WebRemoteUserAuth')
+        && !RT->Config->Get('WebFallbackToRTLogin'))
+        || RT->Config->Get('ExternalAuth')
     ) {
         $res{'CanSet'} = 0;
         $res{'Reason'} = $self->loc("External authentication enabled.");

-----------------------------------------------------------------------