[Rt-commit] rt branch, 4.4/improve-jump-to-unread-ui, repushed

Maureen Mirville maureen at bestpractical.com
Fri Sep 15 13:39:36 EDT 2017


The branch 4.4/improve-jump-to-unread-ui was deleted and repushed:
       was 73bca409c389d3003d8ba993d4e9294550c6c377
       now b8e3d3bb2e8637e06900bdf761a40258fc87132f

1:  73bca40 ! 1:  b8e3d3b Improve UI of unread messages notification
    @@ -9,6 +9,7 @@
         difficult to see. UI updated with buttons instead. Previous
         variable, "UpdateStatus" was changed to "UnreadMessages" to make
         it clear that it refers to tickets with unread messages.
    +    Corresponding tests also updated accordingly.
         
         Fixes: I#30082
         Fixes: I#32584
    @@ -114,3 +115,54 @@
              if ( $status ne $ticket->Status ) {
                  my ( $val, $msg ) = $ticket->SetStatus($status);
                  push @results, loc( "Ticket [_1]: [_2]", $id, $msg );
    +
    +diff --git a/t/web/self_service.t b/t/web/self_service.t
    +--- a/t/web/self_service.t
    ++++ b/t/web/self_service.t
    +@@
    + 
    + # mark the message as read
    + $m->follow_link_ok(
    +-    { text => 'jump to the first unread message and mark all messages as seen' },
    ++    { text => 'Mark as Seen' },
    +     'followed mark as seen link'
    + );
    + 
    +
    +diff --git a/t/web/ticket_seen.t b/t/web/ticket_seen.t
    +--- a/t/web/ticket_seen.t
    ++++ b/t/web/ticket_seen.t
    +@@
    + use strict;
    + use warnings;
    + 
    +-use RT::Test nodata => 1, tests => 23, config => 'Set($ShowUnreadMessageNotifications, 1);';
    ++use RT::Test nodata => 1, tests => undef, config => 'Set($ShowUnreadMessageNotifications, 1);';
    + 
    + my $queue = RT::Test->load_or_create_queue( Name => 'Regression' );
    + ok $queue && $queue->id, 'loaded or created queue';
    +@@
    +     );
    + 
    +     $agent_a->follow_link_ok(
    +-        { text => 'jump to the first unread message' },
    ++        { text => 'Jump to Unread' },
    +         'try to jump to first unread message'
    +     );
    +     like( $agent_a->base, qr/#txn-$reply_id$/, 'contains anchor' );
    + 
    +-    $agent_a->follow_link_ok({text => 'jump to the first unread message and mark all messages as seen'}, 'try to mark all as seen');
    +     $agent_a->content_contains(
    +         'Marked all messages as seen',
    +         'see success message'
    +     );
    +     like( $agent_a->base, qr/#txn-$reply_id$/, 'contains anchor' );
    +-
    +     $agent_a->content_contains(
    +         'Marked all messages as seen',
    +         'see success message'
    +@@
    +     );
    + }
    + 
    ++done_testing();



More information about the rt-commit mailing list