[Rt-commit] rt branch, 4.4/shredder-single-member-group-resolver-avoid-duplicates, created. rt-4.4.2-133-g4e82d9290

? sunnavy sunnavy at bestpractical.com
Thu Apr 12 10:49:05 EDT 2018


The branch, 4.4/shredder-single-member-group-resolver-avoid-duplicates has been created
        at  4e82d929007ad212810fc6fa1de8f6ccf08d2d9a (commit)

- Log -----------------------------------------------------------------
commit 4e82d929007ad212810fc6fa1de8f6ccf08d2d9a
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Apr 12 21:44:11 2018 +0800

    Avoid duplicated single member group resolvers
    
    There is no need to add the same resolver multiple times. Duplicated
    resolvers could result in errors like:
    
        Couldn't wipeout object: Group already has member: Nobody

diff --git a/lib/RT/GroupMember.pm b/lib/RT/GroupMember.pm
index 581666b8f..b227062f3 100644
--- a/lib/RT/GroupMember.pm
+++ b/lib/RT/GroupMember.pm
@@ -561,7 +561,7 @@ sub __DependsOn {
 
             return;
         },
-    );
+    ) unless $args{Shredder}->{_resolver_mark}{SingleMemberGroupResolver}++;
 
     return $self->SUPER::__DependsOn( %args );
 }

-----------------------------------------------------------------------


More information about the rt-commit mailing list