[Rt-commit] rt branch, 4.4/dump-and-merge-initialdata, updated. rt-4.4.3-141-g6e2d549c0

? sunnavy sunnavy at bestpractical.com
Mon Aug 6 21:09:15 EDT 2018


The branch, 4.4/dump-and-merge-initialdata has been updated
       via  6e2d549c0c6a939c22dd9977b8d42edc809a875d (commit)
      from  a8278a5a99e43b743fedf5dd074cf6057099894e (commit)

Summary of changes:
 t/api/initialdata-roundtrip.t | 4 ++++
 1 file changed, 4 insertions(+)

- Log -----------------------------------------------------------------
commit 6e2d549c0c6a939c22dd9977b8d42edc809a875d
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Aug 7 08:45:33 2018 +0800

    Make sure RT::Extension::Initialdata::JSON is available for perls prior to 5.14
    
    In the first eval block, we rely on "$handler_candidate->require or die
    ..." in RT::Handle::InsertData to throw the exception if
    RT::Extension::Initialdata::JSON is not installed, but the "local $@"
    before it clobbers the exception in perls prior to 5.14 :/
    
    Thus we need the 2nd block to confirm.

diff --git a/t/api/initialdata-roundtrip.t b/t/api/initialdata-roundtrip.t
index 14f2995ff..961ceab0e 100644
--- a/t/api/initialdata-roundtrip.t
+++ b/t/api/initialdata-roundtrip.t
@@ -16,6 +16,10 @@ CONFIG
     );
 };
 
+eval {
+    require RT::Extension::Initialdata::JSON;
+};
+
 if ( $@ ) {
     plan skip_all => 'Unable to test without RT::Extension::Initialdata::JSON';
 }

-----------------------------------------------------------------------


More information about the rt-commit mailing list