[Rt-commit] rt branch, 4.4/improve-jump-to-unread-ui, repushed

[Maureen Mirville]

The branch 4.4/improve-jump-to-unread-ui was deleted and repushed:
       was 7639e3ee02be877525c8e64d7847f031dc882d99
       now c36fe43affebd21be2aa2c8020d2c51cec6a5f19

1: 7639e3ee0 ! 1: c36fe43af Improve UI of unread messages notification
    @@ -63,27 +63,24 @@
      <div class="unread-messages">
      <&| /Widgets/TitleBox, title => loc('New messages'), title_href => "#txn-". $txn->id &>
     -<&|/l&>There are unread messages on this ticket.</&>
    - <&|/l, 
    +-<&|/l, 
     - RT->Config->Get('WebPath') ."/$DisplayPath/Display.html?id=". $Ticket->id. "#txn-".$txn->id,
    ++<&|/l,
     + RT->Config->Get('WebPath') ."/$DisplayPath/Display.html?id=". $Ticket->id. "&MarkAsSeen=1",
       RT->Config->Get('WebPath') ."/$DisplayPath/Display.html?id=". $Ticket->id ."&MarkAsSeen=1&Anchor=txn-" . $txn->id
     - &>You can <a href="[_1]">jump to the first unread message</a> or <a href="[_2]">jump to the first unread message and mark all messages as seen</a>.</&>
     + &>
    ++<div class="new-messages-on-ticket">
    ++<&|/l&>There are unread messages on this ticket.</&>
    ++</div>
     +<div>
     +<a class="button" href="[_1]">Mark as Seen</a>
     +<a class="button" href="[_2]">Jump to Unread</a>
     +</div>
    -+<&|/l&>There are unread messages on this ticket.</&>
     +</&>
      </&>
      </div>
      <%ARGS>
    -@@
    - <%INIT>
    - return unless (RT->Config->Get( 'ShowUnreadMessageNotifications', $session{'CurrentUser'}));
    - my $txn = $Ticket->SeenUpTo or return;
    --
    - </%INIT>
     
     diff --git a/share/html/Tools/MyDay.html b/share/html/Tools/MyDay.html
     --- a/share/html/Tools/MyDay.html
    @@ -116,6 +113,23 @@
                  my ( $val, $msg ) = $ticket->SetStatus($status);
                  push @results, loc( "Ticket [_1]: [_2]", $id, $msg );
     
    +diff --git a/share/static/css/base/ticket.css b/share/static/css/base/ticket.css
    +--- a/share/static/css/base/ticket.css
    ++++ b/share/static/css/base/ticket.css
    +@@
    + .ticket-summary .titlebox .titlebox-title .left a, .ticket-summary .titlebox .titlebox-title .left a:visited { color: #fff;}
    + 
    + .unread-messages .titlebox-content :link {
    +-    text-decoration: underline;
    ++    text-decoration: none;
    ++}
    ++
    ++.new-messages-on-ticket {
    ++    font-style: italic;
    + }
    + 
    + .ticket-inactive {
    +
     diff --git a/t/web/self_service.t b/t/web/self_service.t
     --- a/t/web/self_service.t
     +++ b/t/web/self_service.t
    @@ -146,9 +160,3 @@
          $agent_a->content_contains(
              'Marked all messages as seen',
              'see success message'
    -     );
    -     like( $agent_a->base, qr/#txn-$reply_id$/, 'contains anchor' );
    --
    -     $agent_a->content_contains(
    -         'Marked all messages as seen',
    -         'see success message'