[Rt-commit] rt branch, 4.4/update-queue-hidden, created. rt-4.4.2-70-gd33f67c3b

[Craig Kaiser]

The branch, 4.4/update-queue-hidden has been created
        at  d33f67c3b84590b4cb60f931cd32e356d6dd6a91 (commit)

- Log -----------------------------------------------------------------
commit 18f496ee22bc6096d1dbe15baec7a2614fb571a2
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Feb 5 14:50:19 2018 -0500

    Hide Queue if Requestor does not have right to see
    
    It is possible for a User to be a Requestor on a Ticket and not have the
    right to view the Tickets Queue. If this is the case, when editing
    basics the current Queue cannot be displayed as the dropdown value for
    Queue. Thus resulting in the next available Queue being submitted as the
    new Queue for the Ticket. This causes unwanted Queue changed to the
    Ticket.

diff --git a/share/html/Elements/SelectObject b/share/html/Elements/SelectObject
index 7a4ecdfc9..21f0e34f7 100644
--- a/share/html/Elements/SelectObject
+++ b/share/html/Elements/SelectObject
@@ -122,6 +122,14 @@ if ( not defined $session{$cache_key} and not $Lite ) {
                 };
             }
         }
+        if ( ref($object) eq 'RT::Queue' ) {
+            unless ($session{CurrentUser}->HasRight( Object => $object, Right => 'SeeQueue' )) {
+                push @{$session{$cache_key}{objects}}, {
+                    Id          => undef,
+                    Name        => 'Hidden Queue',
+                };
+            }
+        }
     }
 
     while (my $object = $collection->Next) {

commit d33f67c3b84590b4cb60f931cd32e356d6dd6a91
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Wed Feb 7 09:43:31 2018 -0500

    Add Queue update option for Ticket update page

diff --git a/share/html/Ticket/Update.html b/share/html/Ticket/Update.html
index 8b4ba94c2..e5938834a 100644
--- a/share/html/Ticket/Update.html
+++ b/share/html/Ticket/Update.html
@@ -106,6 +106,15 @@
                 Default      => $ARGS{'Owner'}
             }
         },
+        { name => 'Queue',
+            comp => '/Elements/SelectQueue',
+            args => {
+            Name => 'Queue',
+            TicketObj => $TicketObj,
+            Default => $TicketObj->QueueObj->Id,
+            ShowNullOption => 0,
+            }
+        },
         { special => 'roles' },
         {   name => 'Worked',
             comp => '/Elements/EditTimeValue',

-----------------------------------------------------------------------