[Rt-commit] rt branch, 4.4/clean-rights-cf-admin-ui, repushed

Maureen Mirville maureen at bestpractical.com
Thu Feb 15 16:00:53 EST 2018


The branch 4.4/clean-rights-cf-admin-ui was deleted and repushed:
       was 06a22d3e04711594ee932006fbfcd150175552c5
       now 04c129514d8716503f45ee67ee8f55f831523804

1: 06a22d3e0 ! 1: 04c129514 Correct error messages on user rights for CF admin UI
    @@ -1,10 +1,11 @@
     Author: Maureen E. Mirville <maureen at bestpractical.com>
     
    -    Correct error messages in user rights for CF admin UI
    +    Correct error messages on user rights for CF admin UI
         
         Error message for when a user attempts to view the admin page for
    -    a custom field's user rights with no id or an invalid id corrected
    -    as previous error messages were unclear.
    +    a custom field's user rights (/Admin/CustomFields/UserRights.html)
    +    with no id or an invalid id in the URL, corrected as previous error
    +    messages were unclear.
         
         Fixes: I#32827
     
    @@ -16,12 +17,12 @@
      
      if (!defined $id) {
     -    $m->comp("/Elements/Error", Why => loc("No Class defined"));
    -+    $m->comp("/Elements/Error", Why => loc("No custom field defined"));
    ++    $m->comp("/Elements/Error", Why => loc("No Custom Field defined"));
      }
      
      my $CustomFieldObj = RT::CustomField->new($session{'CurrentUser'});
     -$CustomFieldObj->Load($id) || $m->comp("/Elements/Error", Why => loc("Couldn't load Class [_1]",$id));
    -+$CustomFieldObj->Load($id) || $m->comp("/Elements/Error", Why => loc("Couldn't load custom field #[_1]",$id));
    ++$CustomFieldObj->Load($id) || $m->comp("/Elements/Error", Why => loc("Couldn't load Custom Field #[_1]",$id));
      
      my $title = loc('Modify user rights for custom field [_1]', $CustomFieldObj->Name);
      



More information about the rt-commit mailing list