[Rt-commit] rt branch, 4.4/improve-add-custom-role-message, repushed

[Maureen Mirville]

The branch 4.4/improve-add-custom-role-message was deleted and repushed:
       was 3910976e1318a966b629870fedf004c2a286c93a
       now 9a320bd25098daff6b76e4438ef9897dc3eac890

1: 3910976e1 ! 1: 9a320bd25 Improve message when applying/removing custom roles from queues
    @@ -13,13 +13,15 @@
     --- a/lib/RT/CustomRole.pm
     +++ b/lib/RT/CustomRole.pm
     @@
    + 
    +     return ( 0, $self->loc('Permission Denied') )
              unless $queue->CurrentUserHasRight('AdminCustomRoles');
    - 
    +-
    ++use Data::Printer colored => 1;
          my $rec = RT::ObjectCustomRole->new( $self->CurrentUser );
     -    return $rec->Add( %args, CustomRole => $self );
     +    my ( $status, $add ) = $rec->Add( %args, CustomRole => $self );
    -+    my $msg;
    -+    $msg = $self->loc("[_1] added to queue [_2]", $self->Name, $queue->Name) if $status;
    ++    my $msg = $self->loc("[_1] added to queue [_2]", $self->Name, $queue->Name) if $status;
     +
     +    return ( $add, $msg );
      }
    @@ -35,8 +37,7 @@
          return (0, $self->loc('Custom role is not added') ) unless $rec->id;
     -    return $rec->Delete;
     +    my ( $status, $delete ) = $rec->Delete;
    -+    my $msg;
    -+    $msg = $self->loc("[_1] removed from queue [_2]", $self->Name, $queue->Name) if $status;
    ++    my $msg = $self->loc("[_1] removed from queue [_2]", $self->Name, $queue->Name) if $status;
     +
     +    return ( $delete, $msg );
      }