[Rt-commit] rt branch, 4.4/dropdown-menu-limit-config, repushed

[Maureen Mirville]

The branch 4.4/dropdown-menu-limit-config was deleted and repushed:
       was 4f16f4ee6d4dded20f62ac878bcbab0fa0159347
       now 7b3dc18d5801dcb80f27da494410ef8d7278faf8

1: 4f16f4ee6 ! 1: 7b3dc18d5 Make RT owner dropdown limit a config option
    @@ -2,27 +2,45 @@
     
         Make RT owner dropdown limit a config option
         
    -    The owner dropdown menu on a ticket's Modify People page becomes an
    -    autocomplete field once there are greater than 50 values. As some
    -    users may want to change this limit, a new config option was added
    -    so it can easily be updated, rather than using a callback. Existing
    -    callbacks on this limit will continue to work as expected.
    +    The Owner dropdown menu, used in various places in RT, automatically
    +    changes from a dropdown menu to an autocomplete field once there are
    +    greater than 50 values. As some users may want to change this limit,
    +    a new config option was added so it can easily be updated, rather
    +    than using a callback. Existing callbacks on this limit will continue
    +    to work as expected.
     
     diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
     --- a/etc/RT_Config.pm.in
     +++ b/etc/RT_Config.pm.in
    +@@
    + alleviate the sometimes huge owner list for installations where many
    + users have the OwnTicket right.
    + 
    +-Autocompleter is automatically turned on if list contains more than
    +-50 users, but penalty of executing potentially slow query is still paid.
    ++The Owner entry is automatically converted to an autocomplete box if the list
    ++of owners exceeds C<$DropdownMenuLimit> items. However, the query to generate
    ++the list of owners is still run and this can increase page load times. If
    ++your owner lists exceed the limit and you are using the autocomplete box, you
    ++can improve performance by explicitly setting C<$AutocompleteOwners>.
    + 
    + Drop down doesn't show unprivileged users. If your setup allows unprivileged
    + to own ticket then you have to enable autocompleting.
     @@
      
      Set($AutocompleteOwners, 0);
      
     +=item C<$DropdownMenuLimit>
     +
    -+The owner dropdown menu on a ticket's Modify People page changes from a
    -+dropdown menu to an autocomplete field once the menu holds more than the
    -+DropdownMenuLimit.
    ++The Owner dropdown menu, used in various places in RT including the Query
    ++Builder and ticket edit pages, automatically changes from a dropdown menu to
    ++an autocomplete field once the menu holds more than the C<$DropdownMenuLimit>
    ++owners. Dropdown menus become more difficult to use when they contain a large
    ++number of values and the autocomplete textbox can be more usable.
     +
    -+Please note that setting this limit to a value greater than the default
    -+value, 50, may increase the page load time.
    ++If you have very large numbers of users who can be owners, this can cause
    ++slow page loads on pages with an Owner selection. See L</$AutocompleteOwners>
    ++for a way to potentially speed up page loads.
     +
     +=cut
     +
    @@ -40,7 +58,7 @@
      }
      
     -my $dropdown_limit = 50;
    -+my $dropdown_limit = RT->Config->Get( 'DropdownMenuLimit' );
    ++my $dropdown_limit = RT->Config->Get( 'DropdownMenuLimit' ) || 50;
      $m->callback( CallbackName => 'ModifyDropdownLimit', DropdownLimit => \$dropdown_limit );
      
      if (keys(%user_uniq_hash) > $dropdown_limit ) {