[Rt-commit] rt branch, 4.4/include-article-queue, repushed
Craig Kaiser
craig at bestpractical.com
Wed Jan 31 13:57:13 EST 2018
The branch 4.4/include-article-queue was deleted and repushed:
was 3d7995ee4a9f674ae0b7108d49eac9299dab041d
now 0906f983a89cd49048d5d59ed96591882fc631be
-: ------- > 1: 5aaa240d5 Avoid spuriously unchecking all recipient checkboxes
-: ------- > 2: 51731a684 Make RT owner dropdown limit a config option
1: 1f7048ba5 ! 3: 4c5a93cea Add Default Article option for Queues
@@ -58,7 +58,7 @@
+
+ my $article = RT::Article->new( RT->SystemUser );
+
-+ if ( $value ne "undef" ){
++ if ( $value ne "" ){
+ my ($ret, $msg) = $article->Load( $value );
+ return (0, $msg) unless ($ret);
+ }
@@ -70,7 +70,7 @@
+ return ($status, $msg) unless $status;
+
+ # If Default Article set to none we expect 'undef' as value
-+ my $ret_val = $value ne 'undef' ? 'updated to ' . $article->Name : 'removed';
++ my $ret_val = $value ne "" ? 'updated to ' . $article->Name : 'removed';
+ return (1, $self->loc("Default Article [_1]", $ret_val));
+}
@@ -101,21 +101,6 @@
# we're asking about enabled on the web page but really care about disabled
if ( $SetEnabled ) {
@@
- ARGSRef => \%ARGS,
- );
-
-+
- push @results, UpdateRecordObject(
- AttributesRef => \@attribs,
- Object => $QueueObj,
- ARGSRef => \%ARGS
- );
-
-+
- $Disabled = $ARGS{'Disabled'} = $Enabled? 0: 1;
-
- $EnabledChecked = "" if $QueueObj->Disabled;
-@@
$CommentAddress => undef
$SetSLAEnabled => undef
$SetEnabled => undef
2: 11e7e03a4 ! 4: a3bea53bc Make default Article content show on Ticket create
@@ -14,8 +14,8 @@
Queue => $Queue->Id,
);
+
-+ if ( $m->request_path =~ 'Create' ){
-+ my %args = %$parent_args;
++ my %args = %$parent_args;
++ if ( !$args{'id'} ){
+ my $queue_id = $args{'Queue'};
+
+ my $QueueObj = RT::Queue->new($session{'CurrentUser'});
3: 3d7995ee4 = 5: 0906f983a Add test for default Article content on create.html
More information about the rt-commit
mailing list