[Rt-commit] rtir branch, 4.0/correspondents-from-makeclicky, repushed

[Brian Duggan]

The branch 4.0/correspondents-from-makeclicky was deleted and repushed:
       was 32947733684f9177bd2c6d862b69b7d18699a3b6
       now 098fb441709b72d45bae9f8d385b66e5bdd7a732

1: bcb13751 = 1: bcb13751 Update MakeClicky test text for readability
2: d3de9323 = 2: d3de9323 Test for MakeClicky email links on all RTIR ticket types
3: 9139028a = 3: 9139028a Test for 'Investigate to' links next to MakeClicky email adddresses
4: 3acf7ac5 ! 4: 43ad44c4 Test Correspondents field on 'Investigate to' investigation creation
    @@ -53,14 +53,16 @@
     +                    $agent->submit_form_ok(
     +                        {
     +                            form_id => 'CreateInQueue',
    -+                        }, 'submitted new investigation form' );
    ++                        },
    ++                        'submitted new investigation form',
    ++                    );
     +                    $agent->title_is( 'Launch a new investigation', 'launching a new investigation' );
     +                    $agent->form_name( 'TicketCreate' );
     +                    my @correspondents = $agent->find_all_inputs(
     +                        name => 'Requestors',
     +                        type => 'text',
    -+                        value => $email
    -+                        );
    ++                        value => $email,
    ++                    );
     +                    is( $#correspondents, 0, "correspondents populated with $email");
     +                    use Data::Dumper;
                      }
5: 32947733 ! 5: 098fb441 Pass Requestors through queue selection modal if provided
    @@ -1,17 +1,14 @@
     Author: Brian C. Duggan <brian at bestpractical.com>
     
    -    Set correspondents from "Investigate to" MakeClicky link
    +    Pass Requestors through queue selection modal if provided
         
    -    When @Active_MakeClicky contains "email", Incident ticket displays add
    -    a "Investigate to" link to email addresses in message bodies. The
    -    "Investigate to" link opens a page that allows the user to select an
    -    Investigation queue and create a ticket in it. The resulting ticket
    -    creation page did not set Correspondents at all. It should set
    -    Correspondents to the value of the email the user clicked "Investigate
    -    to" on.
    +    ebe8874d introduced the new queue selection modal which requires some
    +    values intended for the create page to be written as hidden fields so
    +    they are passed on when submitted.
         
    -    This change sets Correspondents to the MakeClicky email address
    -    on new tickets created from "Investigate to" links.
    +    This change adds Requestors to support the Investigate to
    +    link. Previously the "Investigate to" email addresses were being lost
    +    on the queue modal and not appearing in the Correspondents field.
     
     diff --git a/html/Callbacks/RTIR/Elements/MakeClicky/Default b/html/Callbacks/RTIR/Elements/MakeClicky/Default
     --- a/html/Callbacks/RTIR/Elements/MakeClicky/Default
    @@ -32,11 +29,8 @@
     -                . "&Requestors=$escaped_email")
     +                . "&Requestors=$uri_escaped_email")
                      . qq{">}
    --                . loc('Investigate to') .qq{</a>};
    -+                .loc('Investigate to') .qq{</a>};
    +                 . loc('Investigate to') .qq{</a>};
              }
    -         my $domain = (split /@/, $email, 2)[1];
    -         my $escaped_domain = $escaper->($domain);
     
     diff --git a/html/RTIR/Elements/CreateInRTIRQueueModal b/html/RTIR/Elements/CreateInRTIRQueueModal
     --- a/html/RTIR/Elements/CreateInRTIRQueueModal