[Rt-commit] rtir branch, 4.0/correspondents-from-makeclicky, repushed

[Brian Duggan]

The branch 4.0/correspondents-from-makeclicky was deleted and repushed:
       was d5f3bd2d7d38ae3ee877a75fc6751eca099ea12e
       now 5d4c728552f815b1d117cd6244df423480b71476

1: e1d3b6a7 ! 1: 092aa3d8 Test Correspondents field on 'Investigate to' investigation creation
    @@ -118,7 +118,6 @@
     +            my $investigate_link = $agent->find_link( url_regex => qr/\QRequestors=$email\E/,
     +                                                   text_regex => qr/^\Qinvestigate to\E$/i ) if $is_incident;
     +
    -+            $agent->save_content('/tmp/x.html');
     +            if ( $clicky{'email'} ) {
     +                ok( $email_link,                                   "Found link for $email_link" );
     +                ok( $email_link->url =~ /(?<!\w)\Qq=$email\E(?!\w)/, 'URL link '.$email_link->url.' has an email address: '.$email );
2: b8a6415d = 2: bb42b466 Pass Requestors through queue selection modal if provided
3: 515c14ed ! 3: 5655b875 Test emails with +tags for 'Investigate to' MakeClicky links
    @@ -34,7 +34,7 @@
     +            my $investigate_link = $agent->find_link( url_regex => qr/\QRequestors=$uri_escaped_email\E/,
                                                         text_regex => qr/^\Qinvestigate to\E$/i ) if $is_incident;
      
    -             $agent->save_content('/tmp/x.html');
    +             if ( $clicky{'email'} ) {
     @@
                      # Then test taht the Correspondents field is populated with the given email address.
                      if ( $is_incident ) {
4: d5f3bd2d ! 4: 5d4c7285 Handle emails with +tags in 'Investigate to' MakeClicky links
    @@ -5,7 +5,7 @@
         Email addresses with +tags were not URI-escaped in the RTIR MakeClicky
         callback for 'Investigate to' links. Then, the CreateInRTIRQueueModal
         would URI-unescape the Requestors GET parameter, replacing + with a
    -    sapce in the hidden input field. The modal passed that incorrect value
    +    space in the hidden input field. The modal passed that incorrect value
         to the RTIR investigation creation page.
         
         This change URI-escapes the email address in the RTIR MakeClicky