[Rt-commit] rt branch, 4.4/fix-shredder-uid-check, repushed

[Craig Kaiser]

The branch 4.4/fix-shredder-uid-check was deleted and repushed:
       was 1904c6a18e356a52cd132bdfadf298e9347147e5
       now e40c643408125e8d754656b254a27c949cf2659f

1: 670c34589 = 1: 670c34589 Add test to hit shredder web UI
2: 1904c6a18 ! 2: e40c64340 Restrict Name checks to objects with Name and only when id is not numeric
    @@ -1,15 +1,16 @@
     Author: Craig Kaiser <craig at bestpractical.com>
     
    -    Restrict Name checks to objects with name method available
    +    Restrict Name checks to objects with Name and only when id is not numeric
         
    -    92dc904 updated the id check in Shredder to allow names to be
    -    passed in addition to numeric ids. However, it relies on the ->Name
    -    method and not all shreddable objects have that method, resulting
    -    in errors like:
    +    92dc904 updated the id check in Shredder to handle the case where $id is actually a Name.
    +    However, it breaks the case where $id is not a Name, which could produce errors like:
         
         error: RT::Ticket::Name Unimplemented in RT::Shredder
         
    -    Restrict the ->Name check to only objects that have the Name method.
    +    This commit fixes it to:
    +    
    +    * Not check Name if $id is numeric.
    +    * Not check Name if object doesn't have it.
     
     diff --git a/lib/RT/Shredder.pm b/lib/RT/Shredder.pm
     --- a/lib/RT/Shredder.pm