[Rt-commit] rtir branch, 4.0/pass-tests, updated. 4.0.0-74-gacfb3ffa

? sunnavy sunnavy at bestpractical.com
Wed Mar 7 19:00:35 EST 2018


The branch, 4.0/pass-tests has been updated
       via  acfb3ffac0f1b186ee904d45631cc5d8d0adc9ca (commit)
      from  ae37a617918ef586969e8fde133093b64c574e8d (commit)

Summary of changes:
 html/RTIR/Link/FromIncident/Refine.html | 1 +
 1 file changed, 1 insertion(+)

- Log -----------------------------------------------------------------
commit acfb3ffac0f1b186ee904d45631cc5d8d0adc9ca
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Mar 8 07:23:22 2018 +0800

    Lifecycle is needed to build ResultPage and BaseQuery from ARGS
    
    Here is a failure case without it: to link IRs to an incident(via "Link"
    on incident display page), the "Edit Search" link has args "id" and
    "Lifecycle", which is set to the incident id and "incident_reports",
    respectively.
    
    After any action in the builder(e.g. "Add these terms and Search"),
    "Lifecycle" arg is lost, so ResultPage and BaseQuery relying on it are
    wrong, which results in wrong links in page menu and also wrong page
    title.

diff --git a/html/RTIR/Link/FromIncident/Refine.html b/html/RTIR/Link/FromIncident/Refine.html
index 18ccff01..9f90e93e 100644
--- a/html/RTIR/Link/FromIncident/Refine.html
+++ b/html/RTIR/Link/FromIncident/Refine.html
@@ -58,5 +58,6 @@ return $m->comp(
         Lifecycle       => $ARGS{'Lifecycle'},
         NotMemberOf => $ARGS{'id'},
     ),
+    ExtraQueryParams => [ 'Lifecycle' ],
 );
 </%INIT>

-----------------------------------------------------------------------


More information about the rt-commit mailing list