[Rt-commit] rtir branch, 4.0/pass-tests, repushed

? sunnavy sunnavy at bestpractical.com
Fri Mar 9 14:48:55 EST 2018


The branch 4.0/pass-tests was deleted and repushed:
       was d1fc4ecda71e62ab1f8cf30f01df039f1fb17395
       now 7361a19942bca9f927efc4162540cd5163285a82

 1: 345f1714 =  1: 345f1714 Auth::Crypt has been removed from plugin since RT 4.4
 2: ad1a60ed =  2: ad1a60ed "undef $m" to make tests exit cleanly
 3: 9eaefadc =  3: 9eaefadc update tests for the changed content returned from whois.verisign-grs.com
 4: 36ffa65a =  4: 36ffa65a remove duplicated "undef $agent"
 5: 35512e20 !  5: fdf8605d no need to parse URI if it's empty
    @@ -19,7 +19,7 @@
      
          my $txn = $self->TransactionObj;
     -    my $uri = $txn->NewValue ||'';
    -+    my $uri = $txn->NewValue or return 0;
    ++    my $uri = $txn->NewValue or return 1;
      
          my $uri_obj = RT::URI->new( $self->CurrentUser );
          my ($status) = $uri_obj->FromURI( $uri );
 6: 4b9a078b !  6: bd63a92b refactor goto_create_rtir_ticket to use real lifecycle name
    @@ -20,7 +20,14 @@
     +
     +    my $queue_obj = RT::Queue->new(RT->SystemUser);
     +    $queue_obj->Load($queue);
    -+    my $lifecycle = $queue_obj->Lifecycle || 'default';
    ++    my $lifecycle;
    ++    if ( $queue_obj->id ) {
    ++        $lifecycle = $queue_obj->Lifecycle;
    ++    }
    ++    else {
    ++        warn "Failed to load queue: $queue";
    ++    }
    ++    $lifecycle ||= 'Default';
      
          $self->get_ok("/RTIR/CreateInQueue.html?Lifecycle=$lifecycle");
          $self->click_through_createinqueue( $queue );
 7: 462934e5 =  7: 4dcddc3e turn debug on for Net::Whois::RIPE only when we have debug log
 8: c691ffc3 =  8: b2907e38 add a missing warnings check for t/tools/lookup.t
 9: a7f8c9e1 =  9: e3856af9 add missing warnings checks for gpg tests
10: f31efcb9 = 10: 9ca429e1 use string cmparison for "Constituency" checks and take care of empty values
11: 24d301f2 = 11: 91067443 Lifecycle is needed to build ResultPage and BaseQuery from ARGS
12: d1fc4ecd = 12: 7361a199 Use lexical iterator so inline test server can render articles



More information about the rt-commit mailing list