[Rt-commit] rt branch, 4.4/history-scroll-header, repushed
Maureen Mirville
maureen at bestpractical.com
Mon Mar 19 17:44:12 EDT 2018
The branch 4.4/history-scroll-header was deleted and repushed:
was f34a856b6e6f6cd3d679c3737ba3f9235f116d9a
now 2547f51dcbc341bc74ca4762dc4775bffff6bd12
1: 2be2cf851 = 1: 2be2cf851 respect ShowHeaders option from request for ScrollShowHistory
2: f34a856b6 ! 2: 2547f51dc Fix ExtraArgs of callback ExtraShowHistoryArguments in ScrollShowHistory
@@ -1,12 +1,14 @@
Author: sunnavy <sunnavy at bestpractical.com>
- fix ExtraArgs of callback ExtraShowHistoryArguments in ScrollShowHistory
+ Fix ExtraArgs of callback ExtraShowHistoryArguments in ScrollShowHistory
Previously ShowDisplayModes and ShowTitle were always true, which made
the callback pretty useless.
ScrollShowHistory option was also wrongly ignored when determining if
there should be a TitleBox or not.
+
+ Fixes: I#32699
diff --git a/share/html/Elements/ShowHistoryHeader b/share/html/Elements/ShowHistoryHeader
--- a/share/html/Elements/ShowHistoryHeader
@@ -29,7 +31,7 @@
$m->comp('/Elements/QueryString', %params, id => $Ticket->id );
-my %extra_args;
-+my %extra_args = map { $ARGS{$_} // 1 } for qw/ShowDisplayModes ShowTitle ScrollShowHistory ShowHeaders/;
++my %extra_args = map { $ARGS{$_} // 1 } qw/ShowDisplayModes ShowTitle ScrollShowHistory ShowHeaders/;
$m->callback( CallbackName => 'ExtraShowHistoryArguments', Ticket => $Ticket, ExtraArgs => \%extra_args );
-my $ShowDisplayModes = 1 || $extra_args{'ShowDisplayModes'};
More information about the rt-commit
mailing list