[Rt-commit] rt branch, 4.4/message-box-callback-ref, created. rt-4.4.2-101-g3d70ca0fb

[? sunnavy]

The branch, 4.4/message-box-callback-ref has been created
        at  3d70ca0fbdd210bc3cd70f2613a653cf9884737b (commit)

- Log -----------------------------------------------------------------
commit b025093187e147c331b7b40d2ded9dc9640bded8
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Tue Aug 1 10:15:47 2017 -0400

    Pass message as a reference
    
    07f739afc added $message to the Default callback. Pass it as
    a reference to be consistent with the parameter name MessageRef.

diff --git a/share/html/Elements/MessageBox b/share/html/Elements/MessageBox
index 74b7037c4..64caaf992 100644
--- a/share/html/Elements/MessageBox
+++ b/share/html/Elements/MessageBox
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 <textarea autocomplete="off" class="messagebox <% $Type eq 'text/html' ? 'richtext' : '' %>" <% $width_attr %>="<% $Width %>" rows="<% $Height %>" <% $wrap_type |n %> name="<% $Name %>" id="<% $Name %>" placeholder="<% $Placeholder %>">
 % $m->comp('/Articles/Elements/IncludeArticle', %ARGS) if $IncludeArticle;
-% $m->callback( %ARGS, SignatureRef => \$signature, DefaultRef => \$Default, MessageRef => $message );
+% $m->callback( %ARGS, SignatureRef => \$signature, DefaultRef => \$Default, MessageRef => \$message );
 % if (RT->Config->Get("SignatureAboveQuote", $session{'CurrentUser'})) {
 <% $Default || '' %><% $signature %><% $message %></textarea>
 % }

commit 2261075fe9004124d2bc06029fd248e64f6d506b
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Mar 26 23:43:01 2018 +0800

    Fix the indent of AdminConditionsAndActions item

diff --git a/docs/UPGRADING-4.4 b/docs/UPGRADING-4.4
index 66d362261..03923059e 100644
--- a/docs/UPGRADING-4.4
+++ b/docs/UPGRADING-4.4
@@ -591,6 +591,8 @@ You can delete these records from the Attributes table using a DELETE
 and the same WHERE clause. Always make sure you have a known good backup
 of your database before making updates.
 
+=back
+
 =item *
 
 RT now has the functionality from

commit 3d70ca0fbdd210bc3cd70f2613a653cf9884737b
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Mar 26 23:43:54 2018 +0800

    Document the MessageRef value change

diff --git a/docs/UPGRADING-4.4 b/docs/UPGRADING-4.4
index 03923059e..1fc0fe133 100644
--- a/docs/UPGRADING-4.4
+++ b/docs/UPGRADING-4.4
@@ -604,6 +604,15 @@ installation.
 
 =back
 
+=head1 UPGRADING FROM 4.4.2 AND EARLIER
+
+=over 4
+
+=item *
+
+The C<MessageRef> parameter of the default callback of C</Elements/MessageBox>
+now contains the reference to the message content as the name implies.
+
 =back
 
 =cut

-----------------------------------------------------------------------