[Rt-commit] rt branch, 4.4/fix-include-article-on-create, created. rt-4.4.2-105-g6ce7c7261

? sunnavy sunnavy at bestpractical.com
Fri Mar 30 12:29:51 EDT 2018


The branch, 4.4/fix-include-article-on-create has been created
        at  6ce7c7261beeccec46f25ac9d37f7625bc5f7920 (commit)

- Log -----------------------------------------------------------------
commit 6ce7c7261beeccec46f25ac9d37f7625bc5f7920
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Mar 31 00:23:04 2018 +0800

    Don't create ticket if user clicks "Go" buttons of "Include Article"
    
    If $ArticleOnTicketCreate is true, there are "Go" buttons on ticket
    create page, which we failed to catch before.

diff --git a/share/html/Ticket/Create.html b/share/html/Ticket/Create.html
index e1b347d7a..e5639f085 100644
--- a/share/html/Ticket/Create.html
+++ b/share/html/Ticket/Create.html
@@ -505,7 +505,7 @@ $m->callback( CallbackName => 'BeforeCreate', ARGSRef => \%ARGS, skip_create =>
 $m->comp( '/Articles/Elements/CheckSkipCreate', ARGSRef => \%ARGS, skip_create => \$skip_create,
               checks_failure => $checks_failure, results => \@results );
 
-if ((!exists $ARGS{'AddMoreAttach'}) and (defined($ARGS{'id'}) and $ARGS{'id'} eq 'new')) { # new ticket?
+if ((!exists $ARGS{'AddMoreAttach'}) and (!exists $ARGS{'Go'}) and (defined($ARGS{'id'}) and $ARGS{'id'} eq 'new')) { # new ticket?
     if ( !$checks_failure && !$skip_create ) {
         $m->comp('Display.html', %ARGS);
         $RT::Logger->crit("After display call; error is $@");

-----------------------------------------------------------------------


More information about the rt-commit mailing list