[Rt-commit] rt branch, 4.4/fix-init-callback-in-show-links-of-type, created. rt-4.4.2-238-g4f343de68

? sunnavy sunnavy at bestpractical.com
Thu May 17 10:10:44 EDT 2018


The branch, 4.4/fix-init-callback-in-show-links-of-type has been created
        at  4f343de68f8a90cbf7969cadbfa9bc666a85ecf4 (commit)

- Log -----------------------------------------------------------------
commit 4f343de68f8a90cbf7969cadbfa9bc666a85ecf4
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu May 17 21:51:48 2018 +0800

    Fix Type/Recurse/MaxDepth params in Init callback of /Elements/ShowLinksOfType
    
    It's wrong to use values as param names, especially when there are
    potential conflicts.

diff --git a/share/html/Elements/ShowLinksOfType b/share/html/Elements/ShowLinksOfType
index 74220f150..9f0aa73c0 100644
--- a/share/html/Elements/ShowLinksOfType
+++ b/share/html/Elements/ShowLinksOfType
@@ -110,9 +110,9 @@ $m->callback(
     CallbackName => "Init",
     ARGSRef      => \%ARGS,
     Object       => $Object,
-    $Type        => $Type,
-    $Recurse     => \$Recurse,
-    $MaxDepth    => \$MaxDepth,
+    Type         => $Type,
+    Recurse      => \$Recurse,
+    MaxDepth     => \$MaxDepth,
     active       => \@active,
     inactive     => \@inactive,
     not_tickets  => \@not_tickets,

-----------------------------------------------------------------------


More information about the rt-commit mailing list