[Rt-commit] rt branch, 4.4/rescue-outlook-html, repushed

Gergely Nagy algernon at bestpractical.com
Mon Oct 22 09:17:13 EDT 2018


The branch 4.4/rescue-outlook-html was deleted and repushed:
       was dc6144d493c40e25f66d270dacd74ce9b8d88c47
       now aa608d1380b2e444831e453620230267e04a36a6

1: 1b5024ff4 ! 1: a4aab176f Make it possible to select the part type in the Outlook mail tests
    @@ -1,13 +1,11 @@
     Author: Gergely Nagy <algernon at bestpractical.com>
     
    -    t/mail/outlook.t: Make it possible to select the part type with test_email
    +    Make it possible to select the part type in the Outlook mail tests
         
    -    Normally, we want to test against the `text/plain` part of a multipart email,
    -    but there are cases where we'd rather test against the `text/html` part. To make
    -    this possible, `test_email` takes an additional argument:
    -    `$check_type` (defaulting to `text/plain` if unspecified).
    -    
    -    Signed-off-by: Gergely Nagy <algernon at bestpractical.com>
    +    Normally, we want to test against the 'text/plain' part of a multipart email,
    +    but there are cases where we'd rather test against the 'text/html' part. To make
    +    this possible, 'test_email' takes an additional argument:
    +    '$check_type' (defaulting to 'text/plain' if unspecified).
     
     diff --git a/t/mail/outlook.t b/t/mail/outlook.t
     --- a/t/mail/outlook.t
2: a92b600d5 ! 2: 5e8bc0cf5 Add a new Outlook mail test case
    @@ -1,11 +1,9 @@
     Author: Gergely Nagy <algernon at bestpractical.com>
     
    -    t/mail/outlook.t: Add a new test case
    +    Add a new Outlook mail test case
         
         The new test case has the HTML part first, the text part second. The goal is to
         test that the text part gets cleaned up anyway.
    -    
    -    Signed-off-by: Gergely Nagy <algernon at bestpractical.com>
     
     diff --git a/t/mail/outlook.t b/t/mail/outlook.t
     --- a/t/mail/outlook.t
3: dc6144d49 ! 3: af941fb14 Teach RT::EmailParser::RescueOutlook how to clean up HTML mail too
    @@ -2,15 +2,13 @@
     
         Teach RT::EmailParser::RescueOutlook how to clean up HTML mail too
         
    -    `RescueOutlook` cleaned up the `text/plain` parts of a message, but over the
    +    'RescueOutlook' cleaned up the 'text/plain' parts of a message, but over the
         years, HTML mail became much more common, and the HTML parts produced by Outlook
         have similar issues. This change attempts to clean up those parts too.
         
    -    As a side-effect of the change, the way `RescueOutlook` finds the e-mail parts
    +    As a side-effect of the change, the way 'RescueOutlook' finds the e-mail parts
         to clean up has been improved: now it iterates through all parts, and cleans up
         the first text, and the first HTML part, regardless of order.
    -    
    -    Signed-off-by: Gergely Nagy <algernon at bestpractical.com>
     
     diff --git a/lib/RT/EmailParser.pm b/lib/RT/EmailParser.pm
     --- a/lib/RT/EmailParser.pm
    @@ -174,3 +172,4 @@
          }
      
          diag "Test mail with multipart/alternative";
    +
-:  ------- > 4: aa608d138 Migrate the Outlook email tests away from manual test counting



More information about the rt-commit mailing list