[Rt-commit] rt branch, 4.4-trunk, updated. rt-4.4.4-24-g6ccfdc4fd

[Jim Brandt]

The branch, 4.4-trunk has been updated
       via  6ccfdc4fd3937c21d3b001f96feec65830f474cd (commit)
       via  eb7b0ef29481eba15634ffde9a749cd92e509de9 (commit)
      from  d49581e1dcfc83ca8d7a7a338b536c0390549fd6 (commit)

Summary of changes:
 docs/UPGRADING-4.4  | 8 ++++++++
 etc/RT_Config.pm.in | 8 ++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

- Log -----------------------------------------------------------------
commit eb7b0ef29481eba15634ffde9a749cd92e509de9
Author: Maureen E. Mirville <maureen at bestpractical.com>
Date:   Mon Mar 4 10:04:06 2019 -0500

    Set the $AttachmentListCount config's default value
    
    The $AttachmentListCount value was previously set to undef, meaning
    all attachments on a ticket were displayed. When a ticket has a
    significant amount of attachments, the long list in the portlet
    affects ticket usability.

diff --git a/docs/UPGRADING-4.4 b/docs/UPGRADING-4.4
index 1fc0fe133..a84359b9d 100644
--- a/docs/UPGRADING-4.4
+++ b/docs/UPGRADING-4.4
@@ -615,4 +615,18 @@ now contains the reference to the message content as the name implies.
 
 =back
 
+=head1 UPGRADING FROM 4.4.4 AND EARLIER
+
+=over 4
+
+=item *
+
+The C<AttachmentListCount> configuration option now defaults to 5.
+To restore the previous configuration and show all attachments,
+add the following to your C<RT_SiteConfig.pm>.
+
+    Set($AttachmentListCount, undef);
+
+=back
+
 =cut
diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 54e5949e7..aca243016 100644
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -2222,14 +2222,14 @@ Set($AlwaysDownloadAttachments, undef);
 
 =item C<$AttachmentListCount>
 
-The number of attachments to display by default on ticket display and ticket
-reply pages. Attachments beyond this count will be displayed only after the
-user clicks a "Show all" link. The default value, C<undef>, means always show
+Sets the number of attachments to display on ticket display and ticket
+update pages (default is 5). Attachments beyond this number are displayed
+only after the user clicks the "Show all" link. Set to C<undef> to always show
 all attachments. A value of C<0> means show no attachments by default.
 
 =cut
 
-Set($AttachmentListCount, undef);
+Set($AttachmentListCount, 5);
 
 =item C<$PreferRichText>
 

commit 6ccfdc4fd3937c21d3b001f96feec65830f474cd
Merge: d49581e1d eb7b0ef29
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Wed Apr 17 11:34:18 2019 -0400

    Merge branch '4.4/set-default-attachmentlistcount' into 4.4-trunk

diff --cc docs/UPGRADING-4.4
index d2da81603,a84359b9d..efa9d8a3d
--- a/docs/UPGRADING-4.4
+++ b/docs/UPGRADING-4.4
@@@ -619,18 -619,14 +619,26 @@@ now contains the reference to the messa
  
  =over 4
  
 -=item *
 +=item * Privacy Menu in Query Builder
 +
 +On the Query Builder, the Privacy menu loads groups you are a member of as potential
 +places to save searches. However, it previously did not confirm the current user
 +had the EditSavedSearches right, so you might try to save a search with a group
 +and receive an error until that right was granted.
 +
 +This has been fixed, so now groups load only if you have rights to create the
 +search via EditSavedSearches on the group or globally. This may change the groups
 +that appear in the Privacy menu, but shouldn't change functionality since users
 +without the correct rights were unable to create searches.
 +
++=item * AttachmentListCount Default
+ 
+ The C<AttachmentListCount> configuration option now defaults to 5.
+ To restore the previous configuration and show all attachments,
+ add the following to your C<RT_SiteConfig.pm>.
+ 
+     Set($AttachmentListCount, undef);
+ 
  =back
  
  =cut

-----------------------------------------------------------------------