[Rt-commit] rt branch, 4.6/tweak-elevator-themes, created. rt-4.4.4-374-g6900e6c64

[? sunnavy]

The branch, 4.6/tweak-elevator-themes has been created
        at  6900e6c64af87aba3b992b04d35cae1f16179a20 (commit)

- Log -----------------------------------------------------------------
commit 3ad3ad978df83756ec9caad854a0d28a107566b7
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 30 20:17:01 2019 +0800

    Unset margin-top for .form-row in .value
    
    The structure is like:
    
    <div class="form-row">
      <div class="label col-md-3">
      </div>
      <div class="value col-md-9">
        <div class="form-row">
          ...
        </div>
      </div>
    </div>
    
    .form-row has "margin-top: 0.5em", but to align the label/value divs
    horizontally, we don't want this style for .form-row in .value
    
    This commit fixes the alignment issue of date/time inputs

diff --git a/share/static/css/elevator-light/forms.css b/share/static/css/elevator-light/forms.css
index c54e682ef..c7510406c 100644
--- a/share/static/css/elevator-light/forms.css
+++ b/share/static/css/elevator-light/forms.css
@@ -122,6 +122,10 @@ button {
     margin-top: 0.5em;
 }
 
+.form-row > .value .form-row {
+    margin-top: 0;
+}
+
 div.field label.select-queue {
     display: block;
     margin-bottom: 0;

commit ddad3b41a0f85e6678c57aa54b3ef9869f1a3c22
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 30 20:35:40 2019 +0800

    Fix height for span.form-control.current-value
    
    It's possible that current value contains multiple rows, like "Depends
    on" links, users' work time, etc.  Setting height to "auto" makes sure
    that all the rows are visible.

diff --git a/share/static/css/elevator-light/forms.css b/share/static/css/elevator-light/forms.css
index c7510406c..3a9f9173b 100644
--- a/share/static/css/elevator-light/forms.css
+++ b/share/static/css/elevator-light/forms.css
@@ -139,6 +139,7 @@ span.current-value.form-control {
     border: none;
     padding-left: 0;
     margin-top: 1px; /* because input box border is 1px */
+    height: auto;
 }
 
 .list-group-item label {

commit 23fe55cc67d564c0c6b581ff39a497e91f5ba562
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 30 21:32:21 2019 +0800

    Tweak position of approval pending hint on ticket display page

diff --git a/share/html/Ticket/Elements/ShowDependencyStatus b/share/html/Ticket/Elements/ShowDependencyStatus
index 2f6bae868..d454d0a81 100644
--- a/share/html/Ticket/Elements/ShowDependencyStatus
+++ b/share/html/Ticket/Elements/ShowDependencyStatus
@@ -45,7 +45,8 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<div class="dependency-status">
+<div class="dependency-status form-row">
+  <div class="col-md-12">
 % if ($approvals) {
     <span class="summary">
 %   if ($approvals == 1) {
@@ -59,6 +60,7 @@
   <span class="summary"><&|/l, $depends &>Pending [quant,_1,ticket,tickets].</&></span>
   <&|/l, $depends &>This ticket cannot be resolved until its [numerate,_1,dependency is,dependencies are] resolved.</&>
 % }
+  </div>
 </div>
 <%args>
 $Ticket

commit 6900e6c64af87aba3b992b04d35cae1f16179a20
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 30 21:33:11 2019 +0800

    Tweak position of ticket creation form in links widget on ticket display page

diff --git a/share/html/Elements/ShowLinks b/share/html/Elements/ShowLinks
index cd9b83ed2..3bee125e6 100644
--- a/share/html/Elements/ShowLinks
+++ b/share/html/Elements/ShowLinks
@@ -67,20 +67,24 @@
 </div>
 
 % if ($Object->isa('RT::Ticket')) {
-  <form action="<% RT->Config->Get('WebPath') ."/Helpers/SpawnLinkedTicket" %>" name="SpawnLinkedTicket">
-    <input type="hidden" name="CloneTicket" value="<% $Object->id %>">
-    <input type="submit" value="<&|/l&>Create</&>" name="SpawnLinkedTicket" class="btn btn-primary">
-    <select name="LinkType" class="selectpicker">
-      <option value="DependsOn-new"><% loc('Depends on') %></option>
-      <option value="new-DependsOn"><% loc('Depended on by') %></option>
-      <option value="MemberOf-new"><% loc('Parents') %></option>
-      <option value="new-MemberOf"><% loc('Children') %></option>
-      <option value="RefersTo-new"><% loc('Refers to') %></option>
-      <option value="new-RefersTo"><% loc('Referred to by') %></option>
-    </select>
-    <&|/l&>Ticket in</&>
-    <& /Elements/SelectNewTicketQueue, Name => 'CloneQueue' &>
-  </form>
+  <div class="form-row">
+    <div class="col-md-12">
+      <form action="<% RT->Config->Get('WebPath') ."/Helpers/SpawnLinkedTicket" %>" name="SpawnLinkedTicket">
+        <input type="hidden" name="CloneTicket" value="<% $Object->id %>">
+        <input type="submit" value="<&|/l&>Create</&>" name="SpawnLinkedTicket" class="btn btn-primary">
+        <select name="LinkType" class="selectpicker">
+          <option value="DependsOn-new"><% loc('Depends on') %></option>
+          <option value="new-DependsOn"><% loc('Depended on by') %></option>
+          <option value="MemberOf-new"><% loc('Parents') %></option>
+          <option value="new-MemberOf"><% loc('Children') %></option>
+          <option value="RefersTo-new"><% loc('Refers to') %></option>
+          <option value="new-RefersTo"><% loc('Referred to by') %></option>
+        </select>
+        <&|/l&>Ticket in</&>
+        <& /Elements/SelectNewTicketQueue, Name => 'CloneQueue' &>
+      </form>
+    </div>
+  </div>
 % }
 <%INIT>
 my @display = qw(DependsOn DependedOnBy MemberOf Members RefersTo ReferredToBy);

-----------------------------------------------------------------------