[Rt-commit] rt branch, 4.6/fix-menu-overflows, created. rt-4.4.4-534-g0479db2b0d

Blaine Motsinger blaine at bestpractical.com
Tue Dec 3 11:19:25 EST 2019


The branch, 4.6/fix-menu-overflows has been created
        at  0479db2b0dfb3ae633a51fbb6e10507f3a8ecbc2 (commit)

- Log -----------------------------------------------------------------
commit a9958b12996ee54e62bda2c2fe2c25bbdd27b614
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Thu Nov 21 12:39:03 2019 -0600

    Fix absolute right position for header
    
    The right position size was not set to correctly allow for the
    page-navigation's static size and position.  Because of it being
    too large, the subject text was overflowing into the space of the
    page-navigation for long subjects.

diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index f629171c55..b453347c6d 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -141,7 +141,7 @@ div#header {
 div#header h1 {
     position: absolute;
     left: 2em;
-    right: 20em;
+    right: 41em;
     top: 0.5em;
     height: 1.4em;
     font-size: 1.4em;

commit 0479db2b0dfb3ae633a51fbb6e10507f3a8ecbc2
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Mon Dec 2 18:53:19 2019 -0600

    Fix availableWidth overflow for main-navigation
    
    The top actions div was not being included in the availableWidth
    calculation so overflow wasn't happening at the size.

diff --git a/share/html/NoAuth/css/elevator-light/BeforeNav b/share/html/NoAuth/css/elevator-light/BeforeNav
index d5ba87531e..55e93ea7f4 100644
--- a/share/html/NoAuth/css/elevator-light/BeforeNav
+++ b/share/html/NoAuth/css/elevator-light/BeforeNav
@@ -64,9 +64,17 @@ var rebalanceOverflowMenu = function (menuId, overflowId, withLogo) {
     var overflowMenu = jQuery(overflowId);
 
     var availableWidth = jQuery(window).width();
-    if (withLogo) {
-        availableWidth -= jQuery('#logo').width();
+
+    console.log( menuId);
+
+    // adjustments specific to main-navigation
+    if (menuId === '#app-nav') {
+        if (withLogo) {
+            availableWidth -= jQuery('#logo').width();
+        }
+        availableWidth -= jQuery('#topactions').width();
     }
+
     availableWidth -= rebalanceOverflowBuffer;
 
     // if the menu is too wide for the viewport, move overflow items into

-----------------------------------------------------------------------


More information about the rt-commit mailing list