[Rt-commit] rt branch, 4.4/fix-shredder-table-names, created. rt-4.4.3-196-gd1a9e0861

[? sunnavy]

The branch, 4.4/fix-shredder-table-names has been created
        at  d1a9e08613d58f152470eeab9110e8f58ff13bda (commit)

- Log -----------------------------------------------------------------
commit d1a9e08613d58f152470eeab9110e8f58ff13bda
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Feb 12 03:58:44 2019 +0800

    Don't quote table names in shredder SQL output
    
    Quoting table names doesn't work on Pg and Oracle. Pg does support
    quoted table names, but it implies these quoted names are case
    sensitive, which is sadly not true in our case.
    
    Not quoting them here makes it consistent with schema.

diff --git a/lib/RT/Record.pm b/lib/RT/Record.pm
index 0cc188463..4d8c584f6 100644
--- a/lib/RT/Record.pm
+++ b/lib/RT/Record.pm
@@ -2604,7 +2604,7 @@ sub _AsInsertQuery
 
     my $dbh = $RT::Handle->dbh;
 
-    my $res = "INSERT INTO ". $dbh->quote_identifier( $self->Table );
+    my $res = "INSERT INTO ". $self->Table;
     my $values = $self->{'values'};
     $res .= "(". join( ",", map { $dbh->quote_identifier( $_ ) } sort keys %$values ) .")";
     $res .= " VALUES";

-----------------------------------------------------------------------