[Rt-commit] rt branch, 4.4/external-auth-update-user-cfs, updated. rt-4.4.3-199-g98e1d0025

? sunnavy sunnavy at bestpractical.com
Thu Jan 31 19:07:35 EST 2019


The branch, 4.4/external-auth-update-user-cfs has been updated
       via  98e1d002543c3ba100a31a48013b3c3043cfd27d (commit)
      from  fe90199feac05ae8b34f6de84eb5a2277ebb48d4 (commit)

Summary of changes:
 lib/RT/Test.pm | 1 +
 1 file changed, 1 insertion(+)

- Log -----------------------------------------------------------------
commit 98e1d002543c3ba100a31a48013b3c3043cfd27d
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Feb 1 07:42:21 2019 +0800

    Dump parsed source code instead of "DUMMY" for sub references in tests
    
    In tests, we sync config updates from RT->Config->Set to
    RT_SiteConfig.pm via Data::Dumper so external web server can have
    up-to-date configs.  Data::Dumper doesn't parse code reference by
    default(for performance), we need to enable the "Deparse" option to let
    it parse code references and dump source code instead of "DUMMY"
    placeholders.
    
    This commit fixes failed external auth tests under fastcgi where
    "UserCF.Employee ID" is mapped to a sub reference.

diff --git a/lib/RT/Test.pm b/lib/RT/Test.pm
index a214ae731..db2f25dc0 100644
--- a/lib/RT/Test.pm
+++ b/lib/RT/Test.pm
@@ -434,6 +434,7 @@ sub set_config_wrapper {
         # Format the new value for output
         require Data::Dumper;
         local $Data::Dumper::Terse = 1;
+        local $Data::Dumper::Deparse = 1;
         my $dump = Data::Dumper::Dumper([@_[2 .. $#_]]);
         $dump =~ s/;?\s+\Z//;
         push @lines, "Set( ${sigil}${name}, \@{". $dump ."});\n";

-----------------------------------------------------------------------


More information about the rt-commit mailing list