[Rt-commit] rt branch, 4.4-trunk, updated. rt-4.4.4-6-g6805c82f4

[? sunnavy]

The branch, 4.4-trunk has been updated
       via  6805c82f4dad7ebbed47c426128dd35f387c5a11 (commit)
      from  2ae073d2f75f446810b9f2a0ceec154e0e2c1c93 (commit)

Summary of changes:
 lib/RT/Tickets.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 6805c82f4dad7ebbed47c426128dd35f387c5a11
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Mar 30 02:25:21 2019 +0800

    Fix uninitialized warning in ticket searches with __active__ and __inactive__ items
    
    %RT::Lifecycle::LIFECYCLES_CACHE contains a special key "__maps__",
    which is not a lifecycle(and the value doesn't have "type"), so we need
    to exclude it.

diff --git a/lib/RT/Tickets.pm b/lib/RT/Tickets.pm
index 5dcd50f07..e094c63ef 100644
--- a/lib/RT/Tickets.pm
+++ b/lib/RT/Tickets.pm
@@ -3059,7 +3059,7 @@ sub _parser {
                     my %lifecycle =
                       map { $_ => $RT::Lifecycle::LIFECYCLES{ $_ }{ inactive } }
                       grep { @{ $RT::Lifecycle::LIFECYCLES{ $_ }{ inactive } || [] } }
-                      grep { $RT::Lifecycle::LIFECYCLES_CACHE{ $_ }{ type } eq 'ticket' }
+                      grep { $_ ne '__maps__' && $RT::Lifecycle::LIFECYCLES_CACHE{ $_ }{ type } eq 'ticket' }
                       keys %RT::Lifecycle::LIFECYCLES;
                     return unless %lifecycle;
 
@@ -3101,7 +3101,7 @@ sub _parser {
                              @{ $RT::Lifecycle::LIFECYCLES{ $_ }{ initial } || [] }
                           || @{ $RT::Lifecycle::LIFECYCLES{ $_ }{ active }  || [] }
                       }
-                      grep { $RT::Lifecycle::LIFECYCLES_CACHE{ $_ }{ type } eq 'ticket' }
+                      grep { $_ ne '__maps__' && $RT::Lifecycle::LIFECYCLES_CACHE{ $_ }{ type } eq 'ticket' }
                       keys %RT::Lifecycle::LIFECYCLES;
                     return unless %lifecycle;
 

-----------------------------------------------------------------------