[Rt-commit] rt branch, 4.6-theme/ticket-pages, repushed
Craig Kaiser
craig at bestpractical.com
Mon May 20 16:42:37 EDT 2019
The branch 4.6-theme/ticket-pages was deleted and repushed:
was d418a2924b7e9b170aa17937f3bd7b340ce1f8e8
now dc701a7c280d8b8d9b2a6a20fee817cc5535df2e
1: 7f13f0055 = 1: 7f13f0055 Allow for multiple base themes by avoiding showing any to the user
2: 0ce97154b = 2: 0ce97154b Add unaltered copies of base and rudder themes to make responsive
3: 565e91062 = 3: 565e91062 rudder-responsive imports base-responsive rather than base
4: c151cf258 = 4: c151cf258 Make boxcontainer padding rules less demanding
5: 45e22b27c = 5: 45e22b27c Make RT at a glance two-column layout responsive
6: 66a41a296 = 6: 66a41a296 Improve whitespace around content for rudder-responsive
7: f0df65c03 = 7: f0df65c03 Generalize the two-column layout markup
8: 4a2814fdb = 8: 4a2814fdb Add a grid system
9: b7008bcd8 = 9: b7008bcd8 Make ticket display ShowSummary responsive
10: 2a14260d4 = 10: 2a14260d4 Make search field really narrow on narrow screens
11: 050d2b466 = 11: 050d2b466 Make the "new ticket in" and queue selector responsive
12: 7293efce0 = 12: 7293efce0 Narrow gap between new ticket and search fields on narrow screens
13: 26d3640d3 = 13: 26d3640d3 Display more of the title when the page is narrow
14: 743fca5fe = 14: 743fca5fe On narrow screens pop up a modal for selecting ticket queue
15: fc435d351 = 15: fc435d351 Hide "RT for example.com" on narrow screens
16: c12f7a2fd = 16: c12f7a2fd Eliminate history display's margin-left on narrow screens
17: 031767c67 = 17: 031767c67 On very narrow screens, zero out body padding
18: a70a12eb8 = 18: a70a12eb8 Get rid of horizontal padding on ticket history on narrow screens
19: ed77add0f = 19: ed77add0f Collapse padding at a wider (700px) viewport
20: bf6072713 = 20: bf6072713 Prevent reminders from breaking layout with its long text field
21: 3bf0b2783 = 21: 3bf0b2783 Convert Links table to have .fields/.field using table CSS
22: ef390831d = 22: ef390831d Improve styling of links for small screens
23: 9e0e238dc = 23: 9e0e238dc Don't wrap labels
24: abde98f8c = 24: abde98f8c Limit the breakdown of fields tables to just "wide" ones
25: a036b7218 = 25: a036b7218 Convert basics, dates, and people groupings away from tables
26: 18410558f = 26: 18410558f Add margin-left to <li>s within a wide fields table that breaks
27: abe679392 = 27: abe679392 Make padding on field names more consistent
28: 4535278a7 = 28: 4535278a7 Convert new reminder form from table to fields
29: 902013336 = 29: 902013336 Improve rendering of ticket update page
30: b83145a17 = 30: b83145a17 Add messagedetails to jumbo page titlebox
31: b30e4e3be = 31: b30e4e3be Improve display of reminders table and form
32: a3debdb88 = 32: a3debdb88 Avoid breaking layout with new reminder subject
33: a4ec31340 = 33: a4ec31340 Remove minimum height from titleboxes
34: 9e2e9f847 = 34: 9e2e9f847 Restore original titlebox padding rule but only for fields
35: f048c2714 = 35: f048c2714 Remove spurious <br> tag
36: 14bd5afdb = 36: 14bd5afdb Switch ticket update from tables to fields
37: b6076f108 = 37: b6076f108 Linearize ticket update form on narrow widths
38: 9847f9464 = 38: 9847f9464 Make update form take up 100% of the titlebox
39: 3f12ac4ab = 39: 3f12ac4ab Fix reply cc/bcc/subject fields to be 100% width
40: 7d903afc9 = 40: 7d903afc9 Rename .crypto to .empty to better explain what it's for
41: 0b1e7df31 = 41: 0b1e7df31 Make ticket create responsive
42: 21b722a26 = 42: 21b722a26 First pass at responsive for SelfService/Create
43: a5c7652c3 = 43: a5c7652c3 First pass at responsive for SelfService/Update
44: 8b58c4a15 = 44: 8b58c4a15 Remove AsTable from Edit CFs
45: 921d72c94 = 45: 921d72c94 Remove these pre-responsive CF edit styles
46: f5bcb7577 = 46: f5bcb7577 Wrap selfservice update form in a titlebox
47: 94e44ea62 = 47: 94e44ea62 Wrap selfservice create form in a titlebox
48: efe3f52d3 = 48: efe3f52d3 Convert selfservice display to responsive
49: fc80f17b7 = 49: fc80f17b7 Switch ShowCustomFields from table to fields
50: d26da2aa1 = 50: d26da2aa1 Fix transaction actions overlapping description
51: 726ff3ed2 = 51: 726ff3ed2 Switch QuickCreate from table to fields
52: 1dac409ae = 52: 1dac409ae Improve whitespace around fields
53: f99594d6b = 53: f99594d6b Improve padding and spacing on forms
54: 9b94580d3 = 54: 9b94580d3 Have searches use the full width of the viewport
55: df8c440d3 = 55: df8c440d3 Make login box more responsive
56: 6c19bf649 = 56: 6c19bf649 Add missing type="text" for login username input
57: ff38918b6 = 57: ff38918b6 Improve form rendering for Mobile Safari
58: bc548a5bb = 58: bc548a5bb Separate existing reminders from create form with hr only if there are reminders
59: 3d16535fd = 59: 3d16535fd Remove unnecessary margin-top on collection tables
60: a6e560500 = 60: a6e560500 Fix save button on ticket reminders to not use inline style
61: 33e559e98 = 61: 33e559e98 Fix error result background color for rudder
62: 6366d835d = 62: 6366d835d Make QueueList take up the full width
63: 753b2e278 = 63: 753b2e278 Give rudder the responsive viewport meta tag
64: 96258f3a2 = 64: 96258f3a2 Turn off autocapitalize on usernames
65: b738946b7 = 65: b738946b7 Don't let users select the "drop files here" dropzone text
66: ed9896623 = 66: ed9896623 Improve error transaction colors
67: fc2c7dd24 = 67: fc2c7dd24 Replace ShowAttachments's <font size="-2"> with CSS
68: 0ed134c2a = 68: 0ed134c2a Word-break very (perhaps maliciously) long attachment names
69: 329257c04 = 69: 329257c04 Limit the width of quickcreate since it looks silly when very very wide
70: 7e8fc73fa = 70: 7e8fc73fa Use full width for MyReminders table
71: 5acf57a6e = 71: 5acf57a6e Fix Modify Basics to be div.fields rather than table
72: 13b9aa7be = 72: 13b9aa7be Add missing type="text" to more input fields
73: 37a3c8190 = 73: 37a3c8190 Avoid menulist-button styling for multi-row select boxes
74: 76ebbf037 = 74: 76ebbf037 Middle valign fields
75: abd46fe43 = 75: abd46fe43 Convert EditPeople from nested tables to responsive
76: 6b1ed3291 = 76: 6b1ed3291 Load the correct version of msie.css
77: 55f62d910 = 77: 55f62d910 Add a BeforeNav stylesheet plugin
78: 713ae954b = 78: 713ae954b Make menus overflow into a "More" item on narrow viewports
79: 0817597f0 = 79: 0817597f0 Remove hyperlink behavior from top-level More menu items
80: 51ff61b95 = 80: 51ff61b95 Add type attribute to many input fields that were missing it
81: 9920a2bae = 81: 9920a2bae Fix css rule for one-time cc etc becoming email fields
82: 639ec0a0a = 82: 639ec0a0a Switch new ticket create popup to a list of links rather than a select
83: 263260d84 = 83: 263260d84 Fix a regression on legacy themes with CF edit panels
84: e7a24762e = 84: e7a24762e Override 400px width of jquery modals
85: d05db9319 = 85: d05db9319 Fix quick create on narrow screens
86: 1ce3e7535 = 86: 1ce3e7535 Fix width regression with quickcreate requestor field
87: 0bdd6b928 = 87: 0bdd6b928 Switch AddLinks from tables to fields
88: de71b019f = 88: de71b019f Improve rendering of date editing form
89: 7e88d621b = 89: 7e88d621b Improve padding to be more consistent
90: 15dd4d5e1 = 90: 15dd4d5e1 Make modify links use fluid two-column layout
91: 4bb74ee24 = 91: 4bb74ee24 Improve edit links to use fields instead of a table
92: 71adf4d59 = 92: 71adf4d59 Convert merge from table to fields
93: 8bed2a517 = 93: 8bed2a517 Use the same nomenclature "Message" not "Content" for jumbo
94: 821af7169 = 94: 821af7169 Switch Jumbo reply panel from table to fields
95: 451b94ebf = 95: 451b94ebf Jumbo: Wrap both basic fields and custom fields in a single fields table
96: 8e0edb097 = 96: 8e0edb097 Make message form on Jumbo more consistent
97: 3410d1f86 = 97: 3410d1f86 Make simple search form more responsive
98: ac878afd0 = 98: ac878afd0 Fix rudder-responsive getting bottom border radius
99: ee6fd153c = 99: ee6fd153c Remove margin-right from titleboxes in rudder-responsive
100: 19e92fb58 = 100: 19e92fb58 Improve design of more about requestors panel
101: 0795549da = 101: 0795549da Make user prefs page responsive to small screens
102: 3142b6f1e = 102: 3142b6f1e Remove 20em width from ticket subject on basics
103: d2c34c901 = 103: d2c34c901 Wrap forward message in a titlebox
104: e93736f6e = 104: e93736f6e Switch forward from table to fields
105: 865306bb5 = 105: 865306bb5 Fix "more about requestors" overlap
106: a91ad6b41 = 106: a91ad6b41 Update tests for the responsive HTML change
107: 309321394 = 107: 309321394 Fix Nav tweaking for installer mode
108: 5d80cac56 = 108: 5d80cac56 Initial elevator theme, copied from rudder-responsive
109: 9e2710667 = 109: 9e2710667 Add popper.js 1.14.6 dependency
110: d5361e4f8 = 110: d5361e4f8 Add bootstrap 4.2.1 dependency
111: ce6db31de = 111: ce6db31de Add missing "field" css class for Started field
112: 18b4c17ed = 112: 18b4c17ed Get rid of strikethrough in menu
113: 2c1913cea = 113: 2c1913cea Fix h1 position to make it vertically centered
114: 16a290165 = 114: 16a290165 Fix results position to make it vertically centered
115: fa1eddb07 = 115: fa1eddb07 Drop the incomplete rudder-responsive theme
116: 30c74df65 = 116: 30c74df65 Update copyright to 2019 for new added theme related files
117: 8202a7ed6 = 117: 8202a7ed6 Initial elevator-dark theme
118: 6e8c418d2 = 118: 6e8c418d2 Add bootstrap-select 1.13.7 dependency
119: 65a2b8e72 = 119: 65a2b8e72 Switch to bootstrap styled table
120: d3c438a8c = 120: d3c438a8c Switch to bootstrap card for titleboxes
121: 19983ce0c = 121: 19983ce0c Add %ThemeJSFiles config to serve different js for different themes
122: c20ba1ee1 = 122: c20ba1ee1 Migrate search builder for elevator themes
123: c381b52d6 = 123: c381b52d6 Migrate homepage to elevator themes
124: 2b95d7c55 = 124: 2b95d7c55 Add bootstrap-combobox 1.2.0 dependency
125: 16785047a = 125: 16785047a Migrate cf edit components to elevator themes
126: 3434d9955 = 126: 3434d9955 Migrate ticket modify pages to elevator themes
127: 3287cf808 = 127: 3287cf808 Migrate Reports pages to elevator themes
128: 5cca4857d = 128: 5cca4857d Migrate Admin/Scrips/index to elevator themes
129: d38e146cd = 129: d38e146cd Migrate Admin/Scrips/Create to elevator themes
130: ef2c1e2f4 = 130: ef2c1e2f4 Migrate Admin/Scrips/Modify to elevator themes
131: 71c8971a2 = 131: 71c8971a2 Migrate Admin/Scrips/Objects to elevator themes
132: b487bd5e5 = 132: b487bd5e5 Migrate Admin/Actions/Display to elevator themes
133: f1112cfd9 = 133: f1112cfd9 Update asset CSS and JS files for elevator theme
134: 96287645d = 134: 96287645d Update asset display components for elevator theme
135: 9317af1b2 = 135: 9317af1b2 Update asset create/modify components for elevator theme
136: edb9d71e1 = 136: edb9d71e1 Update asset search components for elevator theme
137: 1983b0460 = 137: 1983b0460 Migrate Admin/Actions/Create to elevator themes
138: 93ba4a292 = 138: 93ba4a292 Migrate Admin/Actions/Modify to elevator themes
139: be2c9fbaa = 139: be2c9fbaa Migrate Admin/Conditions/Create to elevator themes
140: 440891534 = 140: 440891534 Migrate Admin/Conditions/Modify to elevator themes
141: c9d4607cb = 141: c9d4607cb Migrate Admin/Conditions/Display to elevator themes
142: d418a2924 ! 142: dc701a7c2 Migrate ticket pages to elevator theme
@@ -23,7 +23,7 @@
% my @addresses = $action->$type();
% next unless @addresses;
- <ul>
-+ <ul class="list-group-compact">
++ <ul class="list-group list-group-compact">
% for my $addr (@addresses) {
- <li>
+ <li class="list-group-item">
@@ -96,7 +96,7 @@
-<tr>
-<td valign="top"><% $type %>:</td>
-<td valign="top">
-+<ul class="list-group-compact">
++<ul class="list-group list-group-compact">
+ <li class="list-group-item">
+ <div class="form-row">
+ <div class="col-md-auto">
@@ -266,18 +266,7 @@
-<td class="entry" colspan="3">
-<input type="text" class="reminder-subject" name="Reminder-Subject-<% $Reminder->id %>" value="<% $Reminder->Subject %>"
+ <div class="custom-control custom-checkbox">
-+ <input class="custom-control-input" type="checkbox" value="1" name="Complete-Reminder-<% $Reminder->id %>" <% $Reminder->Status eq $Reminder->LifecycleObj->ReminderStatusOnResolve ? 'checked="checked"' : '' |n %>
-+% unless ( $Reminder->CurrentUserHasRight('ModifyTicket') ) {
-+disabled="disabled"
-+% }
-+ />
-+ </div>
-+ <div class="form-row">
-+ <div class="label col-md-3">
-+ <&|/l&>Subject</&>:
-+ </div>
-+ <div class="value col-md-9">
-+ <input type="text" class="reminder-subject form-control" name="Reminder-Subject-<% $Reminder->id %>" value="<% $Reminder->Subject %>"
++ <input class="custom-control-input" type="checkbox" value="1" id="Complete-Reminder-<% $Reminder->id %>" name="Complete-Reminder-<% $Reminder->id %>" <% $Reminder->Status eq $Reminder->LifecycleObj->ReminderStatusOnResolve ? 'checked="checked"' : '' |n %>
% unless ( $Reminder->CurrentUserHasRight('ModifyTicket') ) {
-readonly="readonly"
-% }
@@ -290,6 +279,18 @@
-<td class="entry"><& /Elements/SelectOwner, Name => 'Reminder-Owner-'.$Reminder->id, QueueObj => $Ticket->QueueObj, Default => $Reminder->Owner, DefaultValue => 0 &></td>
-<td class="label"><&|/l&>Due</&>:</td>
-<td class="entry">
++disabled="disabled"
++% }
++ />
++ <label class="custom-control-label" for="Complete-Reminder-<% $Reminder->id %>"></label>
++ </div>
++ <div class="form-row">
++ <div class="label col-md-3">
++ <&|/l&>Subject</&>:
++ </div>
++ <div class="value col-md-9">
++ <input type="text" class="reminder-subject form-control" name="Reminder-Subject-<% $Reminder->id %>" value="<% $Reminder->Subject %>"
++% unless ( $Reminder->CurrentUserHasRight('ModifyTicket') ) {
+readonly="readonly"
+% }
+ />
@@ -371,7 +372,6 @@
+ <& /Elements/ShowUser, User => $Reminder->OwnerObj &>
+ </div>
+ </div>
-+</div>
</%method>
diff --git a/share/html/Ticket/Elements/ShowAssets b/share/html/Ticket/Elements/ShowAssets
@@ -395,7 +395,7 @@
<span class="filename"><%$key%></span>
-<ul <% $Selectable ? 'class="selectable"' : '' |n %> >
-+<ul class="list-group-compact" <% $Selectable ? 'class="selectable"' : '' |n %> >
++<ul class="list-group list-group-compact" <% $Selectable ? 'class="selectable"' : '' |n %> >
% foreach my $rev (@{$documents{$key}}) {
% if ($rev->ContentLength) {
-<li>
@@ -442,41 +442,14 @@
- <td class="value"><% $user %>:</td>
- <td class="value"><& /Ticket/Elements/ShowTime, minutes => $time_worked->{$user} &></td>
- </tr>
-+ <div class="form-row">
-+ <div class="value"><% $user %>:</div>
-+ <div class="value"><& /Ticket/Elements/ShowTime, minutes => $time_worked->{$user} &></div>
-+ </div>
++ <div class="value"><% $user %>:</div>
++ <div class="value"><& /Ticket/Elements/ShowTime, minutes => $time_worked->{$user} &></div>
% }
- </table>
+ </div>
</span>
</div>
% }
-
-diff --git a/share/html/Ticket/Elements/ShowUpdateStatus b/share/html/Ticket/Elements/ShowUpdateStatus
---- a/share/html/Ticket/Elements/ShowUpdateStatus
-+++ b/share/html/Ticket/Elements/ShowUpdateStatus
-@@
- %#
- %# END BPS TAGGED BLOCK }}}
- <div class="unread-messages">
--<&| /Widgets/TitleBox, title => loc('New messages'), title_href => "#txn-". $txn->id &>
--<&|/l&>There are unread messages on this ticket.</&>
--<&|/l,
-- RT->Config->Get('WebPath') ."/$DisplayPath/Display.html?id=". $Ticket->id. "#txn-".$txn->id,
-- RT->Config->Get('WebPath') ."/$DisplayPath/Display.html?id=". $Ticket->id ."&MarkAsSeen=1&Anchor=txn-" . $txn->id
-- &>You can <a href="[_1]">jump to the first unread message</a> or <a href="[_2]">jump to the first unread message and mark all messages as seen</a>.</&>
--</&>
-+ <&| /Widgets/TitleBox, title => loc('New messages'), title_href => "#txn-". $txn->id &>
-+ <&|/l&>There are unread messages on this ticket.</&>
-+ <&|/l,
-+ RT->Config->Get('WebPath') ."/$DisplayPath/Display.html?id=". $Ticket->id. "#txn-".$txn->id,
-+ RT->Config->Get('WebPath') ."/$DisplayPath/Display.html?id=". $Ticket->id ."&MarkAsSeen=1&Anchor=txn-" . $txn->id
-+ &>You can <a href="[_1]">jump to the first unread message</a> or <a href="[_2]">jump to the first unread message and mark all messages as seen</a>.</&>
-+ </&>
- </div>
- <%ARGS>
- $Ticket
diff --git a/share/html/Ticket/Forward.html b/share/html/Ticket/Forward.html
--- a/share/html/Ticket/Forward.html
@@ -522,7 +495,7 @@
+ <div class="col-md-3 label">
+ <% loc('Main type of links') %>
+ </div>
-+ <div class="col-md-9">
++ <div class="col-md-9 value">
+ <select class="form-control selectpicker" name="LeadingLink">
% foreach ( @link_types ) {
-<option value="<% $_ %>" <% ($LeadingLink||'Members') eq $_? 'selected="selected"': '' |n %>><% loc($_) %></option>
@@ -539,7 +512,7 @@
+ <div class="col-md-3 label">
+ <% loc('maximum depth') %>
+ </div>
-+ <div class="col-md-9">
++ <div class="col-md-9 value">
+ <select class="form-control selectpicker" name="MaxDepth">
+ <option value="0"><% loc('Unlimit') %></option>
% foreach ( 1..6 ) {
@@ -556,7 +529,7 @@
+ <div class="col-md-3 label">
+ <% loc('Show as well') %>:
+ </div>
-+ <div class="col-md-9">
++ <div class="col-md-9 value">
+ <div class="form-row">
% foreach my $type ( @link_types ) {
% my $checked = '';
@@ -565,8 +538,8 @@
-<label for="ShowLinks"><% loc($type) %></label>
+ <div class="col-md-auto">
+ <div class="custom-control custom-checkbox">
-+ <input class="custom-control-input" type="checkbox" id="ShowLinks" name="ShowLinks" value="<% $type %>" <% $checked |n %> />
-+ <label class="custom-control-label" for="ShowLinks"><% loc($type) %></label>
++ <input class="custom-control-input" type="checkbox" id="ShowLinks-<%$type%>" name="ShowLinks" value="<% $type %>" <% $checked |n %> />
++ <label class="custom-control-label" for="ShowLinks-<%$type%>"><% loc($type) %></label>
+ </div>
+ </div>
% }
@@ -584,7 +557,7 @@
+ <div class="col-md-3 label">
+ <% loc('Fill boxes with color using') %>:
+ </div>
-+ <div class="col-md-9">
++ <div class="col-md-9 value">
+ <select name="FillUsing" class="form-control selectpicker">
+ <option value=""><% loc('nothing') %></option>
<%PERL>
@@ -609,10 +582,10 @@
-<input type="checkbox" id="ShowLinkDescriptions" name="ShowLinkDescriptions" value="1" <% $checked |n %> />
-<br />
+ <div class="form-row">
-+ <div class="col-md-3 label">
++ <div class="col-md-3 value">
+ <div class="custom-control custom-checkbox">
++ <input class="custom-control-label" type="checkbox" id="ShowLinkDescriptions" name="ShowLinkDescriptions" value="1" <% $checked |n %> />
+ <label class="custom-control-input" for="ShowLinkDescriptions"><% loc('Show link descriptions') %>:</label>
-+ <input class="custom-control-label" type="checkbox" id="ShowLinkDescriptions" name="ShowLinkDescriptions" value="1" <% $checked |n %> />
+ </div>
+ </div>
+ </div>
@@ -651,7 +624,7 @@
+ <div class="col-md-3 label">
+ <% loc($group) %>:
+ </div>
-+ <div class="col-md-9">
++ <div class="col-md-9 value">
+ <div class="form-row">
% foreach my $prop ( @$list ) {
% my $checked = '';
@@ -660,8 +633,8 @@
-<label for="Level-<% $Level %>-Properties"><% loc($prop) %></label>
+ <div class="col-md-auto">
+ <div class="custom-control custom-checkbox">
-+ <input type="checkbox" class="custom-control-input" id="Level-<% $prop %>-Properties" name="Level-<% $Level %>-Properties" value="<% $prop %>" <% $checked |n %> />
-+ <label class="custom-control-label" for="Level-<% $prop %>-Properties"><% loc($prop) %></label>
++ <input type="checkbox" class="custom-control-input" id="Level-<% $Level . '-'. $prop %>-Properties" name="Level-<% $Level %>-Properties" value="<% $prop %>" <% $checked |n %> />
++ <label class="custom-control-label" for="Level-<% $Level . '-'. $prop %>-Properties"><% loc($prop) %></label>
+ </div>
+ </div>
% }
@@ -687,8 +660,6 @@
-<tr style="height: 2.8em;"><td><% loc('Status') %>:</td><td>
+ <div class="form-row">
+ <% loc('Status') %>:
-+ </div>
-+ <div class="form-row">
% foreach my $status ( sort keys %RT::Graph::Tickets::ticket_status_style ) {
% my $style = $RT::Graph::Tickets::ticket_status_style{ $status };
-<span style="color: <% $style->{'fontcolor'} %>; padding: 0.6em; border: 1px solid black;"><% loc($status) %></span>
@@ -701,8 +672,6 @@
-<tr style="height: 2.8em;"><td><% loc($FillUsing) %>:</td><td>
+ <div class="form-row">
+ <% loc($FillUsing) %>:
-+ </div>
-+ <div class="form-row">
% foreach my $value ( sort keys %RT::Graph::Tickets::fill_cache ) {
% my $color = $RT::Graph::Tickets::fill_cache{ $value };
-<span style="background-color: <% $color %>; padding: 0.6em; border: 1px solid black;"><% loc($value) %></span>
@@ -725,7 +694,7 @@
<div class="field input-row">
<span class="label"><&|/l&>Subject</&>:</span>
- <span class="value entry"><input type="text" name="UpdateSubject" value="<%$Ticket->Subject%>" class="form-control" />
-+ <span class="value entry"><input class="form-control" type="text" name="UpdateSubject" value="<%$Ticket->Subject%>" class="form-control" />
++ <span class="value entry"><input class="form-control" type="text" name="UpdateSubject" value="<%$Ticket->Subject%>" />
% $m->callback( %ARGS, CallbackName => 'AfterSubject' );
</span>
</div>
@@ -818,44 +787,3 @@
$m->content_unlike(qr{baby's first reminder}, "we don't display resolved reminders");
$m->follow_link_ok({id => 'page-reminders'});
-
-diff --git a/t/web/ticket_timeworked.t b/t/web/ticket_timeworked.t
---- a/t/web/ticket_timeworked.t
-+++ b/t/web/ticket_timeworked.t
-@@
- "found expected total TimeWorked in parent ticket"
- );
- $m->content_like(
-- qr{(?s)user_a:.+?value">1\.33 hours \(80 minutes\)},
-+ qr{(?s)user_a:.+1\.33 hours \(80 minutes\)},
- "found expected user_a TimeWorked in parent ticket"
- );
- $m->content_like(
-- qr{(?s)user_b:.+?value">1\.5 hours \(90 minutes\)},
-+ qr{(?s)user_b:.+1\.5 hours \(90 minutes\)},
- "found expected user_b TimeWorked in parent ticket"
- );
- }
-@@
- "found expected total TimeWorked in child ticket 1"
- );
- $m->content_like(
-- qr{(?s)user_a:.+?value">45 minutes},
-+ qr{(?s)user_a:.+45 minutes},
- "found expected user_a TimeWorked in child ticket 1"
- );
- }
-@@
- "found expected total TimeWorked in child ticket 2"
- );
- $m->content_like(
-- qr{(?s)user_a:.+?value">35 minutes},
-+ qr{(?s)user_a:.+35 minutes},
- "found expected user_a TimeWorked in child ticket 2"
- );
- $m->content_like(
-- qr{(?s)user_b:.+?value">1\.5 hours \(90 minutes\)},
-+ qr{(?s)user_b:.+1\.5 hours \(90 minutes\)},
- "found expected user_b TimeWorked in child ticket 2"
- );
- }
More information about the rt-commit
mailing list