[Rt-commit] rt branch, 4.6-theme/prefs-pages, repushed
Craig Kaiser
craig at bestpractical.com
Tue May 21 09:21:08 EDT 2019
The branch 4.6-theme/prefs-pages was deleted and repushed:
was bf84f9ca3affa7b3b0bb678016c899e1d90fd2ac
now 328c856dd643ad13575eda35b5520bb9d2f8454f
1: 7f13f0055 = 1: 7f13f0055 Allow for multiple base themes by avoiding showing any to the user
2: 0ce97154b = 2: 0ce97154b Add unaltered copies of base and rudder themes to make responsive
3: 565e91062 = 3: 565e91062 rudder-responsive imports base-responsive rather than base
4: c151cf258 = 4: c151cf258 Make boxcontainer padding rules less demanding
5: 45e22b27c = 5: 45e22b27c Make RT at a glance two-column layout responsive
6: 66a41a296 = 6: 66a41a296 Improve whitespace around content for rudder-responsive
7: f0df65c03 = 7: f0df65c03 Generalize the two-column layout markup
8: 4a2814fdb = 8: 4a2814fdb Add a grid system
9: b7008bcd8 = 9: b7008bcd8 Make ticket display ShowSummary responsive
10: 2a14260d4 = 10: 2a14260d4 Make search field really narrow on narrow screens
11: 050d2b466 = 11: 050d2b466 Make the "new ticket in" and queue selector responsive
12: 7293efce0 = 12: 7293efce0 Narrow gap between new ticket and search fields on narrow screens
13: 26d3640d3 = 13: 26d3640d3 Display more of the title when the page is narrow
14: 743fca5fe = 14: 743fca5fe On narrow screens pop up a modal for selecting ticket queue
15: fc435d351 = 15: fc435d351 Hide "RT for example.com" on narrow screens
16: c12f7a2fd = 16: c12f7a2fd Eliminate history display's margin-left on narrow screens
17: 031767c67 = 17: 031767c67 On very narrow screens, zero out body padding
18: a70a12eb8 = 18: a70a12eb8 Get rid of horizontal padding on ticket history on narrow screens
19: ed77add0f = 19: ed77add0f Collapse padding at a wider (700px) viewport
20: bf6072713 = 20: bf6072713 Prevent reminders from breaking layout with its long text field
21: 3bf0b2783 = 21: 3bf0b2783 Convert Links table to have .fields/.field using table CSS
22: ef390831d = 22: ef390831d Improve styling of links for small screens
23: 9e0e238dc = 23: 9e0e238dc Don't wrap labels
24: abde98f8c = 24: abde98f8c Limit the breakdown of fields tables to just "wide" ones
25: a036b7218 = 25: a036b7218 Convert basics, dates, and people groupings away from tables
26: 18410558f = 26: 18410558f Add margin-left to <li>s within a wide fields table that breaks
27: abe679392 = 27: abe679392 Make padding on field names more consistent
28: 4535278a7 = 28: 4535278a7 Convert new reminder form from table to fields
29: 902013336 = 29: 902013336 Improve rendering of ticket update page
30: b83145a17 = 30: b83145a17 Add messagedetails to jumbo page titlebox
31: b30e4e3be = 31: b30e4e3be Improve display of reminders table and form
32: a3debdb88 = 32: a3debdb88 Avoid breaking layout with new reminder subject
33: a4ec31340 = 33: a4ec31340 Remove minimum height from titleboxes
34: 9e2e9f847 = 34: 9e2e9f847 Restore original titlebox padding rule but only for fields
35: f048c2714 = 35: f048c2714 Remove spurious <br> tag
36: 14bd5afdb = 36: 14bd5afdb Switch ticket update from tables to fields
37: b6076f108 = 37: b6076f108 Linearize ticket update form on narrow widths
38: 9847f9464 = 38: 9847f9464 Make update form take up 100% of the titlebox
39: 3f12ac4ab = 39: 3f12ac4ab Fix reply cc/bcc/subject fields to be 100% width
40: 7d903afc9 = 40: 7d903afc9 Rename .crypto to .empty to better explain what it's for
41: 0b1e7df31 = 41: 0b1e7df31 Make ticket create responsive
42: 21b722a26 = 42: 21b722a26 First pass at responsive for SelfService/Create
43: a5c7652c3 = 43: a5c7652c3 First pass at responsive for SelfService/Update
44: 8b58c4a15 = 44: 8b58c4a15 Remove AsTable from Edit CFs
45: 921d72c94 = 45: 921d72c94 Remove these pre-responsive CF edit styles
46: f5bcb7577 = 46: f5bcb7577 Wrap selfservice update form in a titlebox
47: 94e44ea62 = 47: 94e44ea62 Wrap selfservice create form in a titlebox
48: efe3f52d3 = 48: efe3f52d3 Convert selfservice display to responsive
49: fc80f17b7 = 49: fc80f17b7 Switch ShowCustomFields from table to fields
50: d26da2aa1 = 50: d26da2aa1 Fix transaction actions overlapping description
51: 726ff3ed2 = 51: 726ff3ed2 Switch QuickCreate from table to fields
52: 1dac409ae = 52: 1dac409ae Improve whitespace around fields
53: f99594d6b = 53: f99594d6b Improve padding and spacing on forms
54: 9b94580d3 = 54: 9b94580d3 Have searches use the full width of the viewport
55: df8c440d3 = 55: df8c440d3 Make login box more responsive
56: 6c19bf649 = 56: 6c19bf649 Add missing type="text" for login username input
57: ff38918b6 = 57: ff38918b6 Improve form rendering for Mobile Safari
58: bc548a5bb = 58: bc548a5bb Separate existing reminders from create form with hr only if there are reminders
59: 3d16535fd = 59: 3d16535fd Remove unnecessary margin-top on collection tables
60: a6e560500 = 60: a6e560500 Fix save button on ticket reminders to not use inline style
61: 33e559e98 = 61: 33e559e98 Fix error result background color for rudder
62: 6366d835d = 62: 6366d835d Make QueueList take up the full width
63: 753b2e278 = 63: 753b2e278 Give rudder the responsive viewport meta tag
64: 96258f3a2 = 64: 96258f3a2 Turn off autocapitalize on usernames
65: b738946b7 = 65: b738946b7 Don't let users select the "drop files here" dropzone text
66: ed9896623 = 66: ed9896623 Improve error transaction colors
67: fc2c7dd24 = 67: fc2c7dd24 Replace ShowAttachments's <font size="-2"> with CSS
68: 0ed134c2a = 68: 0ed134c2a Word-break very (perhaps maliciously) long attachment names
69: 329257c04 = 69: 329257c04 Limit the width of quickcreate since it looks silly when very very wide
70: 7e8fc73fa = 70: 7e8fc73fa Use full width for MyReminders table
71: 5acf57a6e = 71: 5acf57a6e Fix Modify Basics to be div.fields rather than table
72: 13b9aa7be = 72: 13b9aa7be Add missing type="text" to more input fields
73: 37a3c8190 = 73: 37a3c8190 Avoid menulist-button styling for multi-row select boxes
74: 76ebbf037 = 74: 76ebbf037 Middle valign fields
75: abd46fe43 = 75: abd46fe43 Convert EditPeople from nested tables to responsive
76: 6b1ed3291 = 76: 6b1ed3291 Load the correct version of msie.css
77: 55f62d910 = 77: 55f62d910 Add a BeforeNav stylesheet plugin
78: 713ae954b = 78: 713ae954b Make menus overflow into a "More" item on narrow viewports
79: 0817597f0 = 79: 0817597f0 Remove hyperlink behavior from top-level More menu items
80: 51ff61b95 = 80: 51ff61b95 Add type attribute to many input fields that were missing it
81: 9920a2bae = 81: 9920a2bae Fix css rule for one-time cc etc becoming email fields
82: 639ec0a0a = 82: 639ec0a0a Switch new ticket create popup to a list of links rather than a select
83: 263260d84 = 83: 263260d84 Fix a regression on legacy themes with CF edit panels
84: e7a24762e = 84: e7a24762e Override 400px width of jquery modals
85: d05db9319 = 85: d05db9319 Fix quick create on narrow screens
86: 1ce3e7535 = 86: 1ce3e7535 Fix width regression with quickcreate requestor field
87: 0bdd6b928 = 87: 0bdd6b928 Switch AddLinks from tables to fields
88: de71b019f = 88: de71b019f Improve rendering of date editing form
89: 7e88d621b = 89: 7e88d621b Improve padding to be more consistent
90: 15dd4d5e1 = 90: 15dd4d5e1 Make modify links use fluid two-column layout
91: 4bb74ee24 = 91: 4bb74ee24 Improve edit links to use fields instead of a table
92: 71adf4d59 = 92: 71adf4d59 Convert merge from table to fields
93: 8bed2a517 = 93: 8bed2a517 Use the same nomenclature "Message" not "Content" for jumbo
94: 821af7169 = 94: 821af7169 Switch Jumbo reply panel from table to fields
95: 451b94ebf = 95: 451b94ebf Jumbo: Wrap both basic fields and custom fields in a single fields table
96: 8e0edb097 = 96: 8e0edb097 Make message form on Jumbo more consistent
97: 3410d1f86 = 97: 3410d1f86 Make simple search form more responsive
98: ac878afd0 = 98: ac878afd0 Fix rudder-responsive getting bottom border radius
99: ee6fd153c = 99: ee6fd153c Remove margin-right from titleboxes in rudder-responsive
100: 19e92fb58 = 100: 19e92fb58 Improve design of more about requestors panel
101: 0795549da = 101: 0795549da Make user prefs page responsive to small screens
102: 3142b6f1e = 102: 3142b6f1e Remove 20em width from ticket subject on basics
103: d2c34c901 = 103: d2c34c901 Wrap forward message in a titlebox
104: e93736f6e = 104: e93736f6e Switch forward from table to fields
105: 865306bb5 = 105: 865306bb5 Fix "more about requestors" overlap
106: a91ad6b41 = 106: a91ad6b41 Update tests for the responsive HTML change
107: 309321394 = 107: 309321394 Fix Nav tweaking for installer mode
108: 5d80cac56 = 108: 5d80cac56 Initial elevator theme, copied from rudder-responsive
109: 9e2710667 = 109: 9e2710667 Add popper.js 1.14.6 dependency
110: d5361e4f8 = 110: d5361e4f8 Add bootstrap 4.2.1 dependency
111: ce6db31de = 111: ce6db31de Add missing "field" css class for Started field
112: 18b4c17ed = 112: 18b4c17ed Get rid of strikethrough in menu
113: 2c1913cea = 113: 2c1913cea Fix h1 position to make it vertically centered
114: 16a290165 = 114: 16a290165 Fix results position to make it vertically centered
115: fa1eddb07 = 115: fa1eddb07 Drop the incomplete rudder-responsive theme
116: 30c74df65 = 116: 30c74df65 Update copyright to 2019 for new added theme related files
117: 8202a7ed6 = 117: 8202a7ed6 Initial elevator-dark theme
118: 6e8c418d2 = 118: 6e8c418d2 Add bootstrap-select 1.13.7 dependency
119: 65a2b8e72 = 119: 65a2b8e72 Switch to bootstrap styled table
120: d3c438a8c = 120: d3c438a8c Switch to bootstrap card for titleboxes
121: 19983ce0c = 121: 19983ce0c Add %ThemeJSFiles config to serve different js for different themes
122: c20ba1ee1 = 122: c20ba1ee1 Migrate search builder for elevator themes
123: c381b52d6 = 123: c381b52d6 Migrate homepage to elevator themes
124: 2b95d7c55 = 124: 2b95d7c55 Add bootstrap-combobox 1.2.0 dependency
125: 16785047a = 125: 16785047a Migrate cf edit components to elevator themes
126: 3434d9955 = 126: 3434d9955 Migrate ticket modify pages to elevator themes
127: 3287cf808 = 127: 3287cf808 Migrate Reports pages to elevator themes
128: 5cca4857d = 128: 5cca4857d Migrate Admin/Scrips/index to elevator themes
129: d38e146cd = 129: d38e146cd Migrate Admin/Scrips/Create to elevator themes
130: ef2c1e2f4 = 130: ef2c1e2f4 Migrate Admin/Scrips/Modify to elevator themes
131: 71c8971a2 = 131: 71c8971a2 Migrate Admin/Scrips/Objects to elevator themes
132: b487bd5e5 = 132: b487bd5e5 Migrate Admin/Actions/Display to elevator themes
133: f1112cfd9 = 133: f1112cfd9 Update asset CSS and JS files for elevator theme
134: 96287645d = 134: 96287645d Update asset display components for elevator theme
135: 9317af1b2 = 135: 9317af1b2 Update asset create/modify components for elevator theme
136: edb9d71e1 = 136: edb9d71e1 Update asset search components for elevator theme
137: 1983b0460 = 137: 1983b0460 Migrate Admin/Actions/Create to elevator themes
138: 93ba4a292 = 138: 93ba4a292 Migrate Admin/Actions/Modify to elevator themes
139: be2c9fbaa = 139: be2c9fbaa Migrate Admin/Conditions/Create to elevator themes
140: 440891534 = 140: 440891534 Migrate Admin/Conditions/Modify to elevator themes
141: c9d4607cb = 141: c9d4607cb Migrate Admin/Conditions/Display to elevator themes
142: bf84f9ca3 ! 142: 328c856dd Migrate Prefs pages for elevator theme
@@ -79,7 +79,7 @@
-% }
+<div class="form-row">
+%### Left column ###
-+ <div class="col-md-7">
++ <div class="col-md-6">
+
+ <&| /Widgets/TitleBox, title => loc('Identity'), id => "user-prefs-identity" &>
+ <input type="hidden" class="hidden" name="Name" value="<%$UserObj->Name%>" />
@@ -128,7 +128,7 @@
+ </div>
+
+ <div class="form-row">
-+ <& /Elements/EditCustomFields, Object => $UserObj, Grouping => 'Identity', InTable => 1 &>
++ <& /Elements/EditCustomFields, Object => $UserObj, Grouping => 'Identity' &>
+ </div>
+ </&>
+
@@ -171,7 +171,7 @@
+
+ <div class="form-row">
+ <div class="label col-md-12">
-+ <& /Elements/EditCustomFields, Object => $UserObj, Grouping => 'Phones', InTable => 1 &>
++ <& /Elements/EditCustomFields, Object => $UserObj, Grouping => 'Phones' &>
+ </div>
+ </div>
+ </&>
@@ -185,7 +185,8 @@
+ </div>
+
+%### Right column ###
-+ <div class="col-md-5">
++ <div class="col-md-6
++ ">
+
+ <&| /Widgets/TitleBox, title => loc( $AccessControlName ), id => "user-prefs-access-control" &>
% if ( $UserObj->__Value('Password') ne '*NO-PASSWORD*' ) {
@@ -213,7 +214,7 @@
+ <div class="col-md-9 value">
%if ( $AdminUser ) {
- <td class="value"><input type="text" name="Organization" value="<%$UserObj->Organization || ''%>" /></td>
-+ <input class="form-row" type="text" name="Organization" value="<%$UserObj->Organization || ''%>" />
++ <input class="form-control" type="text" name="Organization" value="<%$UserObj->Organization || ''%>" />
%} else {
- <td class="value"><%$UserObj->Organization || ''%></td>
+ <%$UserObj->Organization || ''%>
@@ -289,7 +290,7 @@
+ <&|/l&>Zip</&>:
+ </div>
+ <div class="col-md-9 value">
-+ <input type="text" name="Zip" value="<%$UserObj->Zip || ''%>" size="9" />
++ <input class="form-control" type="text" name="Zip" value="<%$UserObj->Zip || ''%>" size="9" />
+ </div>
+ </div>
+
@@ -304,7 +305,7 @@
+
+ <div class="form-row">
+ <div class="col-md-12">
-+ <& /Elements/EditCustomFields, Object => $UserObj, Grouping => 'Location', InTable => 1 &>
++ <& /Elements/EditCustomFields, Object => $UserObj, Grouping => 'Location' &>
+ </div>
+ </div>
+ </&>
@@ -317,7 +318,7 @@
+
+%if ($UserObj->Privileged) {
+<div class="form-row">
-+ <div class="col-md-4">
++ <div class="col-md-6">
+ <&| /Widgets/TitleBox, title => loc('Signature'), id => "user-prefs-signature" &>
+ <textarea class="form-control" cols="80" rows="5" name="Signature" class="signature" wrap="hard">
+ <%$UserObj->Signature || ''%></textarea>
@@ -355,7 +356,7 @@
- <&| /Widgets/TitleBox, title => loc('Identity'), id => "user-prefs-identity" &>
+<div class="form-row">
+%### Left column ###
-+ <div class="col-md-7">
++ <div class="col-md-6">
+
+ <&| /Widgets/TitleBox, title => loc('Identity'), id => "user-prefs-identity" &>
<input type="hidden" class="hidden" name="Name" value="<%$UserObj->Name%>" />
@@ -554,7 +555,7 @@
+
+%### Right column ###
+
-+ <div class="col-md-5">
++ <div class="col-md-6">
+
+ <&| /Widgets/TitleBox, title => loc('Location'), id => "user-prefs-location" &>
+ <div class="form-row">
@@ -638,13 +639,23 @@
--- a/share/html/Prefs/MyRT.html
+++ b/share/html/Prefs/MyRT.html
@@
+
<&|/Widgets/TitleBox, title => loc('Options'), bodyclass => "" &>
<form method="post" action="MyRT.html">
- <&|/l&>Rows per box</&>:
+-<&|/l&>Rows per box</&>:
-<input type="text" name="SummaryRows" value="<% $ARGS{SummaryRows} %>" />
-<input type="submit" class="button" name="UpdateSummaryRows" value="<% loc('Save') %>" />
-+<input class="form-control" type="text" name="SummaryRows" value="<% $ARGS{SummaryRows} %>" />
-+<input type="submit" class="button form-control btn btn-primary"" name="UpdateSummaryRows" value="<% loc('Save') %>" />
++<div class="form-row">
++ <div class="col-md-auto label">
++ <&|/l&>Rows per box</&>:
++ </div>
++ <div class="col-md-auto">
++ <input class="form-control" type="text" name="SummaryRows" value="<% $ARGS{SummaryRows} %>" />
++ </div>
++ <div class="col-md-auto">
++ <input type="submit" class="button form-control btn btn-primary"" name="UpdateSummaryRows" value="<% loc('Save') %>" />
++ </div>
++</div>
</form>
</&>
<&|/Widgets/TitleBox, title => loc("Reset RT at a glance") &>
@@ -682,7 +693,7 @@
<h1><&|/l&>Select queues to be displayed on the "RT at a glance" page</&></h1>
<form method="post" action="QueueList.html" name="Preferences">
-<ul>
-+ <ul class="list-group">
++ <ul class="list-group list-group-borderless">
% for my $queue (@queues) {
-<li><input type="checkbox" class="checkbox" id="Want-<%$queue->Name%>" name="Want-<%$queue->Name%>" value="1"
+ <li class="list-group-item">
@@ -721,25 +732,21 @@
--- a/share/html/Prefs/Search.html
+++ b/share/html/Prefs/Search.html
@@
- <& /Elements/Tabs
- &>
- <& /Elements/ListActions, actions => \@actions &>
-+
- % if ($session{'CurrentUser'}->HasRight( Object=> $RT::System, Right => 'SuperUser')) {
- <p>
- <&|/l&>You can also edit the predefined search itself</&>:
-@@
<input type="hidden" name="name" value="<%$ARGS{name}%>" class="hidden" />
<input type="hidden" name="Format" value="<%$ARGS{Format}%>" class="hidden" />
-<& /Search/Elements/DisplayOptions, %$SearchArg, %ARGS,
- AvailableColumns => $AvailableColumns, CurrentFormat => $CurrentFormat &>
-<& /Elements/Submit, Caption => loc("Save Changes"), Label => loc('Save'), Name => 'Save'&>
--
+ <div class="form-row">
+ <& /Search/Elements/DisplayOptions, %$SearchArg, %ARGS,
+ AvailableColumns => $AvailableColumns, CurrentFormat => $CurrentFormat &>
-+ <& /Elements/Submit, Caption => loc("Save Changes"), Label => loc('Save'), Name => 'Save'&>
++ </div>
+
++ <div class="form-row">
++ <div class="col-md-12">
++ <& /Elements/Submit, Caption => loc("Save Changes"), Label => loc('Save'), Name => 'Save'&>
++ </div>
+ </div>
</form>
@@ -751,10 +758,7 @@
+<input type="submit" class="button form-control btn btn-primary"" name="ResetSearchOptions" value="<% loc('Reset to default') %>">
</form>
</&>
--
- <%INIT>
- my @actions;
- my $title = loc("Customize").' ';
+
diff --git a/share/html/SelfService/Prefs.html b/share/html/SelfService/Prefs.html
--- a/share/html/SelfService/Prefs.html
@@ -808,17 +812,12 @@
+ <div class="col-md-6">
+ <&| /Widgets/TitleBox, title => loc('Change password') &>
% if ( $user->__Value('Password') ne '*NO-PASSWORD*' ) {
--<& /Elements/EditPassword,
-- User => $user,
-- Name => $password,
--&>
-+ <& /Elements/EditPassword,
-+ User => $user,
-+ Name => $password,
-+ &>
+ <& /Elements/EditPassword,
+ User => $user,
+@@
+ &>
% }
--</&>
-+ </&>
+ </&>
+ </div>
+
+ <div class="form-row">
More information about the rt-commit
mailing list