[Rt-commit] rt branch, 4.6/select-queue-dropdown, created. rt-4.4.4-518-gc843e44f71

[Jim Brandt]

The branch, 4.6/select-queue-dropdown has been created
        at  c843e44f71d1bac9223e162ec9e94c6bbcea43fd (commit)

- Log -----------------------------------------------------------------
commit 5619efdf918946c0c84d27ec45dd1cdd327d87fe
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Sep 5 17:26:05 2019 -0400

    Move accesskey attribute to the queue select element
    
    The accesskey attribute needs to be on the targeted element,
    so this change makes it functional again for browsers that support it.
    
    The previous positioning with an unused label tag also impacted
    the dropdown style. Correcting the positioning also corrects
    the incorrect dropdown width.

diff --git a/share/html/Elements/SelectNewTicketQueue b/share/html/Elements/SelectNewTicketQueue
index 56a22bf6ee..7a09867cb4 100644
--- a/share/html/Elements/SelectNewTicketQueue
+++ b/share/html/Elements/SelectNewTicketQueue
@@ -45,9 +45,9 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<label accesskey="9" class="select-queue">
-  <& /Elements/SelectQueue, Name => 'Queue', Default => $queue, %ARGS, ShowNullOption => 0, ShowAllQueues => 0 &>
-</label>
+
+<& /Elements/SelectQueue, Name => 'Queue', Default => $queue, %ARGS, ShowNullOption => 0, ShowAllQueues => 0, AccessKey => 9 &>
+
 <%INIT>
 my $queue = delete $ARGS{Default};
 if ( !$queue ) {
diff --git a/share/html/Elements/SelectObject b/share/html/Elements/SelectObject
index 02b154a522..37db75ea46 100644
--- a/share/html/Elements/SelectObject
+++ b/share/html/Elements/SelectObject
@@ -64,7 +64,7 @@
 </ul>
 % }
 % else {
-<select name="<%$Name%>" <% ($Multiple) ? qq{class="tall" multiple="multiple" size="$Size"} : '' |n%> <% ($OnChange) ?  'onchange="'.$OnChange.'"' : '' |n %> class="<%$Class%> selectpicker form-control">
+<select name="<%$Name%>" <% ($Multiple) ? qq{class="tall" multiple="multiple" size="$Size"} : '' |n%> <% ($OnChange) ?  'onchange="'.$OnChange.'"' : '' |n %> class="<%$Class%> selectpicker form-control" <% ($AccessKey) ? qq{accesskey="$AccessKey"} : '' |n%>>
 %     if ($ShowNullOption) {
   <option value=""><% $DefaultLabel %></option>
 %     }
@@ -98,6 +98,7 @@ $Size => 6
 $Class => ""
 $CacheNeedsUpdate => undef
 $Hyperlink => undef
+$AccessKey => undef
 </%args>
 <%init>
 $ObjectType = "RT::$ObjectType" unless $ObjectType =~ /::/;

commit c843e44f71d1bac9223e162ec9e94c6bbcea43fd
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Sep 6 11:40:58 2019 -0400

    Remove unused select-queue styles

diff --git a/share/static/css/elevator-light/portlets.css b/share/static/css/elevator-light/portlets.css
index 7509c47d76..3daf188a09 100644
--- a/share/static/css/elevator-light/portlets.css
+++ b/share/static/css/elevator-light/portlets.css
@@ -7,8 +7,3 @@ table.dashboard {
    max-width: 500px;
 }
 
-.quick-create input[type="text"],
-.quick-create input[type="email"],
-.quick-create textarea {
-    width: 100%;
-}

-----------------------------------------------------------------------