[Rt-commit] rt branch, 4.6/configindatabase-themed, repushed

[? sunnavy]

The branch 4.6/configindatabase-themed was deleted and repushed:
       was 801c2b4e7031e737e75d9c363585f768d9d57220
       now 4117e8957a4f540771d2a9088a41a12498188f9e

 1: b28dc30467 =  1: b28dc30467 Allow specifying size for Integer and String widgets
 2: 94744da2c6 =  2: 94744da2c6 Allow String widget to have a value of "0"
 3: 59334314c9 =  3: 59334314c9 Add RadioStyle option to Boolean widget
 4: 534bba3102 =  4: 534bba3102 Make booleans with RadioStyle use true/false logic
 5: baf23200cd =  5: baf23200cd DatabaseSetting schema updates
 6: a888aa6cb0 =  6: a888aa6cb0 Add ORM classes for DatabaseSettings
 7: 05db0b9b37 =  7: 05db0b9b37 Port database config loading and refreshing from extension
 8: 7648dd10f1 =  8: 7648dd10f1 Add Code and MultilineString widgets
 9: 21f6abfb8c =  9: 21f6abfb8c Port EditConfig page from extension
10: 165422a396 = 10: 165422a396 Annotate Immutable options
11: f2f0b772d7 = 11: f2f0b772d7 Add widget metadata for config options
12: 5803325e5f = 12: 5803325e5f Hide deprecated options
13: b878fb9786 = 13: b878fb9786 List Database as source of configuration on Sys Config page
14: 02b6a1a9fb = 14: 02b6a1a9fb Render config with EditLink as readonly
15: 94cbaf03d2 = 15: 94cbaf03d2 Switch from Storable::dclone to Clone::clone to handle code/regex
16: c0d5683bfb = 16: c0d5683bfb Migrate MultilineString to new themes
17: 9fcde4980a = 17: 9fcde4980a Add LabelLink support for form widgets
18: 1eee9b8f55 = 18: 1eee9b8f55 Vertically align boolean label/value
19: fb5f04660a = 19: fb5f04660a Add tabs to the Configuration in DB feature
20: 21ff2fa0c2 = 20: 21ff2fa0c2 Add missing config options to %META
21: 5523105073 = 21: 5523105073 Rename DatabaseSetting to Configuration
22: d80765bfaf ! 22: 001d08162d Validate Content of Configurations
    @@ -25,7 +25,7 @@
          return (0, $self->loc("Permission Denied")) unless $self->CurrentUserCanSee;
      
     +    my ( $ok, $msg ) = $self->ValidateContent( Content => $value );
    -+    return (0, $msg) unless $ok;
    ++    return ( 0, $msg ) unless $ok;
     +
          my ($old_value, $error) = $self->Content;
          unless (defined($old_value) && length($old_value)) {
    @@ -69,7 +69,7 @@
     +            return ( 0, $self->loc( 'Invalid value for [_1], should be of type [_2]', $args{Name}, $type ) );
     +        }
     +    }
    -+    return 1;
    ++    return ( 1, $self->loc('Content valid') );
     +}
     +
      =head1 PRIVATE METHODS
23: 1ada6c8511 = 23: 018f6a442e Use Data::Dumper instead in Configuration to support regex
24: 165ca1445f = 24: 5048fa4270 Note RT::Extension::ConfigInDatabase is cored and the main backend change
25: 801c2b4e70 ! 25: 4117e8957a Add test for /Admin/Tools/EditConfig.html
    @@ -21,7 +21,7 @@
     +my ( $url, $m ) = RT::Test->started_ok;
     +ok( $m->login(), 'logged in' );
     +
    -+$m->follow_link_ok( { id => 'admin-tools-edit_config' } , 'followed link to "Edit Configuration"');
    ++$m->follow_link_ok( { text => 'Edit Configuration' }, 'followed link to "Edit Configuration"' );
     +
     +my $tests = [
     +    {