[Rt-commit] rt branch, 4.4/fix-shredder-scrip-removal, updated. rt-4.4.4-46-g2295dcfbb

Blaine Motsinger blaine at bestpractical.com
Tue Oct 22 20:56:20 EDT 2019


The branch, 4.4/fix-shredder-scrip-removal has been updated
       via  2295dcfbb66c869f31bd33c48fdba335be006f20 (commit)
      from  7d5502ffe1a4ee0be0d7854dbfef966c36150f36 (commit)

Summary of changes:
 t/shredder/02queue.t | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 2295dcfbb66c869f31bd33c48fdba335be006f20
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Tue Oct 22 19:48:27 2019 -0500

    Fix test to allow for remaining Scrip
    
    Commit 7d5502ffe deletes the ObjectScrips entry instead of Scrip
    when a queue is shredded.  This commit updates the test to no longer
    expect the Scrip removed.

diff --git a/t/shredder/02queue.t b/t/shredder/02queue.t
index 0c65c5daf..0cb63dd8d 100644
--- a/t/shredder/02queue.t
+++ b/t/shredder/02queue.t
@@ -41,7 +41,11 @@ diag 'queue with scrip' if $ENV{TEST_VERBOSE};
     $shredder->PutObjects( Objects => $queue );
     $shredder->WipeoutAll;
     $test->db_is_valid;
-    cmp_deeply( $test->dump_current_and_savepoint('clean'), "current DB equal to savepoint");
+    # Commit 7d5502ffe makes Scrips not be deleted when a queue is shredded.  We expect an extra key in the 
+    # current dump to be remaining.
+    # TODO: this could stand to be more specific to ensure our difference is the expected one, rather only testing
+    # if it's different or not.
+    ok( !eq_deeply( $test->dump_current_and_savepoint('clean') ), "current DB isn't equal to savepoint" );
 }
 
 diag 'queue with template' if $ENV{TEST_VERBOSE};

-----------------------------------------------------------------------


More information about the rt-commit mailing list