[Rt-commit] rt branch, 4.6/configindatabase-themed, repushed

[Michel Rodriguez]

The branch 4.6/configindatabase-themed was deleted and repushed:
       was 00e8652b98a9c5d446e11f758be085c7a3d1b4af
       now 5480310b20bb2fc01b7eef8bf921c166624714a4

 1: d4f253784 =  1: d4f253784 finished rebase
 2: 2d3d7fc01 =  2: 2d3d7fc01 Add RadioStyle option to Boolean widget
 3: db257822a =  3: db257822a Make booleans with RadioStyle use true/false logic
 4: 0db9e30d5 =  4: 0db9e30d5 DatabaseSetting schema updates
 5: bc46020c5 =  5: bc46020c5 Add ORM classes for DatabaseSettings
 6: 8ef035749 =  6: 8ef035749 Port database config loading and refreshing from extension
 7: 2dea073d0 =  7: 2dea073d0 Add Code and MultilineString widgets
 8: 82d083851 =  8: 82d083851 Port EditConfig page from extension
 9: 34cdedd13 =  9: 34cdedd13 Annotate Immutable options
10: f97f98a77 = 10: f97f98a77 Add widget metadata for config options
11: 0637f0ce4 = 11: 0637f0ce4 Hide deprecated options
12: 75d5e1352 = 12: 75d5e1352 List Database as source of configuration on Sys Config page
13: b08595411 = 13: b08595411 Render config with EditLink as readonly
14: 6d2a63716 ! 14: 3e0bdb641 Adds tabs to the Configuration in DB feature
    @@ -1,6 +1,47 @@
     Author: michel <michel at bestpractical.com>
     
         Adds tabs to the Configuration in DB feature
    +
    +diff --git a/etc/RT_SiteConfig.pm b/etc/RT_SiteConfig.pm
    +deleted file mode 100644
    +--- a/etc/RT_SiteConfig.pm
    ++++ /dev/null
    +@@
    +-use utf8;
    +-
    +-# Any configuration directives you include  here will override
    +-# RT's default configuration file, RT_Config.pm
    +-#
    +-# To include a directive here, just copy the equivalent statement
    +-# from RT_Config.pm and change the value. We've included a single
    +-# sample value below.
    +-#
    +-# If this file includes non-ASCII characters, it must be encoded in
    +-# UTF-8.
    +-#
    +-# This file is actually a perl module, so you can include valid
    +-# perl code, as well.
    +-#
    +-# The converse is also true, if this file isn't valid perl, you're
    +-# going to run into trouble. To check your SiteConfig file, use
    +-# this command:
    +-#
    +-#   perl -c /path/to/your/etc/RT_SiteConfig.pm
    +-#
    +-# You must restart your webserver after making changes to this file.
    +-#
    +-
    +-# You may also split settings into separate files under the etc/RT_SiteConfig.d/
    +-# directory.  All files ending in ".pm" will be parsed, in alphabetical order,
    +-# after this file is loaded.
    +-
    +-Set( $rtname, 'example.com');
    +-
    +-# You must install Plugins on your own, this is only an example
    +-# of the correct syntax to use when activating them:
    +-#     Plugin( "RT::Authen::ExternalAuth" );
    +-
    +-1;
     
     diff --git a/lib/RT/Config.pm b/lib/RT/Config.pm
     --- a/lib/RT/Config.pm
    @@ -242,8 +283,8 @@
     +
     +# returns an id in the EditConfig.html page
     +# args are
    -+# type    => ['nav' || 'content' || 'form' ] id for nav links or content respectively 
    -+# level   => ['tab' || 'section' || 'subsection' ] 
    ++# type    => ['nav' || 'content' || 'form' ] id for nav links or content respectively
    ++# level   => ['tab' || 'section' || 'subsection' ]
     +# context => { tab => <tab_id>, section => <section_id>, subsection => <subsection_id> }
     +sub edit_config_id {
     +    my $self = shift;
    @@ -261,10 +302,10 @@
     +
     +# returns whether a section is active (ie it's displayed when you open its tab) or not
     +# if the current tab is active then the section is active if it is the active one
    -+# otherwise (the current tab is not the active one), the section is active if it is 
    ++# otherwise (the current tab is not the active one), the section is active if it is
     +# the first one
    -+# this is abstracted as a method because it needs to be called for each menu item  and 
    -+# for each tab content, so this avoids duplicating code 
    ++# this is abstracted as a method because it needs to be called for each menu item  and
    ++# for each tab content, so this avoids duplicating code
     +# first-section still needs to be managed by the calling code though
     +sub section_is_active {
     +    my $self= shift;
15: 00e8652b9 ! 15: 2472c0dda Fixes failing tests due to undefined variables
    @@ -478,3 +478,4 @@
      <%ARGS>
      $Name
      $CurrentValue => '',
    +
--:  ------- > 16: bf36648f2 Uses bootstrap pill for section left column menu
--:  ------- > 17: 48543bb56 Switch from Storable::dclone to Clone::clone to handle code/regex
--:  ------- > 18: 5480310b2 Fix index of "Disabled" for mysql