[Rt-commit] rt branch, 4.6/tweak-elevator-themes, created. rt-4.4.4-402-g88327da1e

? sunnavy sunnavy at bestpractical.com
Wed Sep 25 17:19:39 EDT 2019


The branch, 4.6/tweak-elevator-themes has been created
        at  88327da1e44bb6333aabd5dbed0d2ba1fbdb0618 (commit)

- Log -----------------------------------------------------------------
commit d496918f8a9e78c3faa26f0d77f0911397a77c78
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 30 20:17:01 2019 +0800

    Unset margin-top for .form-row in .value
    
    The structure is like:
    
    <div class="form-row">
      <div class="label col-md-3">
      </div>
      <div class="value col-md-9">
        <div class="form-row">
          ...
        </div>
      </div>
    </div>
    
    .form-row has "margin-top: 0.5em", but to align the label/value divs
    horizontally, we don't want this style for .form-row in .value
    
    This commit fixes the alignment issue of date/time inputs

diff --git a/share/static/css/elevator-light/forms.css b/share/static/css/elevator-light/forms.css
index cea408ed0..825c5065c 100644
--- a/share/static/css/elevator-light/forms.css
+++ b/share/static/css/elevator-light/forms.css
@@ -315,6 +315,10 @@ button {
   margin-top: 0.5em;
 }
 
+.form-row > .value .form-row {
+  margin-top: 0;
+}
+
 .col-auto .datepicker {
   width: 17em;
 }

commit 88e0dbd29723a84fe1a72961ba4e64875884a827
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 30 21:32:21 2019 +0800

    Tweak position of approval pending hint on ticket display page
    
    The form-row wrapper gives consistent margins as other rows.

diff --git a/share/html/Ticket/Elements/ShowDependencyStatus b/share/html/Ticket/Elements/ShowDependencyStatus
index 2f6bae868..d454d0a81 100644
--- a/share/html/Ticket/Elements/ShowDependencyStatus
+++ b/share/html/Ticket/Elements/ShowDependencyStatus
@@ -45,7 +45,8 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<div class="dependency-status">
+<div class="dependency-status form-row">
+  <div class="col-md-12">
 % if ($approvals) {
     <span class="summary">
 %   if ($approvals == 1) {
@@ -59,6 +60,7 @@
   <span class="summary"><&|/l, $depends &>Pending [quant,_1,ticket,tickets].</&></span>
   <&|/l, $depends &>This ticket cannot be resolved until its [numerate,_1,dependency is,dependencies are] resolved.</&>
 % }
+  </div>
 </div>
 <%args>
 $Ticket

commit 58a4561f022526fa6008998a66f87de39d12a31c
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 30 21:33:11 2019 +0800

    Tweak position of ticket creation form in links widget on ticket display page
    
    The form-row wrapper gives consistent margins as other rows.

diff --git a/share/html/Elements/ShowLinks b/share/html/Elements/ShowLinks
index cd9b83ed2..3bee125e6 100644
--- a/share/html/Elements/ShowLinks
+++ b/share/html/Elements/ShowLinks
@@ -67,20 +67,24 @@
 </div>
 
 % if ($Object->isa('RT::Ticket')) {
-  <form action="<% RT->Config->Get('WebPath') ."/Helpers/SpawnLinkedTicket" %>" name="SpawnLinkedTicket">
-    <input type="hidden" name="CloneTicket" value="<% $Object->id %>">
-    <input type="submit" value="<&|/l&>Create</&>" name="SpawnLinkedTicket" class="btn btn-primary">
-    <select name="LinkType" class="selectpicker">
-      <option value="DependsOn-new"><% loc('Depends on') %></option>
-      <option value="new-DependsOn"><% loc('Depended on by') %></option>
-      <option value="MemberOf-new"><% loc('Parents') %></option>
-      <option value="new-MemberOf"><% loc('Children') %></option>
-      <option value="RefersTo-new"><% loc('Refers to') %></option>
-      <option value="new-RefersTo"><% loc('Referred to by') %></option>
-    </select>
-    <&|/l&>Ticket in</&>
-    <& /Elements/SelectNewTicketQueue, Name => 'CloneQueue' &>
-  </form>
+  <div class="form-row">
+    <div class="col-md-12">
+      <form action="<% RT->Config->Get('WebPath') ."/Helpers/SpawnLinkedTicket" %>" name="SpawnLinkedTicket">
+        <input type="hidden" name="CloneTicket" value="<% $Object->id %>">
+        <input type="submit" value="<&|/l&>Create</&>" name="SpawnLinkedTicket" class="btn btn-primary">
+        <select name="LinkType" class="selectpicker">
+          <option value="DependsOn-new"><% loc('Depends on') %></option>
+          <option value="new-DependsOn"><% loc('Depended on by') %></option>
+          <option value="MemberOf-new"><% loc('Parents') %></option>
+          <option value="new-MemberOf"><% loc('Children') %></option>
+          <option value="RefersTo-new"><% loc('Refers to') %></option>
+          <option value="new-RefersTo"><% loc('Referred to by') %></option>
+        </select>
+        <&|/l&>Ticket in</&>
+        <& /Elements/SelectNewTicketQueue, Name => 'CloneQueue' &>
+      </form>
+    </div>
+  </div>
 % }
 <%INIT>
 my @display = qw(DependsOn DependedOnBy MemberOf Members RefersTo ReferredToBy);

commit 0070dee46f2d49936199c2ed97267b55079b3bf7
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Sep 21 03:26:46 2019 +0800

    Tweak submit button position on rights admin pages
    
    The form-row wrapper gives consistent margins as other rows.

diff --git a/share/html/Admin/Global/GroupRights.html b/share/html/Admin/Global/GroupRights.html
index 985d00101..8ab06da7a 100644
--- a/share/html/Admin/Global/GroupRights.html
+++ b/share/html/Admin/Global/GroupRights.html
@@ -51,7 +51,11 @@
 
 <form method="post" action="GroupRights.html" id="ModifyGroupRights" name="ModifyGroupRights">
   <& /Admin/Elements/EditRights, Context => $RT::System, Principals => \@principals &>
-  <& /Elements/Submit, Label => loc('Save Changes') &>
+  <div class="form-row">
+    <div class="col-md-12">
+      <& /Elements/Submit, Label => loc('Save Changes') &>
+    </div>
+  </div>
 </form>
   
 <%INIT>
diff --git a/share/html/Admin/Global/UserRights.html b/share/html/Admin/Global/UserRights.html
index be0a225b2..2a6e137aa 100644
--- a/share/html/Admin/Global/UserRights.html
+++ b/share/html/Admin/Global/UserRights.html
@@ -51,7 +51,11 @@
 
 <form method="post" action="UserRights.html" name="ModifyUserRights" id="ModifyUserRights">
   <& /Admin/Elements/EditRights, Context => $RT::System, Principals => \@principals &>
-  <& /Elements/Submit, Label => loc('Save Changes') &>
+  <div class="form-row">
+    <div class="col-md-12">
+      <& /Elements/Submit, Label => loc('Save Changes') &>
+    </div>
+  </div>
 </form>
 <%INIT>
 my @results = ProcessACLs(\%ARGS);
diff --git a/share/html/Admin/Groups/GroupRights.html b/share/html/Admin/Groups/GroupRights.html
index 671126818..8034c3d92 100644
--- a/share/html/Admin/Groups/GroupRights.html
+++ b/share/html/Admin/Groups/GroupRights.html
@@ -52,7 +52,11 @@
   <form method="post" action="GroupRights.html" id="ModifyGroupRights" name="ModifyGroupRights">
     <input type="hidden" class="hidden" name="id" value="<% $GroupObj->id %>" />
     <& /Admin/Elements/EditRights, Context => $GroupObj, Principals => \@principals &>
-    <& /Elements/Submit, Label => loc('Save Changes') &>
+    <div class="form-row">
+      <div class="col-md-12">
+        <& /Elements/Submit, Label => loc('Save Changes') &>
+      </div>
+    </div>
   </form>
 <%INIT>
 # Update the acls.
diff --git a/share/html/Admin/Groups/UserRights.html b/share/html/Admin/Groups/UserRights.html
index 985912073..df1e47b90 100644
--- a/share/html/Admin/Groups/UserRights.html
+++ b/share/html/Admin/Groups/UserRights.html
@@ -52,7 +52,11 @@
   <form method="post" action="UserRights.html" name="ModifyUserRights" id="ModifyUserRights">
     <input type="hidden" class="hidden" name="id" value="<% $GroupObj->id %>" />
     <& /Admin/Elements/EditRights, Context => $GroupObj, Principals => \@principals &>
-    <& /Elements/Submit, Label => loc('Save Changes') &>
+    <div class="form-row">
+      <div class="col-md-12">
+        <& /Elements/Submit, Label => loc('Save Changes') &>
+      </div>
+    </div>
   </form>
 
 <%INIT>

commit ef6a7b5958cdf860711258941d54b8c67f04fde8
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Sep 26 02:52:21 2019 +0800

    Drop obsolete label css rules

diff --git a/share/static/css/elevator-light/forms.css b/share/static/css/elevator-light/forms.css
index 825c5065c..db893863c 100644
--- a/share/static/css/elevator-light/forms.css
+++ b/share/static/css/elevator-light/forms.css
@@ -105,16 +105,8 @@ div.error .titlebox-title .widget a {
   background-position: center -7px;
 }
 
-.label, .labeltop {
- text-align: right;
- padding-right: .5em;
- padding-top: .5em;
-}
-
-.cflabel {
- text-align: right;
- padding-right: .5em;
- width: 12em;
+.label {
+  text-align: right;
 }
 
 .value > ul {
@@ -122,10 +114,6 @@ div.error .titlebox-title .widget a {
     margin-bottom: 0;
 }
 
-td.cflabel {
-    width: auto;
-}
-
 div.ticket-info-basics div.titlebox-content .labeltop{
   width: 10em;
 }

commit 036e0128dd2c34bb438653f5afa4729442cf8658
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Sep 26 03:49:28 2019 +0800

    Horizontally align label/input in forms again
    
    padding-top of .form-control in our bootstrap version was set to 6px,
    and as the input fonts are smaller, setting padding-top of .label to 5px
    looks better.
    
    For .label out of forms, this padding-top rule is removed as we want to
    make the display layout denser(like "The Basics" widget on ticket
    display page).

diff --git a/share/static/css/elevator-light/forms.css b/share/static/css/elevator-light/forms.css
index db893863c..69033757b 100644
--- a/share/static/css/elevator-light/forms.css
+++ b/share/static/css/elevator-light/forms.css
@@ -342,8 +342,8 @@ span.current-value.form-control {
   line-height: 1;
 }
 
-.form-row .label {
-  padding-top: calc(0.375rem + 1px);
+form .label {
+  padding-top: 5px;
 }
 
 .btn {

commit c1fa19f49bd00ca61a1c6761588ba465e5a98823
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Sep 26 03:56:32 2019 +0800

    Remove "form-control" class from display elements for denser layout
    
    "form-control" is mainly to tweak input box, and there is no need to use
    it for display elements, which takes a bit more unnecessary space.

diff --git a/share/html/Admin/Actions/Elements/ShowBasics b/share/html/Admin/Actions/Elements/ShowBasics
index ac1358aca..b285eb835 100644
--- a/share/html/Admin/Actions/Elements/ShowBasics
+++ b/share/html/Admin/Actions/Elements/ShowBasics
@@ -50,7 +50,7 @@
     <&|/l&>Name</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"Name"} || $Action->Name || '' %></span>
+    <span class="current-value"><% $ARGS{"Name"} || $Action->Name || '' %></span>
   </div>
 </div>
 
@@ -59,7 +59,7 @@
     <&|/l&>Description</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"Description"} || $Action->Description || '' %></span>
+    <span class="current-value"><% $ARGS{"Description"} || $Action->Description || '' %></span>
   </div>
 </div>
 
@@ -68,7 +68,7 @@
     <&|/l&>Action Module</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"ExecModule"} || $Action->ExecModule || ''%></span>
+    <span class="current-value"><% $ARGS{"ExecModule"} || $Action->ExecModule || ''%></span>
   </div>
 </div>
 
@@ -77,7 +77,7 @@
     <&|/l&>Parameters to Pass</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"Argument"} || $Action->Argument || '' %></span>
+    <span class="current-value"><% $ARGS{"Argument"} || $Action->Argument || '' %></span>
   </div>
 </div>
 
diff --git a/share/html/Admin/Conditions/Elements/ShowBasics b/share/html/Admin/Conditions/Elements/ShowBasics
index dbd33b1e6..8449c90fe 100644
--- a/share/html/Admin/Conditions/Elements/ShowBasics
+++ b/share/html/Admin/Conditions/Elements/ShowBasics
@@ -50,7 +50,7 @@
     <&|/l&>Name</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"Name"} || $Condition->Name || '' %></span>
+    <span class="current-value"><% $ARGS{"Name"} || $Condition->Name || '' %></span>
   </div>
 </div>
 
@@ -59,7 +59,7 @@
     <&|/l&>Description</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"Description"} || $Condition->Description || '' %></span>
+    <span class="current-value"><% $ARGS{"Description"} || $Condition->Description || '' %></span>
   </div>
 </div>
 
@@ -68,7 +68,7 @@
     <&|/l&>Condition Module</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"ExecModule"} || $Condition->ExecModule || ''%></span>
+    <span class="current-value"><% $ARGS{"ExecModule"} || $Condition->ExecModule || ''%></span>
   </div>
 </div>
 
@@ -77,7 +77,7 @@
     <&|/l&>Parameters to Pass</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"Argument"} || $Condition->Argument || '' %></span>
+    <span class="current-value"><% $ARGS{"Argument"} || $Condition->Argument || '' %></span>
   </div>
 </div>
 
@@ -86,7 +86,7 @@
     <&|/l&>Applicable Transaction Types</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $ARGS{"ApplicableTransTypes"} || $Condition->ApplicableTransTypes || '' %></span>
+    <span class="current-value"><% $ARGS{"ApplicableTransTypes"} || $Condition->ApplicableTransTypes || '' %></span>
   </div>
 </div>
 
diff --git a/share/html/Admin/Elements/ShowKeyInfo b/share/html/Admin/Elements/ShowKeyInfo
index 8cb2ec2c7..3c28fedd4 100644
--- a/share/html/Admin/Elements/ShowKeyInfo
+++ b/share/html/Admin/Elements/ShowKeyInfo
@@ -78,7 +78,7 @@
     <% loc('Trust') %>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% loc( $res{'info'}{'Trust'} ) %></span>
+    <span class="current-value"><% loc( $res{'info'}{'Trust'} ) %></span>
   </div>
 </div>
 % }
@@ -88,7 +88,7 @@
     <% loc('Fingerprint') %>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $res{'info'}{'Fingerprint'} %></span>
+    <span class="current-value"><% $res{'info'}{'Fingerprint'} %></span>
   </div>
 </div>
 
@@ -98,7 +98,7 @@
     <% loc('Created') %>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control">
+    <span class="current-value">
       <% $res{'info'}{'Created'}? $res{'info'}{'Created'}->AsString( Time => 0 ): loc('never') %>
     </span>
   </div>
@@ -109,7 +109,7 @@
     <% loc('Expire') %>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control">
+    <span class="current-value">
       <% $res{'info'}{'Expire'}? $res{'info'}{'Expire'}->AsString( Time => 0 ): loc('never') %>
     </span>
   </div>
@@ -123,7 +123,7 @@
     <% loc('User (created - expire)') %>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control">
+    <span class="current-value">
       <% $uinfo->{'String'} %> \
      (<% $uinfo->{'Created'}? $uinfo->{'Created'}->AsString( Time => 0 ): loc('never') %> - <% $uinfo->{'Expire'}? $uinfo->{'Expire'}->AsString( Time => 0 ): loc('never') %>)
     </span>
@@ -135,7 +135,7 @@
     <% loc('User') %>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $uinfo->{'String'} %></span>
+    <span class="current-value"><% $uinfo->{'String'} %></span>
   </div>
 </div>
 
diff --git a/share/html/Articles/Article/Display.html b/share/html/Articles/Article/Display.html
index e41f0d8bf..bceeffe40 100644
--- a/share/html/Articles/Article/Display.html
+++ b/share/html/Articles/Article/Display.html
@@ -54,7 +54,7 @@
       <&|/l&>Summary</&>:
     </div>
     <div class="col-md-9 value">
-      <span class="current-value form-control"><%$article->Summary%></span>
+      <span class="current-value"><%$article->Summary%></span>
     </div>
   </div>
 
@@ -63,7 +63,7 @@
       <&|/l&>Class</&>:
     </div>
     <div class="col-md-9 value">
-      <span class="current-value form-control"><%$article->ClassObj->Name%></span>
+      <span class="current-value"><%$article->ClassObj->Name%></span>
     </div>
   </div>
 
@@ -72,7 +72,7 @@
       <&|/l&>Creator</&>:
     </div>
     <div class="col-md-9 value">
-      <span class="current-value form-control"><& /Elements/ShowUser, User => $article->CreatorObj &></span>
+      <span class="current-value"><& /Elements/ShowUser, User => $article->CreatorObj &></span>
     </div>
   </div>
 
@@ -81,7 +81,7 @@
       <&|/l&>Created</&>:
     </div>
     <div class="col-md-9 value">
-      <span class="current-value form-control"><%$article->CreatedObj->AsString%></span>
+      <span class="current-value"><%$article->CreatedObj->AsString%></span>
     </div>
   </div>
 
@@ -90,7 +90,7 @@
       <&|/l&>Updated</&>:
     </div>
     <div class="col-md-9 value">
-      <span class="current-value form-control"><%$article->LastUpdatedObj->AsString%></span>
+      <span class="current-value"><%$article->LastUpdatedObj->AsString%></span>
     </div>
   </div>
 </&>
diff --git a/share/html/Articles/Article/Elements/ShowLinks b/share/html/Articles/Article/Elements/ShowLinks
index 5dcca7422..982eb3e97 100644
--- a/share/html/Articles/Article/Elements/ShowLinks
+++ b/share/html/Articles/Article/Elements/ShowLinks
@@ -55,7 +55,7 @@
 % while (my $link = $refersto->Next) {
 % my $member = $link->TargetURI;
 <li class="list-group-item">
-<span class="current-value form-control">
+<span class="current-value">
 % if ($link->TargetURI->IsLocal) {
 <a href="<%$member->AsHREF%>"><% loc($member->Object->RecordType) %> <%$member->Object->Id%>: 
 % if (UNIVERSAL::isa($member->Object, "RT::Article") or UNIVERSAL::can($member->Object, 'Name')) {
@@ -82,7 +82,7 @@
 % while (my $link = $referredtoby->Next) {
 % my $member = $link->BaseURI;
 <li class="list-group-item">
-<span class="current-value form-control">
+<span class="current-value">
 % if ($member->IsLocal) {
 <a href="<%$member->AsHREF%>"><% loc($member->Object->RecordType) %> <%$member->Object->Id%>: 
 % if (UNIVERSAL::isa($member->Object, "RT::Article") or UNIVERSAL::can($member->Object, 'Name')) {
diff --git a/share/html/Articles/Article/Elements/ShowTopics b/share/html/Articles/Article/Elements/ShowTopics
index b9cbabcf1..93f000c29 100644
--- a/share/html/Articles/Article/Elements/ShowTopics
+++ b/share/html/Articles/Article/Elements/ShowTopics
@@ -50,7 +50,7 @@
     <&|/l&>Topics</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control">
+    <span class="current-value">
 % my $topics = RT::ObjectTopics->new($session{'CurrentUser'});
 % $topics->LimitToObject($article);
 % while (my $t = $topics->Next) {
diff --git a/share/html/Articles/Elements/NewestArticles b/share/html/Articles/Elements/NewestArticles
index 5264091d1..f0fa4c700 100644
--- a/share/html/Articles/Elements/NewestArticles
+++ b/share/html/Articles/Elements/NewestArticles
@@ -65,21 +65,21 @@
 % $i++;
 <div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row">
   <div class="col-md-auto value text-right">
-    <span class="current-value form-control"><%$Article->Id%></span>
+    <span class="current-value"><%$Article->Id%></span>
   </div>
   <div class="col-md-4 value text-left">
-    <span class="current-value form-control"><a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Display.html?id=<%$Article->Id%>"><%$Article->Name || loc('(no name)')%></a></span>
+    <span class="current-value"><a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Display.html?id=<%$Article->Id%>"><%$Article->Name || loc('(no name)')%></a></span>
   </div>
   <div class="col-md-4 value text-left">
-    <span class="current-value form-control"><%$Article->CreatorObj->Name%></span>
+    <span class="current-value"><%$Article->CreatorObj->Name%></span>
   </div>
   <div class="col-md-3 value text-left">
-    <span class="current-value form-control">[<a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Edit.html?id=<%$Article->Id%>"><&|/l&>Update</&></a>]</span>
+    <span class="current-value">[<a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Edit.html?id=<%$Article->Id%>"><&|/l&>Update</&></a>]</span>
   </div>
 </div>
 <div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row">
   <div class="col-md-11 col-md-offset-1">
-    <span class="current-value form-control"><small><%$Article->Summary || loc('(no Summary)')%></small></span>
+    <span class="current-value"><small><%$Article->Summary || loc('(no Summary)')%></small></span>
   </div>
 </div>
 % }
diff --git a/share/html/Articles/Elements/UpdatedArticles b/share/html/Articles/Elements/UpdatedArticles
index e11dde957..f69328033 100644
--- a/share/html/Articles/Elements/UpdatedArticles
+++ b/share/html/Articles/Elements/UpdatedArticles
@@ -66,22 +66,22 @@
 % $i++;
 <div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row">
   <div class="col-md-auto value text-right">
-    <span class="current-value form-control"><%$Article->Id%></span>
+    <span class="current-value"><%$Article->Id%></span>
   </div>
   <div class="col-md-4 value text-left">
-    <span class="current-value form-control"><a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Display.html?id=<%$Article->Id%>"><%$Article->Name || loc('(no name)')%></a></span>
+    <span class="current-value"><a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Display.html?id=<%$Article->Id%>"><%$Article->Name || loc('(no name)')%></a></span>
   </div>
   <div class="col-md-4 value text-left">
-    <span class="current-value form-control"><%$Article->CreatorObj->Name%></span>
+    <span class="current-value"><%$Article->CreatorObj->Name%></span>
   </div>
   <div class="col-md-3 value text-left">
-    <span class="current-value form-control">[<a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Edit.html?id=<%$Article->Id%>"><&|/l&>Update</&></a>]</span>
+    <span class="current-value">[<a href="<% RT->Config->Get('WebPath') %>/Articles/Article/Edit.html?id=<%$Article->Id%>"><&|/l&>Update</&></a>]</span>
   </div>
 </div>
 
 <div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row">
   <div class="col-md-11 col-md-offset-1">
-    <span class="current-value form-control"><small><%$Article->Summary || loc('(no Summary)')%></small></span>
+    <span class="current-value"><small><%$Article->Summary || loc('(no Summary)')%></small></span>
   </div>
 </div>
 % }
diff --git a/share/html/Asset/Elements/ShowBasics b/share/html/Asset/Elements/ShowBasics
index 771382f07..e3bfdb062 100644
--- a/share/html/Asset/Elements/ShowBasics
+++ b/share/html/Asset/Elements/ShowBasics
@@ -59,7 +59,7 @@
     <&|/l&>Name</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $AssetObj->Name || '' %></span>
+    <span class="current-value"><% $AssetObj->Name || '' %></span>
   </div>
 </div>
 
@@ -68,7 +68,7 @@
     <&|/l&>Description</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $AssetObj->Description || '' %></span>
+    <span class="current-value"><% $AssetObj->Description || '' %></span>
   </div>
 </div>
 
@@ -77,7 +77,7 @@
     <&|/l&>Status</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control"><% $AssetObj->Status || '' %></span>
+    <span class="current-value"><% $AssetObj->Status || '' %></span>
   </div>
 </div>
 
diff --git a/share/html/Asset/Elements/ShowCatalog b/share/html/Asset/Elements/ShowCatalog
index b68564b53..66a95c177 100644
--- a/share/html/Asset/Elements/ShowCatalog
+++ b/share/html/Asset/Elements/ShowCatalog
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<span class="current-value form-control"><% $value %></span>
+<span class="current-value"><% $value %></span>
 <%ARGS>
 $Asset   => undef
 $Catalog => undef
diff --git a/share/html/Asset/Elements/ShowDates b/share/html/Asset/Elements/ShowDates
index 7d4454cec..cb8a59fab 100644
--- a/share/html/Asset/Elements/ShowDates
+++ b/share/html/Asset/Elements/ShowDates
@@ -50,7 +50,7 @@
     <&|/l&>Created</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control">
+    <span class="current-value">
       <&|/l_unsafe,
         $m->interp->apply_escapes($AssetObj->CreatedAsString, 'h'),
         $m->scomp('/Elements/ShowUser', User => $AssetObj->CreatorObj)
@@ -64,7 +64,7 @@
     <&|/l&>Last Updated</&>:
   </div>
   <div class="col-md-9 value">
-    <span class="current-value form-control">
+    <span class="current-value">
       <&|/l_unsafe,
         $m->interp->apply_escapes($AssetObj->LastUpdatedAsString, 'h'),
         $m->scomp('/Elements/ShowUser', User => $AssetObj->LastUpdatedByObj)
diff --git a/share/html/Elements/ShowCustomFields b/share/html/Elements/ShowCustomFields
index 26ef1e570..7edfd80a9 100644
--- a/share/html/Elements/ShowCustomFields
+++ b/share/html/Elements/ShowCustomFields
@@ -68,7 +68,7 @@
   <div class="form-row <% join(' ', @classes) %>" id="CF-<%$CustomField->id%>-ShowRow">
     <div class="label col-md-3"><% $CustomField->Name %>:</div>
     <div class="value col-md-9 <% $count ? '' : ' no-value' %>">
-      <span class="form-control current-value">
+      <span class="current-value">
 % unless ( $count ) {
 <&|/l&>(no value)</&>
 % } elsif ( $count == 1 ) {
diff --git a/share/html/Elements/ShowLinks b/share/html/Elements/ShowLinks
index 3bee125e6..6c429f9a4 100644
--- a/share/html/Elements/ShowLinks
+++ b/share/html/Elements/ShowLinks
@@ -54,7 +54,7 @@
         <span class="create">(<a href="<% $clone{$type} %>"><% loc('Create') %></a>)</span>
 %     }
     </div>
-    <div class="value col-md-9"><span class="form-control current-value">
+    <div class="value col-md-9"><span class="current-value">
       <& ShowLinksOfType, Object => $Object, Type => $type, Recurse => ($type eq 'Members') &>
     </span></div>
   </div>
diff --git a/share/html/Elements/ShowRecord b/share/html/Elements/ShowRecord
index 3351f3b01..4b2bbb763 100644
--- a/share/html/Elements/ShowRecord
+++ b/share/html/Elements/ShowRecord
@@ -93,7 +93,7 @@ for my $column (@columns) {
     }
     @out = grep { defined $_ and length $_ } @out;
 </%perl>
-<div class="value col-md-9"><span class="form-control current-value"><% join('', at out) |n %></span></div>
+<div class="value col-md-9"><span class="current-value"><% join('', at out) |n %></span></div>
 % $m->callback(CallbackName => 'AfterValue', Object => $Object, attribute => $attr, column => $column );
 </div>
 % }
diff --git a/share/html/Prefs/Elements/ShowAboutMe b/share/html/Prefs/Elements/ShowAboutMe
index fe89e4460..7657b6a33 100644
--- a/share/html/Prefs/Elements/ShowAboutMe
+++ b/share/html/Prefs/Elements/ShowAboutMe
@@ -56,7 +56,7 @@
           <&|/l&>Email</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->EmailAddress%></span>
+          <span class="current-value"><%$UserObj->EmailAddress%></span>
         </div>
       </div>
 
@@ -65,7 +65,7 @@
           <&|/l&>Real Name</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->RealName%></span>
+          <span class="current-value"><%$UserObj->RealName%></span>
         </div>
       </div>
 
@@ -74,7 +74,7 @@
           <&|/l&>Nickname</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->NickName || ''%></span>
+          <span class="current-value"><%$UserObj->NickName || ''%></span>
         </div>
       </div>
 
@@ -83,7 +83,7 @@
           <&|/l&>Language</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control">
+          <span class="current-value">
 % if ( $UserObj->Lang ) {
             <&|/l, $lang &>[_1]</&>
 % } else {
@@ -98,7 +98,7 @@
           <&|/l&>Timezone</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control">
+          <span class="current-value">
 % if ( $UserObj->Timezone ) {
             <%$UserObj->Timezone%>
 % } else {
@@ -120,7 +120,7 @@
           <&|/l&>Residence</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->HomePhone || ''%></span>
+          <span class="current-value"><%$UserObj->HomePhone || ''%></span>
         </div>
       </div>
 
@@ -129,7 +129,7 @@
           <&|/l&>Work</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->WorkPhone || ''%></span>
+          <span class="current-value"><%$UserObj->WorkPhone || ''%></span>
         </div>
       </div>
 
@@ -138,7 +138,7 @@
           <&|/l&>Mobile</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->MobilePhone || ''%></span>
+          <span class="current-value"><%$UserObj->MobilePhone || ''%></span>
         </div>
       </div>
 
@@ -147,7 +147,7 @@
           <&|/l&>Pager</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->PagerPhone || ''%></span>
+          <span class="current-value"><%$UserObj->PagerPhone || ''%></span>
         </div>
       </div>
 
@@ -168,7 +168,7 @@
           <&|/l&>Organization</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->Organization || ''%></span>
+          <span class="current-value"><%$UserObj->Organization || ''%></span>
         </div>
       </div>
 
@@ -177,7 +177,7 @@
           <&|/l&>Address1</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->Address1 || ''%></span>
+          <span class="current-value"><%$UserObj->Address1 || ''%></span>
         </div>
       </div>
 
@@ -186,7 +186,7 @@
           <&|/l&>Address2</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->Address2 || ''%></span>
+          <span class="current-value"><%$UserObj->Address2 || ''%></span>
         </div>
       </div>
 
@@ -195,7 +195,7 @@
           <&|/l&>City</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->City || ''%></span>
+          <span class="current-value"><%$UserObj->City || ''%></span>
         </div>
       </div>
 
@@ -204,7 +204,7 @@
           <&|/l&>State</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->State || ''%></span>
+          <span class="current-value"><%$UserObj->State || ''%></span>
         </div>
       </div>
 
@@ -213,7 +213,7 @@
           <&|/l&>Zip</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->Zip || ''%></span>
+          <span class="current-value"><%$UserObj->Zip || ''%></span>
         </div>
       </div>
 
@@ -222,7 +222,7 @@
           <&|/l&>Country</&>:
         </div>
         <div class="col-md-9 value">
-          <span class="current-value form-control"><%$UserObj->Country || ''%></span>
+          <span class="current-value"><%$UserObj->Country || ''%></span>
         </div>
       </div>
 
diff --git a/share/html/Ticket/Elements/ShowBasics b/share/html/Ticket/Elements/ShowBasics
index 36206a6e4..46c68a12b 100644
--- a/share/html/Ticket/Elements/ShowBasics
+++ b/share/html/Ticket/Elements/ShowBasics
@@ -48,44 +48,44 @@
 <div>
   <div class="id form-row">
     <div class="label col-md-3"><&|/l&>Id</&>:</div>
-    <div class="value col-md-9"><span class="current-value form-control"><%$Ticket->Id %></span></div>
+    <div class="value col-md-9"><span><%$Ticket->Id %></span></div>
   </div>
   <div class="status form-row">
     <div class="label col-md-3"><&|/l&>Status</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><% loc($Ticket->Status) %></span></div>
+    <div class="value col-md-9"><span class="current-value"><% loc($Ticket->Status) %></span></div>
   </div>
 % if ( !$Ticket->QueueObj->SLADisabled ) {
   <div class="sla form-row">
     <div class="label col-md-3"><&|/l&>SLA</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><% loc($Ticket->SLA) %></span></div>
+    <div class="value col-md-9"><span class="current-value"><% loc($Ticket->SLA) %></span></div>
   </div>
 % }
 % my $totalTimeWorked = 0;
 % if (RT->Config->Get('DisplayTotalTimeWorked') && ($totalTimeWorked = $Ticket->TotalTimeWorked)) {
   <div class="total time worked sum form-row">
     <div class="label col-md-3"><&|/l&>Total Time Worked</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowTime, minutes => $totalTimeWorked &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowTime, minutes => $totalTimeWorked &></span></div>
   </div>
 % }
 % if ($show_time_worked) {
 % if ($Ticket->TimeEstimated) {
   <div class="time estimated form-row">
     <div class="label col-md-3"><&|/l&>Estimated</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowTime, minutes => $Ticket->TimeEstimated &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowTime, minutes => $Ticket->TimeEstimated &></span></div>
   </div>
 % }
 % $m->callback( %ARGS, CallbackName => 'AfterTimeEstimated', TicketObj => $Ticket );
 % if ($Ticket->TimeWorked) {
   <div class="time worked sum form-row">
     <div class="label col-md-3"><&|/l&>Worked</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowTime, minutes => $Ticket->TimeWorked &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowTime, minutes => $Ticket->TimeWorked &></span></div>
   </div>
 % }
 % if ( keys %$time_worked ) {
 <div class="time worked by-user form-row">
   <div class="label col-md-3"><&|/l&>Users</&>:</div>
   <div class="value col-md-9">
-    <span class="form-control current-value">
+    <span class="current-value">
 %   for my $user ( keys %$time_worked ) {
       <div>
         <span class="value"><% $user %>:</span>
@@ -100,21 +100,21 @@
 % if ($Ticket->TimeLeft) {
   <div class="time left form-row">
     <div class="label col-md-3"><&|/l&>Left</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowTime, minutes => $Ticket->TimeLeft &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowTime, minutes => $Ticket->TimeLeft &></span></div>
   </div>
 % }
 % }
 % $m->callback( %ARGS, CallbackName => 'AfterTimeLeft', TicketObj => $Ticket );
   <div class="priority form-row">
     <div class="label col-md-3"><&|/l&>Priority</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowPriority, Ticket => $Ticket &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowPriority, Ticket => $Ticket &></span></div>
   </div>
 % $m->callback( %ARGS, CallbackName => 'AfterPriority', TicketObj => $Ticket );
 %# This will check SeeQueue at the ticket role level, queue level, and global level
 % if ($Ticket->CurrentUserHasRight('SeeQueue')) {
   <div class="queue form-row">
     <div class="label col-md-3"><&|/l&>Queue</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowQueue, Ticket => $Ticket, QueueObj => $Ticket->QueueObj &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowQueue, Ticket => $Ticket, QueueObj => $Ticket->QueueObj &></span></div>
   </div>
 % }
 % $m->callback( %ARGS, CallbackName => 'AfterQueue', TicketObj => $Ticket );
diff --git a/share/html/Ticket/Elements/ShowDates b/share/html/Ticket/Elements/ShowDates
index 7f9dc7ddd..1823413bc 100644
--- a/share/html/Ticket/Elements/ShowDates
+++ b/share/html/Ticket/Elements/ShowDates
@@ -48,17 +48,17 @@
 <div>
   <div class="date form-row created">
     <div class="label col-md-3"><&|/l&>Created</&>:</div>\
-    <div class="value col-md-9"><span class="form-control current-value"><% $Ticket->CreatedObj->AsString %></span></div>
+    <div class="value col-md-9"><span class="current-value"><% $Ticket->CreatedObj->AsString %></span></div>
   </div>
 % $m->callback( %ARGS, CallbackName => 'AfterCreated', TicketObj => $Ticket );
   <div class="date form-row starts<% $Ticket->StartsObj->Unix ? q{} : q{ unset-field}%>">
     <div class="label col-md-3"><&|/l&>Starts</&>:</div>\
-    <div class="value col-md-9"><span class="form-control current-value"><% $Ticket->StartsObj->AsString %></span></div>
+    <div class="value col-md-9"><span class="current-value"><% $Ticket->StartsObj->AsString %></span></div>
   </div>
 % $m->callback( %ARGS, CallbackName => 'AfterStarts', TicketObj => $Ticket );
   <div class="date form-row started<% $Ticket->StartedObj->Unix ? q{} : q{ unset-field}%>">
     <div class="label col-md-3"><&|/l&>Started</&>:</div>\
-    <div class="value col-md-9"><span class="form-control current-value"><% $Ticket->StartedObj->AsString %></span></div>
+    <div class="value col-md-9"><span class="current-value"><% $Ticket->StartedObj->AsString %></span></div>
   </div>
 % $m->callback( %ARGS, CallbackName => 'AfterStarted', TicketObj => $Ticket );
   <div class="date form-row told<% $Ticket->ToldObj->Unix || $Ticket->CurrentUserHasRight('ModifyTicket') ? q{} : q{ unset-field}%>">
@@ -68,7 +68,7 @@
 % } else {
 <&|/l&>Last Contact</&>:
 % }
-</div><div class="value col-md-9"><span class="form-control current-value"><% $Ticket->ToldObj->AsString %></span></div>
+</div><div class="value col-md-9"><span class="current-value"><% $Ticket->ToldObj->AsString %></span></div>
   </div>
 % $m->callback( %ARGS, CallbackName => 'AfterTold', TicketObj => $Ticket );
 
@@ -76,16 +76,16 @@
     <div class="label col-md-3"><&|/l&>Due</&>:</div>\
 % my $due = $Ticket->DueObj;
 % if ( $due && $due->IsSet && $due->Diff < 0 && $Ticket->QueueObj->IsActiveStatus($Ticket->Status) ) {
-    <div class="value col-md-9"><span class="form-control current-value"><span class="overdue"><% $due->AsString  %></span></div></span>
+    <div class="value col-md-9"><span class="current-value"><span class="overdue"><% $due->AsString  %></span></div></span>
 % } else {
-    <div class="value col-md-9"><span class="form-control current-value"><% $due->AsString  %></span></div>
+    <div class="value col-md-9"><span class="current-value"><% $due->AsString  %></span></div>
 % }
   </div>
 % $m->callback( %ARGS, CallbackName => 'AfterDue', TicketObj => $Ticket );
 
   <div class="date form-row resolved<% $Ticket->ResolvedObj->Unix ? q{} : q{ unset-field}%>">
     <div class="label col-md-3"><&|/l&>Closed</&>:</div>\
-    <div class="value col-md-9"><span class="form-control current-value"><% $Ticket->ResolvedObj->AsString  %></span></div>
+    <div class="value col-md-9"><span class="current-value"><% $Ticket->ResolvedObj->AsString  %></span></div>
   </div>
 % $m->callback( %ARGS, CallbackName => 'AfterResolved', TicketObj => $Ticket );
 
@@ -93,9 +93,9 @@
     <div class="label col-md-3"><&|/l&>Updated</&>:</div>\
 % my $UpdatedString = $Ticket->LastUpdated ? loc("[_1] by [_2]", $Ticket->LastUpdatedAsString, $m->scomp('/Elements/ShowUser', User => $Ticket->LastUpdatedByObj)) : loc("Never");
 % if ($UpdatedLink) {
-    <div class="value col-md-9"><span class="form-control current-value"><a href="<% $UpdatedLink %>"><% $UpdatedString | n %></a></span></div>
+    <div class="value col-md-9"><span class="current-value"><a href="<% $UpdatedLink %>"><% $UpdatedString | n %></a></span></div>
 % } else {
-    <div class="value col-md-9"><span class="form-control current-value"><% $UpdatedString | n %></span></div>
+    <div class="value col-md-9"><span class="current-value"><% $UpdatedString | n %></span></div>
 % }
   </div>
 % $m->callback( %ARGS, CallbackName => 'AfterUpdated', TicketObj => $Ticket );
diff --git a/share/html/Ticket/Elements/ShowPeople b/share/html/Ticket/Elements/ShowPeople
index 97a033ba6..e9fe45a89 100644
--- a/share/html/Ticket/Elements/ShowPeople
+++ b/share/html/Ticket/Elements/ShowPeople
@@ -49,7 +49,7 @@
   <div class="form-row owner">
     <div class="label col-md-3"><&|/l&>Owner</&>:</div>
 % my $owner = $Ticket->OwnerObj;
-    <div class="value col-md-9"><span class="form-control current-value"><& /Elements/ShowUser, User => $owner, Ticket => $Ticket &>
+    <div class="value col-md-9"><span class="current-value"><& /Elements/ShowUser, User => $owner, Ticket => $Ticket &>
     <& /Elements/ShowUserEmailFrequency, User => $owner, Ticket => $Ticket &>
 % $m->callback( User => $owner, Ticket => $Ticket, %ARGS, CallbackName => 'AboutThisUser' );
     </span></div>
@@ -69,21 +69,21 @@
 %     my $user = $users->First || RT->Nobody;
   <div class="form-row">
     <div class="label col-md-3"><% $role->Name %>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& /Elements/ShowUser, User => $user, Ticket => $Ticket &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& /Elements/ShowUser, User => $user, Ticket => $Ticket &></span></div>
   </div>
 % }
 
   <div class="form-row requestors">
     <div class="label col-md-3"><&|/l&>Requestors</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowGroupMembers, Group => $Ticket->Requestors, Ticket => $Ticket &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowGroupMembers, Group => $Ticket->Requestors, Ticket => $Ticket &></span></div>
   </div>
   <div class="form-row cc<% $Ticket->Cc->MembersObj->Count ? q{} : q{ unset-field}%>">
     <div class="label col-md-3"><&|/l&>Cc</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowGroupMembers, Group => $Ticket->Cc, Ticket => $Ticket &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowGroupMembers, Group => $Ticket->Cc, Ticket => $Ticket &></span></div>
   </div>
   <div class="form-row admincc<% $Ticket->AdminCc->MembersObj->Count ? q{} : q{ unset-field}%>">
     <div class="label col-md-3"><&|/l&>AdminCc</&>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowGroupMembers, Group => $Ticket->AdminCc, Ticket => $Ticket &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowGroupMembers, Group => $Ticket->AdminCc, Ticket => $Ticket &></span></div>
   </div>
 
 % my $multi_roles = $Ticket->QueueObj->CustomRoles;
@@ -92,7 +92,7 @@
 % while (my $role = $multi_roles->Next) {
   <div class="form-row">
     <div class="label col-md-3"><% $role->Name %>:</div>
-    <div class="value col-md-9"><span class="form-control current-value"><& ShowGroupMembers, Group => $Ticket->RoleGroup($role->GroupType), Ticket => $Ticket &></span></div>
+    <div class="value col-md-9"><span class="current-value"><& ShowGroupMembers, Group => $Ticket->RoleGroup($role->GroupType), Ticket => $Ticket &></span></div>
   </div>
 % }
 
diff --git a/share/html/Ticket/Elements/ShowRequestor b/share/html/Ticket/Elements/ShowRequestor
index cae6b492f..33fdc16de 100644
--- a/share/html/Ticket/Elements/ShowRequestor
+++ b/share/html/Ticket/Elements/ShowRequestor
@@ -76,7 +76,7 @@
 % if ( $ShowComments ) {
 <div class="comments-about-user">
   <div class="label col-md-3"><&|/l&>Comments about this user</&>:</div>
-  <div class="value col-md-9"><span class="form-control current-value"><% ($requestor->Comments || loc("No comment entered about this user")) %></span></div>
+  <div class="value col-md-9"><span class="current-value"><% ($requestor->Comments || loc("No comment entered about this user")) %></span></div>
 </div>
 % }
 
@@ -124,7 +124,7 @@
   [<a href=<% RT->Config->Get('WebPath') . '/Admin/Users/Memberships.html?id=' . $requestor->id %> ><&|/l&>Edit</&></a>]
 % }
   </div>
-  <div class="value col-md-9"><span class="form-control current-value"><& /Elements/ShowMemberships, UserObj => $requestor, Limit => $grouplimit &></span></div>
+  <div class="value col-md-9"><span class="current-value"><& /Elements/ShowMemberships, UserObj => $requestor, Limit => $grouplimit &></span></div>
 </div>
 % }
 

commit 80e88faecf839a14d0a3d911657c2488d20622b2
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Sep 26 04:23:19 2019 +0800

    Tweak vertical position for .current-value.form-control
    
    It's wrong to set margin-top for the 1px input border because related
    texts are always shown in the vertical middle here, and input border
    doesn't affect that.

diff --git a/share/static/css/elevator-light/forms.css b/share/static/css/elevator-light/forms.css
index 69033757b..8218972bb 100644
--- a/share/static/css/elevator-light/forms.css
+++ b/share/static/css/elevator-light/forms.css
@@ -314,7 +314,6 @@ button {
 span.current-value.form-control {
   border: none;
   padding-left: 0;
-  margin-top: 1px; /* because input box border is 1px */
 }
 
 .list-group-item label {

commit 88327da1e44bb6333aabd5dbed0d2ba1fbdb0618
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Sep 26 05:11:39 2019 +0800

    Horizontally align "label" and "value > ul" pair in forms

diff --git a/share/static/css/elevator-light/forms.css b/share/static/css/elevator-light/forms.css
index 8218972bb..5a4d69947 100644
--- a/share/static/css/elevator-light/forms.css
+++ b/share/static/css/elevator-light/forms.css
@@ -341,10 +341,15 @@ span.current-value.form-control {
   line-height: 1;
 }
 
-form .label {
+form .label,
+form .value > .list-group {
   padding-top: 5px;
 }
 
+form .value > .list-group > .list-group-item:first-child {
+  padding-top: 0;
+}
+
 .btn {
   font-weight: 500;
 }

-----------------------------------------------------------------------


More information about the rt-commit mailing list