[Rt-commit] rt branch, 5.0/move-rt-extension-formattedtransactions-to-core, updated. rt-5.0.0-6-gffb8b0c1c6

[Dianne Skoll]

The branch, 5.0/move-rt-extension-formattedtransactions-to-core has been updated
       via  ffb8b0c1c6b4f13012782de30dd351875b07704b (commit)
      from  4f3893e7b617367bbb65cdac799644dc9ddb990b (commit)

Summary of changes:
 share/html/Elements/ShowTransaction | 41 ++++++++++++++++++-------------------
 share/static/js/util.js             |  2 +-
 2 files changed, 21 insertions(+), 22 deletions(-)

- Log -----------------------------------------------------------------
commit ffb8b0c1c6b4f13012782de30dd351875b07704b
Author: Dianne Skoll <dianne at bestpractical.com>
Date:   Wed Aug 12 10:34:59 2020 -0400

    Update HTML to use table-less layout for RT5.

diff --git a/share/html/Elements/ShowTransaction b/share/html/Elements/ShowTransaction
index e509fc8a8b..16ed228ad4 100644
--- a/share/html/Elements/ShowTransaction
+++ b/share/html/Elements/ShowTransaction
@@ -96,32 +96,31 @@ $m->comp(
 %        $new = $m->comp('/Elements/ScrubHTML', Content => $new);
 %        $new =~ s|\n|<br />|g;
 <div class="details hidden" id="txn-<% $Transaction->Id %>-details">
-  <table>
 % if ( $old eq loc('(no value)')  ) {
-    <tr>
-      <td class="label"><% loc('Added') %>:</td>
-      <td class="value"><% $new |n %></td>
-    </tr>
+  <div class="form-row">
+      <div class="label col-2"><% loc('Added') %>:</div>
+      <div class="value col-10"><% $new |n %></div>
+  </div>
 % }
 % elsif ( $new eq loc('(no value)')  ) {
-    <tr>
-      <td class="label"><% loc('Deleted') %>:</td>
-      <td class="value"><% $old |n %></td>
-    </tr>
+    <div class="form-row">
+      <div class="label col-2"><% loc('Deleted') %>:</div>
+      <div class="value col-10"><% $old |n %></div>
+    </div>
 % }
 % else {
-    <tr>
-      <td class="label"><% loc('From') %>:</td>
-      <td class="value" ><% $old |n %></td>
-    </tr>
-    <tr>
-      <td class="label"><% loc('To') %>:</td>
-      <td class="value"><% $new |n %></td>
-    </tr>
-    <tr class="diff">
-      <td class="label"><% loc('Changes') %>:</td>
-      <td class="value"><% loc('Loading...') %></td>
-    </tr>
+    <div class="form-row">
+      <div class="label col-2"><% loc('From') %>:</div>
+      <div class="value col-10"><% $old |n %></div>
+    </div>
+    <div class="form-row">
+      <div class="label col-2"><% loc('To') %>:</div>
+      <div class="value col-10"><% $new |n %></div>
+    </div>
+    <div class="form-row diff">
+      <div class="label col-2"><% loc('Changes') %>:</div>
+      <div class="value col-10"><% loc('Loading...') %></div>
+    </div>
 % }
   </table>
 </div>
diff --git a/share/static/js/util.js b/share/static/js/util.js
index 3e67be520a..914937af54 100644
--- a/share/static/js/util.js
+++ b/share/static/js/util.js
@@ -1093,7 +1093,7 @@ function toggleTransactionDetails () {
         jQuery(this).text(RT.I18N.Catalog['show_details']);
     }
 
-    var diff = details_div.find('.diff td.value');
+    var diff = details_div.find('.diff div.value');
     if (!diff.children().length) {
         diff.load(RT.Config.WebHomePath + '/Helpers/TextDiff', {
             TransactionId: txn_div.attr('data-transaction-id')

-----------------------------------------------------------------------