[Rt-commit] rt branch, 5.0/fix-radio-and-checkbox-for-inline-edit-click, created. rt-5.0.0-4-g4e9be8a391

? sunnavy sunnavy at bestpractical.com
Thu Aug 13 14:41:00 EDT 2020


The branch, 5.0/fix-radio-and-checkbox-for-inline-edit-click has been created
        at  4e9be8a391a75e68d137ed58072ed75c82d1b185 (commit)

- Log -----------------------------------------------------------------
commit 4e9be8a391a75e68d137ed58072ed75c82d1b185
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 14 02:18:31 2020 +0800

    Fix radio/checkbox inputs for "click" panel behavior of inline edit
    
    Previously these inputs were wrongly intercepted by inline edit and
    couldn't be actually checked.

diff --git a/share/static/js/util.js b/share/static/js/util.js
index 34dd5ec92f..5ad1b93002 100644
--- a/share/static/js/util.js
+++ b/share/static/js/util.js
@@ -964,6 +964,11 @@ jQuery(function () {
             return;
         }
 
+        // Bypass radio/checkbox controls too
+        if (jQuery(e.target).closest('div.custom-radio, div.custom-checkbox').length) {
+            return;
+        }
+
         e.preventDefault();
         var container = jQuery(this).closest('.titlebox');
         if (container.hasClass('editing')) {

-----------------------------------------------------------------------


More information about the rt-commit mailing list