[Rt-commit] rt branch, 5.0/jumbo-update-bootstrap-alignment, updated. rt-5.0.0-7-g98f5714d05

[Aaron Trevena]

The branch, 5.0/jumbo-update-bootstrap-alignment has been updated
       via  98f5714d052424b879778e630e4a826214a58742 (commit)
      from  1b4b953a5f68e6cf9da544691a0d305bdc61b93d (commit)

Summary of changes:
 share/html/Ticket/Elements/EditBasics |  7 +++++--
 share/html/Ticket/ModifyAll.html      | 13 ++++++++++---
 2 files changed, 15 insertions(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit 98f5714d052424b879778e630e4a826214a58742
Author: Aaron Trevena <ast at bestpractical.com>
Date:   Wed Aug 19 15:30:04 2020 +0100

    Update basic update field spacing in jumbo page
    
    Update basic update and message/attachment field layout to be consistent
    with other bootstrap styling of other forms.

diff --git a/share/html/Ticket/Elements/EditBasics b/share/html/Ticket/Elements/EditBasics
index ec276020e0..18c7a57167 100644
--- a/share/html/Ticket/Elements/EditBasics
+++ b/share/html/Ticket/Elements/EditBasics
@@ -50,6 +50,9 @@ $TicketObj => undef
 $QueueObj => undef
 @fields => ()
 $InTable => 0
+$LabelCols => 3
+$ValueCols => 9
+
 %defaults => ()
 $ExcludeCustomRoles => 0
 $ExcludeOwner => 0
@@ -186,12 +189,12 @@ for my $field (@fields) {
 % for my $field (@fields) {
 %# Prefer input name as css class, e.g. "FinalPriority" instead of "Final_Priority"
   <div class="form-row <% CSSClass( $field->{args}{Name} || $field->{'name'} ) %>">
-    <div class="label col-3"><% loc($field->{'name'}) %>:
+    <div class="label col-<% $LabelCols %>"><% loc($field->{'name'}) %>:
 %   if ( my $hint = $field->{hint} ) {
       <span class="far fa-question-circle icon-helper" data-toggle="tooltip" data-placement="top" data-original-title="<% $hint %>"></span>
 %   }
     </div>
-    <div class="value col-9"><% $field->{'html'} |n %></div>
+    <div class="value col-<% $ValueCols %>"><% $field->{'html'} |n %></div>
   </div>
 % }
 % $m->callback( CallbackName => 'EndOfList', TicketObj => $TicketObj, %ARGS, Fields => \@fields );
diff --git a/share/html/Ticket/ModifyAll.html b/share/html/Ticket/ModifyAll.html
index ed44378c5b..fae48a25df 100644
--- a/share/html/Ticket/ModifyAll.html
+++ b/share/html/Ticket/ModifyAll.html
@@ -59,7 +59,14 @@
 
 <&| /Widgets/TitleBox, title => loc('Modify ticket # [_1]', $Ticket->Id), class=>'ticket-info-basics' &>
 <div>
-<& Elements/EditBasics, TicketObj => $Ticket, defaults => \%ARGS, ExcludeCustomRoles => 1, InTable => 1 &>
+  <& Elements/EditBasics,
+    TicketObj => $Ticket,
+    defaults  => \%ARGS,
+    ExcludeCustomRoles => 1,
+    InTable   => 1,
+    LabelCols => 2,
+    ValueCols => 8,
+&>
 <& /Elements/EditCustomFields, Object => $Ticket, Grouping => 'Basics', InTable => 1 &>
 </div>
 </&>
@@ -88,7 +95,7 @@
 <&| /Widgets/TitleBox, title => loc('Update ticket'), class => 'messagedetails' &>
   <div class="form-row input-row">
     <div class="label col-2"><&|/l&>Update Type</&>:</div>
-    <div class="value col-9">
+    <div class="value col-8">
       <select name="UpdateType" id="UpdateType" class="form-control selectpicker">
 % if ($CanComment) {
         <option value="private" ><&|/l&>Comments (Not sent to requestors)</&></option>
@@ -102,7 +109,7 @@
   </div>
   <div class="form-row input-row">
     <div class="label col-2"><&|/l&>Subject</&>:</div>
-    <div class="value col-9"><input class="form-control" type="text" name="UpdateSubject" value="<%$Ticket->Subject%>" />
+    <div class="value col-8"><input class="form-control" type="text" name="UpdateSubject" value="<%$Ticket->Subject%>" />
 % $m->callback( %ARGS, CallbackName => 'AfterSubject' );
     </div>
   </div>

-----------------------------------------------------------------------