[Rt-commit] rt branch, 5.0/fix-saved-search-component, repushed

[Aaron Trevena]

The branch 5.0/fix-saved-search-component was deleted and repushed:
       was 186d637ebc601de19b42d889dfb2e85b6a260632
       now 07db819940a3b460f2a4df05836b3a9d77dcd8df

1: 186d637ebc ! 1: 07db819940 Add ColumnMapClassName method to RT::SharedSetting
    @@ -1,14 +1,19 @@
     Author: Aaron Trevena <ast at bestpractical.com>
     
    -    Add ColumnMapClassName method to RT::SharedSetting/ShareSettings
    +    Add ColumnMapClassName method to RT::SharedSetting
         
    -    Allow SavedSearch and other SharedSetting Classes with ColumnMaps
    -    to be usable in CollectionList. Updated RT::Dashboards to use inherited
    -    new method.
    +    Addresses a bug causing a fatal error in the SavedSearch dashboard component:
    +    Can't locate object method "ColumnMapClassName" via package "RT::SavedSearch"
         
    -    Addresses a bug introduced in 5.0 commit f6cdaf8c11f252fd3e31ee85c8f8db7ad4fbbfe8
    -    that causes a fatal error in the SavedSearch component:
    -    Can't locate object method "ColumnMapClassName" via package "RT::SavedSearch"
    +    Commit f6cdaf8c11f252fd3e31ee85c8f8db7ad4fbbfe8 added support for multiple
    +    types of RT::Record to the querybuilder in addition to tickets, using the
    +    ColumnMapClassName method. SharedSetting sub-classes aren't simple records
    +    and so didn't have this method resulting in an error when used in dashboard
    +    component searches.
    +    
    +    Adding the ColumnMapClassName method to the RT::SharedSetting base class
    +    allows objects inheriting from it to work in the same way as RT::Record based
    +    objects, and makes any method providing a hardcoded classname un-necessary.
         
         Fixes: I#36605