[Rt-commit] rt branch, 5.0/fix-queue-header-approval-display, created. rt-5.0.0-135-g8c84bbe9cb

Craig Kaiser craig at bestpractical.com
Mon Dec 14 09:48:57 EST 2020


The branch, 5.0/fix-queue-header-approval-display has been created
        at  8c84bbe9cb94db9055003ad72bdf9f087ef5d29d (commit)

- Log -----------------------------------------------------------------
commit 8c84bbe9cb94db9055003ad72bdf9f087ef5d29d
Author: craig kaiser <craig at bestpractical.com>
Date:   Mon Dec 14 09:30:12 2020 -0500

    Fix queue label on approval display page
    
    Fixes I#37013

diff --git a/share/html/Approvals/Elements/ShowDependency b/share/html/Approvals/Elements/ShowDependency
index 60c219b1a9..4033da34b1 100644
--- a/share/html/Approvals/Elements/ShowDependency
+++ b/share/html/Approvals/Elements/ShowDependency
@@ -54,7 +54,7 @@
 my %show;
 while (my $link = $approving->Next()) {
     next unless ($link->BaseURI->IsLocal());
-    my $text = '<a name="' . $link->BaseObj->Id . '">';
+    my $text = '';
     my $head = '';
     my $type = $link->BaseObj->Type;
     my $dep  = $m->scomp('ShowDependency', Ticket => $link->BaseObj, _seen => $_seen);
@@ -76,8 +76,7 @@ while (my $link = $approving->Next()) {
 
     $head .= $m->scomp('/Widgets/TitleBoxEnd');
     $text .= $m->scomp('/Widgets/TitleBoxEnd');
-    $text .= $dep;
-    $text .= '</a>';
+    $text .= $dep if $dep;
     $show{$link->BaseObj->Id} = {
         text => $text,
         head => $head,

-----------------------------------------------------------------------


More information about the rt-commit mailing list