[Rt-commit] rt branch, 5.0/limit-self-service-page-components-to-sensible-defaults, repushed

Jim Brandt jbrandt at bestpractical.com
Mon Dec 21 16:35:20 EST 2020


The branch 5.0/limit-self-service-page-components-to-sensible-defaults was deleted and repushed:
       was 013fb3adb3ac0074ffed37c03fd3d5780aacf04f
       now 4719c8b0a15defa29c9c6901bb14e68728714171

1: 3f0135d888 ! 1: 4719c8b0a1 Default $SelfServicePageComponents to an empty list, not HomepageComponents
    @@ -1,9 +1,10 @@
     Author: Dianne Skoll <dianne at bestpractical.com>
     
    -    Default $SelfServicePageComponents to [qw(QuickCreate RefreshHomepage)]
    +    Default $SelfServicePageComponents to an empty list, not HomepageComponents
         
    -    If $SelfServicePageComponents is not set at all, default it to the empty
    -    list rather than to $HomepageComponents
    +    HomepageComponents are a set of portlets for privileged users and as
    +    such can't be used by most self service users because of access
    +    restrictions.
     
     diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
     --- a/etc/RT_Config.pm.in
    @@ -13,17 +14,8 @@
      C<$SelfServicePageComponents> is an arrayref of allowed components on
      the SelfService page, if you have set $SelfServiceUseDashboard to true.
     -If this is not set at all, then $HomepageComponents is used instead.
    -+If this is not set at all, then it's equivalent to no allowed components.
      
      =cut
    - 
    - Set(
    -     $SelfServicePageComponents,
    -     [
    --        qw(QuickCreate QueueList MyAdminQueues MySupportQueues MyReminders RefreshHomepage Dashboards SavedSearches FindUser MyAssets FindAsset FindGroup) # loc_qw
    -+        qw(QuickCreate RefreshHomepage) # loc_qw
    -     ]
    - );
      
     
     diff --git a/share/html/Dashboards/Elements/ShowPortlet/component b/share/html/Dashboards/Elements/ShowPortlet/component
    @@ -51,4 +43,3 @@
      } else {
          @components = map { type => "component", name => $_, label => loc($_) }, @{RT->Config->Get('HomepageComponents')};
      }
    -
2: 013fb3adb3 < -:  ------- The standard QuickCreate widget is not appropriate for the self-service page.



More information about the rt-commit mailing list