[Rt-commit] rt branch, 5.0/round-2-updates-for-mobile, updated. rt-5.0.0-175-ga02b01826f

Blaine Motsinger blaine at bestpractical.com
Wed Dec 30 18:22:58 EST 2020


The branch, 5.0/round-2-updates-for-mobile has been updated
       via  a02b01826fcc80c07143d093d5493eea23343b80 (commit)
      from  e6a41c8759ce8a03b2c45ab55e9e5eb35d247fe9 (commit)

Summary of changes:
 share/html/Asset/Elements/AssetSearchBasics | 42 ++++++++++++++---------------
 share/html/Asset/Elements/AssetSearchPeople | 16 +++++------
 2 files changed, 29 insertions(+), 29 deletions(-)

- Log -----------------------------------------------------------------
commit a02b01826fcc80c07143d093d5493eea23343b80
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Wed Dec 30 17:17:39 2020 -0600

    Update asset simple search for single col layout
    
    On mobile layout and smaller window sizes, the asset simple search
    page was not correctly flowing to a single column layout.  This
    commit updates the col definitions for the rows to expand to full
    when smaller window sizes, and half once reaching medium or higher.

diff --git a/share/html/Asset/Elements/AssetSearchBasics b/share/html/Asset/Elements/AssetSearchBasics
index 2c40b85df0..b0a87eb58f 100644
--- a/share/html/Asset/Elements/AssetSearchBasics
+++ b/share/html/Asset/Elements/AssetSearchBasics
@@ -47,10 +47,10 @@
 %# END BPS TAGGED BLOCK }}}
 <&| /Widgets/TitleBox, title => loc('Basics'), class=>'asset-search-grouping asset-search-basics' &>
   <div class="form-row">
-    <div class="col-6">
+    <div class="col-12 col-md-6">
       <div class="form-row">
-        <div class="label col-3"><&|/l&>Catalog</&></div>
-        <div class="value col-9">
+        <div class="label col-3 col-md-2"><&|/l&>Catalog</&></div>
+        <div class="value col-9 col-md-4">
           <& /Asset/Elements/SelectCatalog, Name => 'Catalog', CheckRight => "ShowCatalog",
             Default => $ARGS{'Catalog'}, OnChange => "jQuery('#AssetSearch').submit()"
           &>
@@ -58,10 +58,10 @@
       </div>
     </div>
 
-    <div class="col-6">
+    <div class="col-12 col-md-6">
       <div class="form-row">
-        <div class="label col-3"><&|/l&>Status</&></div>
-        <div class="value col-9">
+        <div class="label col-3 col-md-2"><&|/l&>Status</&></div>
+        <div class="value col-9 col-md-4">
           <& /Asset/Elements/SelectStatus, Name => 'Status', Catalogs => { $CatalogObj->id => 1 }, DefaultValue => 1,
             Default => ($ARGS{'Status'} || '')
           &>
@@ -71,27 +71,27 @@
   </div>
 
   <div class="form-row">
-    <div class="col-6">
+    <div class="col-12 col-md-6">
       <div class="form-row">
-        <div class="label col-2"><&|/l&>Name</&></div>
-        <div class="value col-4">
+        <div class="label col-3 col-md-2"><&|/l&>Name</&></div>
+        <div class="value col-9 col-md-4">
           <input class="form-control" type="text" id="Name" name="Name" value="<% $ARGS{Name} || ''%>" />
         </div>
-        <div class="label col-2"><&|/l&>not</&></div>
-        <div class="value col-4">
+        <div class="label col-3 col-md-2"><&|/l&>not</&></div>
+        <div class="value col-9 col-md-4">
           <input class="form-control" type="text" id="!Name" name="!Name" value="<% $ARGS{"!Name"} || ''%>" />
         </div>
       </div>
     </div>
 
-    <div class="col-6">
+    <div class="col-12 col-md-6">
       <div class="form-row">
-        <div class="label col-2"><&|/l&>Description</&></div>
-        <div class="value col-4">
+        <div class="label col-3 col-md-2"><&|/l&>Description</&></div>
+        <div class="value col-9 col-md-4">
           <input class="form-control" type="text" id="Description" name="Description" value="<% $ARGS{Description} || ''%>" />
         </div>
-        <div class="label col-2"><&|/l&>not</&></div>
-        <div class="value col-4">
+        <div class="label col-3 col-md-2"><&|/l&>not</&></div>
+        <div class="value col-9 col-md-4">
           <input class="form-control" type="text" id="!Description" name="!Description" value="<% $ARGS{"!Description"} || ''%>" />
         </div>
       </div>
@@ -99,7 +99,7 @@
   </div>
 
   <div class="form-row">
-    <div class="col-12">
+    <div class="col-12 col-md-6">
 % my $CFs = RT::CustomFields->new( $session{CurrentUser} );
 % $CFs->LimitToCatalog( $CatalogObj->Id );
 % $CFs->LimitToObjectId(0); # LimitToGlobal but no LookupType restriction
@@ -109,16 +109,16 @@
 % my $value  = ref($ARGS{$name}) ? $ARGS{$name}[0] : $ARGS{$name} || '';
 % my $negval = ref($ARGS{"!$name"}) ? $ARGS{"!$name"}[0] : $ARGS{"!$name"} || '';
       <div class="form-row">
-        <div class="label col-2">
+        <div class="label col-3 col-md-2">
           <% $cf->Name %>
         </div>
-        <div class="value col-4">
+        <div class="value col-9 col-md-4">
           <& /Elements/SelectCustomFieldValue, CustomField => $cf, Name => $name, Default => $value &>
         </div>
-        <div class="label col-2">
+        <div class="label col-3 col-md-2">
           <&|/l&>not</&>
         </div>
-        <div class="value col-4">
+        <div class="value col-9 col-md-4">
           <& /Elements/SelectCustomFieldValue, CustomField => $cf, Name => "!$name", Default => $negval &>
         </div>
       </div>
diff --git a/share/html/Asset/Elements/AssetSearchPeople b/share/html/Asset/Elements/AssetSearchPeople
index 36c61ef018..ed596bab5f 100644
--- a/share/html/Asset/Elements/AssetSearchPeople
+++ b/share/html/Asset/Elements/AssetSearchPeople
@@ -48,18 +48,18 @@
 <&| /Widgets/TitleBox, class => "asset-search-people", title => loc('People') &>
 % for my $role (RT::Asset->Roles) {
   <div class="asset-role-<% CSSClass($role) %> form-row">
-    <div class="label col-2">
+    <div class="label col-3 col-md-2">
       <% loc($role) %>
     </div>
-    <div class="value col-4">
+    <div class="value col-9 col-md-4">
       <input class="form-control" type="text" id="Role.<% $role %>" name="Role.<% $role %>"
         data-autocomplete="Users" value="<% $ARGS{"Role.$role"} || '' %>"
       />
     </div>
-    <div class="label col-2">
+    <div class="label col-3 col-md-2">
       <&|/l&>not</&>
     </div>
-    <div class="value col-4">
+    <div class="value col-9 col-md-4">
       <input class="form-control" type="text" id="!Role.<% $role %>" name="!Role.<% $role %>"
         data-autocomplete="Users" value="<% $ARGS{"!Role.$role"} || '' %>"
       />
@@ -75,16 +75,16 @@
 % my $value  = ref($ARGS{$name}) ? $ARGS{$name}[0] : $ARGS{$name} || '';
 % my $negval = ref($ARGS{"!$name"}) ? $ARGS{"!$name"}[0] : $ARGS{"!$name"} || '';
   <div class="form-row">
-    <div class="label col-2">
+    <div class="label col-3 col-md-2">
       <% $cf->Name %>
     </div>
-    <div class="value col-4">
+    <div class="value col-9 col-md-4">
       <& /Elements/SelectCustomFieldValue, CustomField => $cf, Name => $name, Default => $value &>
     </div>
-    <div class="label col-2">
+    <div class="label col-3 col-md-2">
       <&|/l&>not</&>
     </div>
-    <div class="value col-4">
+    <div class="value col-9 col-md-4">
       <& /Elements/SelectCustomFieldValue, CustomField => $cf, Name => "!$name", Default => $negval &>
     </div>
   </div>

-----------------------------------------------------------------------


More information about the rt-commit mailing list