[Rt-commit] rt branch, 4.6/fix-inconsistent-ticket-display-spacing, created. rt-4.4.4-726-g3378247122

[Craig Kaiser]

The branch, 4.6/fix-inconsistent-ticket-display-spacing has been created
        at  33782471220e115088909f5e8ea1ba8f875371c0 (commit)

- Log -----------------------------------------------------------------
commit 8f04da7ba3aa983e1ab0695c2209d6e698e42a93
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Jan 27 08:15:30 2020 -0500

    Remove <br> tag between metadata and ticket history on display page

diff --git a/share/html/Ticket/Display.html b/share/html/Ticket/Display.html
index 5c2642b32d..1ad1d1c685 100644
--- a/share/html/Ticket/Display.html
+++ b/share/html/Ticket/Display.html
@@ -85,7 +85,6 @@ my $titleright = qq{
 <& /Ticket/Elements/ShowSummary,  Ticket => $TicketObj, Attachments => $attachments, InlineEdit => $InlineEdit &>
 </&>
 </div>
-<br />
 
 % $m->callback( Ticket => $TicketObj, %ARGS, Transactions => $transactions, Attachments => $attachments, CallbackName => 'BeforeShowHistory' );
 

commit 134b6e6b6749d77c2cb4dcd8b24f66ab584d0feb
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Jan 27 12:45:58 2020 -0500

    Remove individual padding rule for ticket elememts
    
    Having unqiue padding rules for only some ticket components leads to
    incorrect spacing.

diff --git a/share/static/css/elevator-light/ticket.css b/share/static/css/elevator-light/ticket.css
index 5bf0a1df7e..fb8464af8d 100644
--- a/share/static/css/elevator-light/ticket.css
+++ b/share/static/css/elevator-light/ticket.css
@@ -64,18 +64,6 @@
     font-style: normal;
 }
 
-.summary {
-    padding-top: .1em;
-}
-
-div#body .ticket-info-basics,
-div#body .ticket-info-people,
-div#body .ticket-info-dates,
-div#body .ticket-info-links,
-div#body .ticket-info-reminders {
-    padding-top: .1em;
-}
-
 .unread-messages .titlebox-content :link {
     text-decoration: underline;
 }

commit d0bf13b35ba43a9c7c3a12292af1c7fa8330f6bc
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Jan 27 12:59:57 2020 -0500

    Remove margin from bottom of titlebox
    
    Having a margin-bottom rule for titleboxes adds unwanted white-space
    at the bottom of a titleboxes and the next component. For example
    between the last titleboxe in the ticket summay div and the start of
    the ticket history div.

diff --git a/share/static/css/elevator-light/boxes.css b/share/static/css/elevator-light/boxes.css
index c334be6238..db1b535319 100644
--- a/share/static/css/elevator-light/boxes.css
+++ b/share/static/css/elevator-light/boxes.css
@@ -1,6 +1,5 @@
 .titlebox {
     margin-top: 1em;
-    margin-bottom: 2em;
     padding: 5px;
 }
 

commit 54cb5b918c27dadd493e26b26bf6e4fde33e6ba4
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Jan 27 13:13:20 2020 -0500

    Remove unecessary <br> tag from ticket History page

diff --git a/share/html/Ticket/History.html b/share/html/Ticket/History.html
index f617380d18..239d4e15f1 100644
--- a/share/html/Ticket/History.html
+++ b/share/html/Ticket/History.html
@@ -50,9 +50,6 @@
 
 % $m->callback( %ARGS, Ticket => $Ticket, CallbackName => 'BeforeActionList' );
 
-
-<br />
-      
 <& /Elements/ShowHistory,
     Object => $Ticket,
     ShowHeaders => $ARGS{'ShowHeaders'}, 

commit 103d4b930905524b4873e7c9c9653ca963872e51
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Jan 27 13:15:26 2020 -0500

    Remove uneeded <br> tags from Jumbo page

diff --git a/share/html/Ticket/ModifyAll.html b/share/html/Ticket/ModifyAll.html
index 0a2ce9cabd..b64aa2174c 100644
--- a/share/html/Ticket/ModifyAll.html
+++ b/share/html/Ticket/ModifyAll.html
@@ -72,27 +72,18 @@
 <& Elements/EditDates, TicketObj => $Ticket &>
 </&>
 
-<br />
-
-
 <&| /Widgets/TitleBox, title => loc('People'), class=>'ticket-info-people' &>
 <& Elements/EditPeople, Ticket => $Ticket, UserField => $UserField, UserString => $UserString, UserOp => $UserOp, GroupString => $GroupString, GroupOp => $GroupOp, GroupField => $GroupField &>
 </&>
 
-<br />
-
 <&| /Widgets/TitleBox, title => loc('Links'), class=>'ticket-info-links' &>
 <& /Elements/EditLinks, Object => $Ticket &>
 </&>
 
-<br />
-
 <&| /Widgets/TitleBox, title => loc('Merge'), class=>'ticket-info-merge' &>
 <& Elements/EditMerge, Ticket => $Ticket, %ARGS &>
 </&>
 
-<br />
-
 <&| /Widgets/TitleBox, title => loc('Update ticket'), class => 'messagedetails' &>
 <div>
   <div class="form-row input-row">

commit 33782471220e115088909f5e8ea1ba8f875371c0
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Thu Feb 6 08:56:21 2020 -0500

    Remove padding for smaller screen sizes

diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index 0b3c2aca91..6b6f9deab4 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -13,23 +13,6 @@ div#body {
     z-index: 1;
 }
 
- at media (max-width: 800px) {
-    div#body {
-        padding: 3em 4.875%; /* 3em at 13px font size => 39px => 39/800 => .04875 */
-    }
-    /* at narrow widths we'll have broken into a single column, so the default
-       padding-right just causes the layout to degrade */
-    .boxcontainer {
-        padding-right: 0;
-    }
-}
-
- at media (max-width: 700px) {
-    div#body {
-        padding: 3em 0;
-    }
-}
-
 div#footer {
     position: absolute;
     text-align: right;

-----------------------------------------------------------------------