[Rt-commit] rt branch, 4.6/fix-inconsistent-ticket-display-spacing, created. rt-4.4.4-728-g729d5d7f38
? sunnavy
sunnavy at bestpractical.com
Tue Feb 11 13:20:20 EST 2020
The branch, 4.6/fix-inconsistent-ticket-display-spacing has been created
at 729d5d7f389aace8989daa46ceeecfef90442383 (commit)
- Log -----------------------------------------------------------------
commit 8f04da7ba3aa983e1ab0695c2209d6e698e42a93
Author: Craig Kaiser <craig at bestpractical.com>
Date: Mon Jan 27 08:15:30 2020 -0500
Remove <br> tag between metadata and ticket history on display page
diff --git a/share/html/Ticket/Display.html b/share/html/Ticket/Display.html
index 5c2642b32d..1ad1d1c685 100644
--- a/share/html/Ticket/Display.html
+++ b/share/html/Ticket/Display.html
@@ -85,7 +85,6 @@ my $titleright = qq{
<& /Ticket/Elements/ShowSummary, Ticket => $TicketObj, Attachments => $attachments, InlineEdit => $InlineEdit &>
</&>
</div>
-<br />
% $m->callback( Ticket => $TicketObj, %ARGS, Transactions => $transactions, Attachments => $attachments, CallbackName => 'BeforeShowHistory' );
commit 134b6e6b6749d77c2cb4dcd8b24f66ab584d0feb
Author: Craig Kaiser <craig at bestpractical.com>
Date: Mon Jan 27 12:45:58 2020 -0500
Remove individual padding rule for ticket elememts
Having unqiue padding rules for only some ticket components leads to
incorrect spacing.
diff --git a/share/static/css/elevator-light/ticket.css b/share/static/css/elevator-light/ticket.css
index 5bf0a1df7e..fb8464af8d 100644
--- a/share/static/css/elevator-light/ticket.css
+++ b/share/static/css/elevator-light/ticket.css
@@ -64,18 +64,6 @@
font-style: normal;
}
-.summary {
- padding-top: .1em;
-}
-
-div#body .ticket-info-basics,
-div#body .ticket-info-people,
-div#body .ticket-info-dates,
-div#body .ticket-info-links,
-div#body .ticket-info-reminders {
- padding-top: .1em;
-}
-
.unread-messages .titlebox-content :link {
text-decoration: underline;
}
commit d0bf13b35ba43a9c7c3a12292af1c7fa8330f6bc
Author: Craig Kaiser <craig at bestpractical.com>
Date: Mon Jan 27 12:59:57 2020 -0500
Remove margin from bottom of titlebox
Having a margin-bottom rule for titleboxes adds unwanted white-space
at the bottom of a titleboxes and the next component. For example
between the last titleboxe in the ticket summay div and the start of
the ticket history div.
diff --git a/share/static/css/elevator-light/boxes.css b/share/static/css/elevator-light/boxes.css
index c334be6238..db1b535319 100644
--- a/share/static/css/elevator-light/boxes.css
+++ b/share/static/css/elevator-light/boxes.css
@@ -1,6 +1,5 @@
.titlebox {
margin-top: 1em;
- margin-bottom: 2em;
padding: 5px;
}
commit 54cb5b918c27dadd493e26b26bf6e4fde33e6ba4
Author: Craig Kaiser <craig at bestpractical.com>
Date: Mon Jan 27 13:13:20 2020 -0500
Remove unecessary <br> tag from ticket History page
diff --git a/share/html/Ticket/History.html b/share/html/Ticket/History.html
index f617380d18..239d4e15f1 100644
--- a/share/html/Ticket/History.html
+++ b/share/html/Ticket/History.html
@@ -50,9 +50,6 @@
% $m->callback( %ARGS, Ticket => $Ticket, CallbackName => 'BeforeActionList' );
-
-<br />
-
<& /Elements/ShowHistory,
Object => $Ticket,
ShowHeaders => $ARGS{'ShowHeaders'},
commit 103d4b930905524b4873e7c9c9653ca963872e51
Author: Craig Kaiser <craig at bestpractical.com>
Date: Mon Jan 27 13:15:26 2020 -0500
Remove uneeded <br> tags from Jumbo page
diff --git a/share/html/Ticket/ModifyAll.html b/share/html/Ticket/ModifyAll.html
index 0a2ce9cabd..b64aa2174c 100644
--- a/share/html/Ticket/ModifyAll.html
+++ b/share/html/Ticket/ModifyAll.html
@@ -72,27 +72,18 @@
<& Elements/EditDates, TicketObj => $Ticket &>
</&>
-<br />
-
-
<&| /Widgets/TitleBox, title => loc('People'), class=>'ticket-info-people' &>
<& Elements/EditPeople, Ticket => $Ticket, UserField => $UserField, UserString => $UserString, UserOp => $UserOp, GroupString => $GroupString, GroupOp => $GroupOp, GroupField => $GroupField &>
</&>
-<br />
-
<&| /Widgets/TitleBox, title => loc('Links'), class=>'ticket-info-links' &>
<& /Elements/EditLinks, Object => $Ticket &>
</&>
-<br />
-
<&| /Widgets/TitleBox, title => loc('Merge'), class=>'ticket-info-merge' &>
<& Elements/EditMerge, Ticket => $Ticket, %ARGS &>
</&>
-<br />
-
<&| /Widgets/TitleBox, title => loc('Update ticket'), class => 'messagedetails' &>
<div>
<div class="form-row input-row">
commit da0c434a9ff01a3d28d04a53dbdfb34baae7dd73
Author: Craig Kaiser <craig at bestpractical.com>
Date: Thu Feb 6 08:56:21 2020 -0500
Remove outdated padding setting specifically for smaller screen sizes
It caused inconsistent spacing. We will tweak padding later for small
screen sizes.
diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index 0b3c2aca91..6b6f9deab4 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -13,23 +13,6 @@ div#body {
z-index: 1;
}
- at media (max-width: 800px) {
- div#body {
- padding: 3em 4.875%; /* 3em at 13px font size => 39px => 39/800 => .04875 */
- }
- /* at narrow widths we'll have broken into a single column, so the default
- padding-right just causes the layout to degrade */
- .boxcontainer {
- padding-right: 0;
- }
-}
-
- at media (max-width: 700px) {
- div#body {
- padding: 3em 0;
- }
-}
-
div#footer {
position: absolute;
text-align: right;
commit 27cdd65c732b520ad817eef8835546d27b14d321
Author: sunnavy <sunnavy at bestpractical.com>
Date: Wed Feb 12 01:09:10 2020 +0800
Wrap Submit into a form-row on ticket modify pages
We do so consistently, and specially as .titlebox doesn't have
margin-bottom any more, we need this to get a decent spacing.
diff --git a/share/html/Ticket/Modify.html b/share/html/Ticket/Modify.html
index 0708753354..a5adee4aed 100644
--- a/share/html/Ticket/Modify.html
+++ b/share/html/Ticket/Modify.html
@@ -65,7 +65,11 @@
<& /Elements/EditCustomFieldCustomGroupings, %ARGS, Object => $TicketObj, AsTable => !!RT->Config->Get('EditCustomFieldsSingleColumn', $session{'CurrentUser'}) &>
-<& /Elements/Submit, Name => 'SubmitTicket', Label => loc('Save Changes'), Caption => loc("If you've updated anything above, be sure to"), color => "#993333" &>
+ <div class="form-row">
+ <div class="col-md-12">
+ <& /Elements/Submit, Name => 'SubmitTicket', Label => loc('Save Changes'), Caption => loc("If you've updated anything above, be sure to"), color => "#993333" &>
+ </div>
+ </div>
</form>
% $m->callback(CallbackName => 'AfterForm', ARGSRef => \%ARGS, Ticket => $TicketObj);
diff --git a/share/html/Ticket/ModifyDates.html b/share/html/Ticket/ModifyDates.html
index c1149bc3ab..c73a02164e 100644
--- a/share/html/Ticket/ModifyDates.html
+++ b/share/html/Ticket/ModifyDates.html
@@ -57,7 +57,11 @@
<&| /Widgets/TitleBox,title => loc('Modify dates for ticket #[_1]', $TicketObj->Id), class=> 'ticket-info-dates' &>
<& Elements/EditDates, TicketObj => $TicketObj &>
</&>
-<& /Elements/Submit, Name => 'SubmitTicket', Label => loc('Save Changes') &>
+ <div class="form-row">
+ <div class="col-md-12">
+ <& /Elements/Submit, Name => 'SubmitTicket', Label => loc('Save Changes') &>
+ </div>
+ </div>
</form>
% $m->callback(CallbackName => 'AfterForm', ARGSRef => \%ARGS, Ticket => $TicketObj);
diff --git a/share/html/Ticket/ModifyLinks.html b/share/html/Ticket/ModifyLinks.html
index 4361deeaa5..1b93d03d2a 100644
--- a/share/html/Ticket/ModifyLinks.html
+++ b/share/html/Ticket/ModifyLinks.html
@@ -65,7 +65,11 @@
<& Elements/EditMerge, Ticket => $Ticket, %ARGS &>
</&>
-<& /Elements/Submit, Name => 'SubmitTicket', Label => loc('Save Changes') &>
+ <div class="form-row">
+ <div class="col-md-12">
+ <& /Elements/Submit, Name => 'SubmitTicket', Label => loc('Save Changes') &>
+ </div>
+ </div>
</form>
% $m->callback(CallbackName => 'AfterForm', ARGSRef => \%ARGS, Ticket => $Ticket);
diff --git a/share/html/Ticket/ModifyPeople.html b/share/html/Ticket/ModifyPeople.html
index 8e08c8e416..0c32293c9d 100644
--- a/share/html/Ticket/ModifyPeople.html
+++ b/share/html/Ticket/ModifyPeople.html
@@ -84,7 +84,11 @@ my $all_recipients_checked = (grep { !$_ } values %recips) ? 0 : 1;
% }
</ul>
</&>
-<& /Elements/Submit, Name => 'SubmitTicket', Label => loc('Save Changes'), Caption => loc("If you've updated anything above, be sure to"), color => "#333399" &>
+ <div class="form-row">
+ <div class="col-md-12">
+ <& /Elements/Submit, Name => 'SubmitTicket', Label => loc('Save Changes'), Caption => loc("If you've updated anything above, be sure to"), color => "#333399" &>
+ </div>
+ </div>
</form>
% $m->callback(CallbackName => 'AfterForm', ARGSRef => \%ARGS, Ticket => $Ticket);
commit 729d5d7f389aace8989daa46ceeecfef90442383
Author: sunnavy <sunnavy at bestpractical.com>
Date: Wed Feb 12 01:28:33 2020 +0800
Fix inconsistent border spacing for nested titleboxes
diff --git a/share/static/css/elevator-light/boxes.css b/share/static/css/elevator-light/boxes.css
index db1b535319..e54a265d68 100644
--- a/share/static/css/elevator-light/boxes.css
+++ b/share/static/css/elevator-light/boxes.css
@@ -89,6 +89,12 @@ div.results .titlebox .titlebox-content {
.titlebox .card-body {
padding-top: 0;
+
+ /* .titlebox parent has 5px padding-bottom, so here we need subtract it
+ * from margin-top(1em) to get consistent border spacing(1em) for nested
+ * titleboxes. Take the borders of "Links", "Ticket metadata" and
+ * "History" on ticket display page for example */
+ padding-bottom: calc(1em - 5px);
}
/* Ticket display page colored top borders */
-----------------------------------------------------------------------
More information about the rt-commit
mailing list