[Rt-commit] rt branch, 4.6/fix-asset-search-bug, created. rt-4.4.4-735-g0a06406c50

[Michel Rodriguez]

The branch, 4.6/fix-asset-search-bug has been created
        at  0a06406c50a3ee2b70cb16194704fb7257641a26 (commit)

- Log -----------------------------------------------------------------
commit 0a06406c50a3ee2b70cb16194704fb7257641a26
Author: michel <michel at bestpractical.com>
Date:   Fri Feb 7 12:54:02 2020 +0100

    Fix bug searching for assets when an asset does not have an owner.
    
    The original code was calling $_[0]->OwnerObj->Id, which crashes
    when the object does not have an OwnerObj (like when an asset has
    no owner).

diff --git a/share/html/Elements/ColumnMap b/share/html/Elements/ColumnMap
index 25b3fe7474..5e3c3046df 100644
--- a/share/html/Elements/ColumnMap
+++ b/share/html/Elements/ColumnMap
@@ -281,7 +281,10 @@ if ($RecordClass->DOES("RT::Record::Role::Roles")) {
 
             if ($role eq 'Owner') {
                 $ROLE_MAP->{$RecordClass}{$role}{edit} = sub {
-                    return \($m->scomp('/Elements/SelectOwner', TicketObj => $_[0], Name => 'Owner', Default => $_[0]->OwnerObj->Id, DefaultValue => 0));
+                    my $owner = $_[0]->OwnerObj;
+                    # if owner is missing (asset with no owner) $owner contains the error message, not an object
+                    if( ! ref $owner ) { $owner = RT->Nobody; }
+                    return \($m->scomp('/Elements/SelectOwner', TicketObj => $_[0], Name => 'Owner', Default => $owner->Id, DefaultValue => 0));
                 };
             }
 

-----------------------------------------------------------------------