[Rt-commit] rt branch, master, updated. rt-4.4.4-758-g791d05f559

? sunnavy sunnavy at bestpractical.com
Wed Feb 12 16:00:18 EST 2020


The branch, master has been updated
       via  791d05f559e136d495174ecf6283a238b019c96e (commit)
      from  f23b3a3cd1c4150a69c65e269301986afc8d0e0f (commit)

Summary of changes:
 share/html/Elements/ColumnMap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 791d05f559e136d495174ecf6283a238b019c96e
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Feb 13 04:41:56 2020 +0800

    Set Owner's edit attr in ColumnMap only for tickets
    
    Currently we only support ticket inline edit, and /Elements/SelectOwner
    itself is also only for tickets right now.
    
    Without this, asset search result page could break as RT::Asset doesn't
    have method OwnerObj defined.

diff --git a/share/html/Elements/ColumnMap b/share/html/Elements/ColumnMap
index 25b3fe7474..2db117fbd3 100644
--- a/share/html/Elements/ColumnMap
+++ b/share/html/Elements/ColumnMap
@@ -279,7 +279,7 @@ if ($RecordClass->DOES("RT::Record::Role::Roles")) {
                 value => sub { return \($m->scomp("/Elements/ShowPrincipal", Object => $_[0]->RoleGroup($role) ) ) },
             };
 
-            if ($role eq 'Owner') {
+            if ( $RecordClass eq 'RT::Ticket' && $role eq 'Owner' ) {
                 $ROLE_MAP->{$RecordClass}{$role}{edit} = sub {
                     return \($m->scomp('/Elements/SelectOwner', TicketObj => $_[0], Name => 'Owner', Default => $_[0]->OwnerObj->Id, DefaultValue => 0));
                 };

-----------------------------------------------------------------------


More information about the rt-commit mailing list