[Rt-commit] rt branch, 4.6/fix-hidden-one-time-suggestions, created. rt-4.4.4-879-gfd251a41c

? sunnavy sunnavy at bestpractical.com
Fri Feb 14 10:58:25 EST 2020


The branch, 4.6/fix-hidden-one-time-suggestions has been created
        at  fd251a41ce9f798f542ffc461d78b217ec706e1e (commit)

- Log -----------------------------------------------------------------
commit fd251a41ce9f798f542ffc461d78b217ec706e1e
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Feb 14 23:51:59 2020 +0800

    Fix hidden one-time suggestions on ticket update page
    
    As we migrated from table to div, "td" needs to be updated accordingly.
    Otherwise, clicking "show suggestions" won't work.
    
    There is also a style tweak to show all the suggestions in a row but
    wrap if necessary.

diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index a1710fffc..aa4be3bd1 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -66,7 +66,7 @@
       <a href="#" class="ToggleSuggestions" data-hide-label="<% $hide_label %>" data-show-label="<% $show_label %>">
         <i class="label">(<&|/l&>show suggestions</&>)</i>
       </a>
-      <div class="OneTimeCcs hidden">
+      <div class="OneTimeCcs d-flex flex-wrap hidden">
 %   }
 
       <i class="col-md-auto">(<&|/l&>check to add</&>)</i>
@@ -118,7 +118,7 @@
       <a href="#" class="ToggleSuggestions" data-hide-label="<% $hide_label %>" data-show-label="<% $show_label %>">
         <i class="label">(<&|/l&>show suggestions</&>)</i>
       </a>
-      <div class="OneTimeCcs hidden">
+      <div class="OneTimeCcs d-flex flex-wrap hidden">
 %   }
 
       <i class="col-md-auto">(<&|/l&>check to add</&>)</i>
@@ -152,7 +152,7 @@ jQuery(function() {
     jQuery('a.ToggleSuggestions').click(function(e) {
         e.preventDefault();
         var toggleSuggestions = jQuery(this);
-        var oneTimeCcs = toggleSuggestions.closest('td').find('.OneTimeCcs');
+        var oneTimeCcs = toggleSuggestions.closest('div').find('.OneTimeCcs');
         oneTimeCcs.toggleClass('hidden');
         var hideOrShow = oneTimeCcs.hasClass('hidden') ? toggleSuggestions.data('showLabel') : toggleSuggestions.data('hideLabel');
         toggleSuggestions.find('i').html('(' + hideOrShow + ')');

-----------------------------------------------------------------------


More information about the rt-commit mailing list