[Rt-commit] rt branch, 4.6/ticket-transaction-theme, updated. rt-4.4.4-583-ge1e741ef6f

[Jim Brandt]

The branch, 4.6/ticket-transaction-theme has been updated
       via  e1e741ef6fefcba068c5a2447e0a299b149ecb7f (commit)
       via  f053ffd02e3398f6664f61a7e2be256b4624a285 (commit)
       via  691dde84a10a121fe00413cb664cd177c52ef8c6 (commit)
       via  1d8b685069b238fc74f3d35c57a84c747d82b53f (commit)
      from  fd0e24ae60705c51059f20b5a84f1c9334c59bcf (commit)

Summary of changes:
 share/html/Elements/ShowTransaction            |  2 +-
 share/html/Elements/ShowTransactionAttachments |  4 ++--
 share/static/css/elevator-light/history.css    | 15 +++++++--------
 3 files changed, 10 insertions(+), 11 deletions(-)

- Log -----------------------------------------------------------------
commit 1d8b685069b238fc74f3d35c57a84c747d82b53f
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Jan 3 11:23:24 2020 -0500

    Restore background color for transaction actions
    
    Competing CSS rules setting the background for actions
    changed the default 4.4 color of #eee to #ccc. Restore
    the previous color and remove additional unused styles.

diff --git a/share/static/css/elevator-light/history.css b/share/static/css/elevator-light/history.css
index 31d7817b5b..fdd1f54b08 100644
--- a/share/static/css/elevator-light/history.css
+++ b/share/static/css/elevator-light/history.css
@@ -20,7 +20,7 @@ div.history-container {
 
 .history .transaction div.metadata span.actions {
  float: right;
- background: #ccc;
+ background: #eee;
  text-align: right;
  border-left: 1px solid #999;
  border-bottom: 1px solid #999;
@@ -118,12 +118,9 @@ div.history-container {
 }
 
 .transaction div.metadata span.actions {
-  background: #eee;
-  color: #eee;
-  display: inline-block;
-  padding: 0.18em 0.06em;
-  border: 1px solid #999;
-  border-radius: .25em;
+    display: inline-block;
+    padding: 0.18em 0.06em;
+    border: 1px solid #999;
 }
 
 @media (max-width: 700px) {

commit 691dde84a10a121fe00413cb664cd177c52ef8c6
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Jan 3 11:50:37 2020 -0500

    Remove legacy square brackets around action items
    
    Long ago RT had visible brackets around transaction actions
    as part of a theme. It seems these were retained in updates
    because the coloring hid the literal brackets around the links.
    
    Remove the brackets and provide padding with CSS.

diff --git a/share/html/Elements/ShowTransaction b/share/html/Elements/ShowTransaction
index 88984bb594..e6b797fb3c 100644
--- a/share/html/Elements/ShowTransaction
+++ b/share/html/Elements/ShowTransaction
@@ -271,7 +271,7 @@ if ( @actions ) {
             .'>'. $a->{'title'} .'</a>'
         ;
     }
-    $actions = join ' ', map "[$_]", @actions;
+    $actions = join ' ', @actions;
 }
 
 # make date unbreakable
diff --git a/share/static/css/elevator-light/history.css b/share/static/css/elevator-light/history.css
index fdd1f54b08..bbb0d15da2 100644
--- a/share/static/css/elevator-light/history.css
+++ b/share/static/css/elevator-light/history.css
@@ -31,6 +31,8 @@ div.history-container {
 
 .history .transaction .metadata .actions a {
     color: #666;
+    padding-left: 5px;
+    padding-right: 5px;
 }
 
 .history .transaction div.metadata  span.type {

commit f053ffd02e3398f6664f61a7e2be256b4624a285
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Jan 3 13:54:03 2020 -0500

    Open transaction details in a new tab
    
    The transaction detail pages have no navigation, so the only
    way back to the ticket is via the Back button. Open in a new
    tab or window to retain easy access to the main ticket display
    page.

diff --git a/share/html/Elements/ShowTransactionAttachments b/share/html/Elements/ShowTransactionAttachments
index 58e8afdd5c..602bc2621f 100644
--- a/share/html/Elements/ShowTransactionAttachments
+++ b/share/html/Elements/ShowTransactionAttachments
@@ -66,14 +66,14 @@ foreach my $message ( @{ $Attachments->{ $Parent || 0 } || [] } ) {
 % if (my $url = RT->System->ExternalStorageURLFor($message)) {
 <a href="<% $url %>">
 % } else {
-<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name | un %>">
+<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name | un %>" target="_blank">
 % }
 % my $download_alt = loc( length $name ? 'Download ' . $name : 'View source' );
 <span class="far fa-file fa-2x" alt="<% $download_alt %>" data-toggle="tooltip" data-placement="bottom" data-original-title="<% $download_alt %>"></span></a>
 
 % if ( $DownloadableHeaders && ! length $name && $message->ContentType =~ /text/  ) {
 % my $download_with_headers_alt = loc('View source with headers');
-<a href="<% $AttachmentPath %>/WithHeaders/<% $message->Id %>">
+<a href="<% $AttachmentPath %>/WithHeaders/<% $message->Id %>" target="_blank">
   <span class="fa-stack" alt="<% $download_with_headers_alt %>" data-toggle="tooltip" data-placement="bottom" data-original-title="<% $download_with_headers_alt %>">
     <i class="far fa-file fa-stack-2x"></i>
     <i class="fas fa-plus fa-stack-1x"></i>

commit e1e741ef6fefcba068c5a2447e0a299b149ecb7f
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Jan 3 13:56:59 2020 -0500

    Make the link icon darker so it stands out less

diff --git a/share/static/css/elevator-light/history.css b/share/static/css/elevator-light/history.css
index bbb0d15da2..eeecf3d12a 100644
--- a/share/static/css/elevator-light/history.css
+++ b/share/static/css/elevator-light/history.css
@@ -99,7 +99,7 @@ div.history-container {
 
 .history .transaction .metadata span.type a {
   font-size: 0.75em;
-  color: #E8E8E8;
+  color: #D3D3D3;
 }
 
 .history .transaction .metadata span.type a#lasttrans {

-----------------------------------------------------------------------