[Rt-commit] rt branch, 4.4/shared-setting-txn, repushed

[? sunnavy]

The branch 4.4/shared-setting-txn was deleted and repushed:
       was c68e945a0b0a2abb41b1d23ad0537a0459574a86
       now 9a44c12bd74b3c1a0f3eebe0b5bfdd42eb5da4dd

1: 57d04305b8 = 1: 57d04305b8 Sort hashes in attribute content to avoid unnecessary updates
2: c68e945a0b ! 2: 9a44c12bd7 Add transaction records for dashboard/savedsearch changes
    @@ -1,6 +1,6 @@
     Author: sunnavy <sunnavy at bestpractical.com>
     
    -    Add transaction record for dashboard/savedsearch changes
    +    Add transaction records for dashboard/savedsearch changes
     
     diff --git a/lib/RT/Attribute.pm b/lib/RT/Attribute.pm
     --- a/lib/RT/Attribute.pm
    @@ -79,7 +79,7 @@
     +    }
     +
     +    # Get values even if current user doesn't have right to see
    -+    $args{'RecordTransaction'} //= 1 if $self->SUPER::_Value('Name') =~ /^(?:SavedSearch|Dashboard|Subscription)$/;
    ++    $args{'RecordTransaction'} //= 1 if $self->__Value('Name') =~ /^(?:SavedSearch|Dashboard|Subscription)$/;
     +
     +    $RT::Handle->BeginTransaction if $args{'RecordTransaction'};
     +
    @@ -128,8 +128,8 @@
     +    }
     +
     +    # Get values even if current user doesn't have right to see
    -+    $args{'RecordTransaction'} //= 1 if $self->SUPER::_Value('Name') =~ /^(?:SavedSearch|Dashboard|Subscription)$/;
    -+    my $old_value = $self->SUPER::_Value( $args{'Field'} ) if $args{'RecordTransaction'};
    ++    $args{'RecordTransaction'} //= 1 if $self->__Value('Name') =~ /^(?:SavedSearch|Dashboard|Subscription)$/;
    ++    my $old_value = $self->__Value( $args{'Field'} ) if $args{'RecordTransaction'};
     +
     +    $RT::Handle->BeginTransaction if $args{'RecordTransaction'};
     +
    @@ -161,7 +161,7 @@
     +                    RT->Logger->debug("Couldn't find ContentHistory, creating one from old value");
     +                    my ( $ret, $msg ) = $self->AddAttribute(
     +                        Name    => 'ContentHistory',
    -+                        Content => $self->SUPER::_Value('ContentType') eq 'storable'
    ++                        Content => $self->__Value('ContentType') eq 'storable'
     +                        ? $self->_DeserializeContent($old_value)
     +                        : $old_value,
     +                    );
    @@ -177,7 +177,7 @@
     +                    my ( $ret, $msg ) = $self->AddAttribute(
     +                        Name    => 'ContentHistory',
     +                        Content => $self->_DeserializeContent( $args{'Value'} ),
    -+                        Content => $self->SUPER::_Value('ContentType') eq 'storable'
    ++                        Content => $self->__Value('ContentType') eq 'storable'
     +                        ? $self->_DeserializeContent( $args{'Value'} )
     +                        : $args{'Value'},
     +                    );