[Rt-commit] rt branch, master, updated. rt-4.4.4-704-g74ace66836

[? sunnavy]

The branch, master has been updated
       via  74ace6683658db68441eb409b64de3225a2ea26d (commit)
      from  9606af6b45da431ad16306e70b532c559e685833 (commit)

Summary of changes:
 share/html/Asset/Create.html  | 10 ++--------
 share/html/Ticket/Create.html |  4 ++--
 2 files changed, 4 insertions(+), 10 deletions(-)

- Log -----------------------------------------------------------------
commit 74ace6683658db68441eb409b64de3225a2ea26d
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Jan 18 03:15:45 2020 +0800

    Switch to direct css to hide details on create pages
    
    The previous javascript hide on load could cause some components to
    briefly render before being hidden. Hiding the Details components with
    javascript allowed all components to render on a single page for users
    running with javascript disabled in the past. RT now requires javascript
    to be enabled.

diff --git a/share/html/Asset/Create.html b/share/html/Asset/Create.html
index ac9cb16b82..12a3bd1f21 100644
--- a/share/html/Asset/Create.html
+++ b/share/html/Asset/Create.html
@@ -45,13 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<& /Elements/Header, Title => loc("Create a new asset in catalog [_1]", $catalog->Name),
-    RT->Config->Get('AssetBasicCustomFieldsOnCreate')
-      ? (
-        onload => "function () { hide('Asset-Create-details') }"
-      )
-      : (),
- &>
+<& /Elements/Header, Title => loc("Create a new asset in catalog [_1]", $catalog->Name), &>
 <& /Elements/Tabs &>
 
 <& /Elements/ListActions, actions => \@results &>
@@ -76,7 +70,7 @@
       </div>
     </div>
 
-    <div id="Asset-Create-details" class="form-row">
+    <div id="Asset-Create-details" class="form-row<% RT->Config->Get('AssetBasicCustomFieldsOnCreate') ? ' hidden' : '' %>">
       <a name="details"></a>
       <div class="col-md-6">
         <& /Elements/EditCustomFieldCustomGroupings,
diff --git a/share/html/Ticket/Create.html b/share/html/Ticket/Create.html
index 35848d74be..1e2de412da 100644
--- a/share/html/Ticket/Create.html
+++ b/share/html/Ticket/Create.html
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 <& /Elements/Header,
     Title => $title,
-    onload => "function () { hide('Ticket-Create-details') }" &>
+&>
 <& /Elements/Tabs &>
     
 <& /Elements/ListActions, actions => \@results &>
@@ -233,7 +233,7 @@
   </div>
 </div>
 
-<div id="Ticket-Create-details">
+<div id="Ticket-Create-details" class="hidden">
 <a name="details"></a>
 <div class="row">
 <div class="boxcontainer col-md-6">

-----------------------------------------------------------------------