[Rt-commit] rt branch, 4.6/fix-inconsistent-ticket-display-spacing, created. rt-4.4.4-723-gd0bf13b35b

[Craig Kaiser]

The branch, 4.6/fix-inconsistent-ticket-display-spacing has been created
        at  d0bf13b35ba43a9c7c3a12292af1c7fa8330f6bc (commit)

- Log -----------------------------------------------------------------
commit 8f04da7ba3aa983e1ab0695c2209d6e698e42a93
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Jan 27 08:15:30 2020 -0500

    Remove <br> tag between metadata and ticket history on display page

diff --git a/share/html/Ticket/Display.html b/share/html/Ticket/Display.html
index 5c2642b32d..1ad1d1c685 100644
--- a/share/html/Ticket/Display.html
+++ b/share/html/Ticket/Display.html
@@ -85,7 +85,6 @@ my $titleright = qq{
 <& /Ticket/Elements/ShowSummary,  Ticket => $TicketObj, Attachments => $attachments, InlineEdit => $InlineEdit &>
 </&>
 </div>
-<br />
 
 % $m->callback( Ticket => $TicketObj, %ARGS, Transactions => $transactions, Attachments => $attachments, CallbackName => 'BeforeShowHistory' );
 

commit 134b6e6b6749d77c2cb4dcd8b24f66ab584d0feb
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Jan 27 12:45:58 2020 -0500

    Remove individual padding rule for ticket elememts
    
    Having unqiue padding rules for only some ticket components leads to
    incorrect spacing.

diff --git a/share/static/css/elevator-light/ticket.css b/share/static/css/elevator-light/ticket.css
index 5bf0a1df7e..fb8464af8d 100644
--- a/share/static/css/elevator-light/ticket.css
+++ b/share/static/css/elevator-light/ticket.css
@@ -64,18 +64,6 @@
     font-style: normal;
 }
 
-.summary {
-    padding-top: .1em;
-}
-
-div#body .ticket-info-basics,
-div#body .ticket-info-people,
-div#body .ticket-info-dates,
-div#body .ticket-info-links,
-div#body .ticket-info-reminders {
-    padding-top: .1em;
-}
-
 .unread-messages .titlebox-content :link {
     text-decoration: underline;
 }

commit d0bf13b35ba43a9c7c3a12292af1c7fa8330f6bc
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Jan 27 12:59:57 2020 -0500

    Remove margin from bottom of titlebox
    
    Having a margin-bottom rule for titleboxes adds unwanted white-space
    at the bottom of a titleboxes and the next component. For example
    between the last titleboxe in the ticket summay div and the start of
    the ticket history div.

diff --git a/share/static/css/elevator-light/boxes.css b/share/static/css/elevator-light/boxes.css
index c334be6238..db1b535319 100644
--- a/share/static/css/elevator-light/boxes.css
+++ b/share/static/css/elevator-light/boxes.css
@@ -1,6 +1,5 @@
 .titlebox {
     margin-top: 1em;
-    margin-bottom: 2em;
     padding: 5px;
 }
 

-----------------------------------------------------------------------